Received-SPF: pass (google.com: domain of linux-kernel+bounces-145974-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 16 Apr 2024 06:30:42 +0800
From: Inochi Amaoto <inochiama@outlook.com>
To: Arnd Bergmann <arnd@kernel.org>, 
	Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, 
	Chen Wang <unicorn_wang@outlook.com>, Inochi Amaoto <inochiama@outlook.com>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-clk@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: sophgo: avoid open-coded 64-bit division
Message-ID:
 <IA1PR20MB49532CE01992005D3DA0FD17BB092@IA1PR20MB4953.namprd20.prod.outlook.com>
References: <20240415134532.3467817-1-arnd@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240415134532.3467817-1-arnd@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: IA1PR20MB4953:EE_|SJ2PR20MB7156:EE_
X-MS-Office365-Filtering-Correlation-Id: a4960e48-404f-472f-f618-08dc5d9ba13e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5olC0qsESMKhihHtM8uuERvBg1P4fz5K3exihcsmNlEXBKTUyCkswCs/d5iF5Fs4JGJ24TclEDnXAoXq2McCW6Ii3T8IhAiU5WER0MSFhV8jbZg2x4xzY2ENTg3bb5QFAaNZf/VVpZffS80TMBTExB5IGatT/Z9l7zZsIikZOM0nnC1GGBeVccoUj6O9DVDNA4zqAkMk2D9Ygkk36Z5LXpovEEeDe5mPnmWF2t478fUtEDaYNGpTQqOCYLbgvtbIPhWOVrQ9H5q15U8DWxts/r2pfjm3wdJJQiiEl/+WVuCyZSi6ODmkVRlyK1XjqCjlojYnI9IDvQYAf8ukezK/2wzV4gBAIFc5bnJ+XYKR/wx1ZC4wkVjUWs3KrQO2A1ljol1N2sFOIqVOxDIps730o0v93MNwz91wWZr4Wu2gMxWZKbMTsD4SV5dnozZqWIGvQ87sLArmDxVMLygSn0w77Or3WkY2/jAp0UouBQ/Kx2FUZBbudi+gln5C3Xon1IwKBxe7hHJHVrML9wBEdHzP35xMN/rOMp9Ixj8l31oUX2u4vQWHBUWn/qen/o9bkbTlRW6Y8bolEnqVPxhiT8sx5VX/1T5stGn4WpDxHGwRSFxDdEq8+G2sKPErZVDvgRovqITpuIKqP2vmGjNxmZGrr08yUO17qIxCD0pWkmn4UWz1ptizIxOkfi7hPM+369Oz12cM0kOlXSJvtzk71Hl3aiZJ9IBmH1cvng2+AlALxzo9ZeMd2/IenmrYbmdJQSI8
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?PrdPKUuUwrnTHQ2e20omrFwi4M0s0K0hEcnDXMwhvCKjsmy3jKJRiCuGTLyD?=
 =?us-ascii?Q?21xymc+yVy8pcPkzm0M6AaqYP8SL0guSqIjTnjg76mnOY4mActzk0QissDMg?=
 =?us-ascii?Q?4N4TDfWst3qW1rropauYAThNAQ65LzvDAUcxd8FCty854Dt9XbbuB282+UkZ?=
 =?us-ascii?Q?BBH66znEFHfzQfRqc2jShs84mSt7ivQvf2yV+oQPUf7pmGf0Xc6Rtg59ftRb?=
 =?us-ascii?Q?mM4HGO6nHmDqcbhro0NPqfkdnYRsMFCYU/J97fFIG8DaMm2TGiW80srkg5DC?=
 =?us-ascii?Q?QhySkU1NTL9a293fHNR9lhjhnLQlImkbLT95yE0b74xU62eVzEK/LF0OIObY?=
 =?us-ascii?Q?rnDZiZbegbLnto0GmWLvgPyh1qlJ6DKXkRV3AJeRykIw0iUSMEFufXdGjAms?=
 =?us-ascii?Q?CtD7pPgll8M1iI8VQxd/kkcKvC3uBZi6RdbZDq51O7gitk+visJW2I4tSUff?=
 =?us-ascii?Q?oygB+buvK0S4vXcudrhGvWzp2Gj5/rpMzI9pzyhvF/gXzD9wmdrii8DhNyKW?=
 =?us-ascii?Q?a0fosSrLW1VLoI2/pzwoCTUcxnk1Xg3PGsqJmxvw6uYYqiC5R4X6xw0yLEBE?=
 =?us-ascii?Q?XENGnQllT9csC/t2npaYWFVra7s3DAUHbclKgjgNZ6Q+iujJhEHICaWT5g+I?=
 =?us-ascii?Q?io8/Mxfgtk76vDI/tM3ns7Vz5lrTWU8tTWjcxkNeVZGoDonCKEEhSgs4jQk7?=
 =?us-ascii?Q?tRpcSle7RbB1fHLeq8i0G7vrXaRzzH8pBtGJHlQzDFcCvPibUcuPn7wHYST/?=
 =?us-ascii?Q?zgDqn2pDUlUjJFkUWjPYIWPfmXy1Puaj3fy9LdMVhACa96ImNMv6SHux6jq7?=
 =?us-ascii?Q?vIoaLRAieRNXCz83xa1GGccctxbd8OcSq+SoLOEpeVk7EX8/MNIqcqzBqOEQ?=
 =?us-ascii?Q?PI8FKedeDU/lorlHA88MlaHp6wYMF0W+cWgZMD3xkdSgh2kPMujB4Tw9IyGP?=
 =?us-ascii?Q?eZB/qGBgnQayVMsfh5baZ4O0xAZvv9tw9wJpLSoU1z5k68D045u5MbCaloQG?=
 =?us-ascii?Q?b2m7t0Em/qTB2NDRywSH8LuSaKlewDPwtHTIty7VgLZuePYT5jxGb/O/Z+zn?=
 =?us-ascii?Q?YnOCVQpO158Xdz9XljIZk9pQ8zqlRao/eqJyb1inNMLO7zxEbMr34YKdlKlE?=
 =?us-ascii?Q?OhVzZx8YGwjQNuwXEiWyBhcavCU4ZuyMV+r9iWK2P0NDhRY2CRTgBuo0L+v9?=
 =?us-ascii?Q?7o2ksJrK57OMoY2wMUKdKamZJr4FVfevNmSuRfbL9yh6c+y6lWft7A31poGR?=
 =?us-ascii?Q?pO9X7reJAdOkCHQOxQrd?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a4960e48-404f-472f-f618-08dc5d9ba13e
X-MS-Exchange-CrossTenant-AuthSource: IA1PR20MB4953.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 22:30:18.9346
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR20MB7156

On Mon, Apr 15, 2024 at 03:45:20PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> On 32-bit architectures, the 64-bit division leads to a link failure:
> 
> arm-linux-gnueabi-ld: drivers/clk/sophgo/clk-cv18xx-pll.o: in function `fpll_calc_rate':
> clk-cv18xx-pll.c:(.text.fpll_calc_rate+0x26): undefined reference to `__aeabi_uldivmod'
> 
> This one is not called in a fast path, and there is already another div_u64()
> variant used in the same function, so convert it to div64_u64_rem().
> 
> Fixes: 80fd61ec4612 ("clk: sophgo: Add clock support for CV1800 SoC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

There is already a fix patch:
https://lore.kernel.org/all/IA1PR20MB4953CB4FCCDE82AB25F6880EBB0B2@IA1PR20MB4953.namprd20.prod.outlook.com/