Received-SPF: pass (google.com: domain of linux-kernel+bounces-146037-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240413022407.785696-1-yosryahmed@google.com> <20240413022407.785696-3-yosryahmed@google.com>
In-Reply-To: <20240413022407.785696-3-yosryahmed@google.com>
From: Nhat Pham <nphamcs@gmail.com>
Date: Mon, 15 Apr 2024 17:29:12 -0700
Message-ID: <CAKEwX=MXKTWzCxPLy8VtdUxM8JFSpX4cR9agMDVtta_O-ZXFVQ@mail.gmail.com>
Subject: Re: [PATCH v3 2/4] mm: zswap: refactor limit checking from zswap_store()
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Johannes Weiner <hannes@cmpxchg.org>, 
	Chengming Zhou <chengming.zhou@linux.dev>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, 
	Dan Streetman <ddstreet@ieee.org>, Vitaly Wool <vitaly.wool@konsulko.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 12, 2024 at 7:24=E2=80=AFPM Yosry Ahmed <yosryahmed@google.com>=
 wrote:
>
> Refactor limit and acceptance threshold checking outside of
> zswap_store(). This code will be moved around in a following patch, so
> it would be cleaner to move a function call around.
>
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>

LGTM!
Reviewed-by: Nhat Pham <nphamcs@gmail.com>