Received-SPF: pass (google.com: domain of linux-kernel+bounces-146083-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <09e235e4-bea5-27d7-6101-15b0a5105a2a@huawei.com>
Date: Tue, 16 Apr 2024 09:17:51 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH 1/2] soc: hisilicon: kunpeng_hccs: Add the check for
 obtaining complete port attribute
To: Wei Xu <xuwei5@hisilicon.com>
CC: <linux-kernel@vger.kernel.org>, <soc@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <Jonathan.Cameron@Huawei.com>,
	<liuyonglong@huawei.com>
References: <20240403081935.24308-1-lihuisong@huawei.com>
 <20240403081935.24308-2-lihuisong@huawei.com>
 <661C8017.1070203@hisilicon.com>
From: "lihuisong (C)" <lihuisong@huawei.com>
In-Reply-To: <661C8017.1070203@hisilicon.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


在 2024/4/15 9:17, Wei Xu 写道:
> Hi Huisong,
>
> On 2024/4/3 16:19, Huisong Li wrote:
>> The hccs_get_all_port_attr() is used to obtained the attribute of all
>> ports on a specified DIE from firmware. However, this interface doesn't
>> ensure whether firmware reports the complete attribute of all ports or not.
>> So this patch adds the check for this.
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> ---
>>   drivers/soc/hisilicon/kunpeng_hccs.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/soc/hisilicon/kunpeng_hccs.c b/drivers/soc/hisilicon/kunpeng_hccs.c
>> index 9ff70b38e5e9..bb69a95b5f2d 100644
>> --- a/drivers/soc/hisilicon/kunpeng_hccs.c
>> +++ b/drivers/soc/hisilicon/kunpeng_hccs.c
>> @@ -556,6 +556,12 @@ static int hccs_get_all_port_attr(struct hccs_dev *hdev,
>>   		start_id = rsp_head.next_id;
>>   	}
>>   
>> +	if (left_buf_len != 0) {
>> +		dev_err(hdev->dev, "do not get the expected port number(%u) attribute.\n",
> How about changing to "failed to get the expected port number(%u) attribute.\n"?
ok, I will fix it in next version.
>
> Best Regards,
> Wei
>
>> +			size);
>> +		return -EINVAL;
>> +	}
>> +
>>   	return 0;
>>   }
>>   
>>
> .