Received-SPF: pass (google.com: domain of linux-kernel+bounces-146190-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
CC: LKML <linux-kernel@vger.kernel.org>, X86 Kernel <x86@kernel.org>, "Peter
 Zijlstra" <peterz@infradead.org>, "iommu@lists.linux.dev"
	<iommu@lists.linux.dev>, Thomas Gleixner <tglx@linutronix.de>, Lu Baolu
	<baolu.lu@linux.intel.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"Hansen, Dave" <dave.hansen@intel.com>, Joerg Roedel <joro@8bytes.org>, "H.
 Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>, Ingo Molnar
	<mingo@redhat.com>, "Luse, Paul E" <paul.e.luse@intel.com>, "Williams, Dan J"
	<dan.j.williams@intel.com>, Jens Axboe <axboe@kernel.dk>, "Raj, Ashok"
	<ashok.raj@intel.com>, "maz@kernel.org" <maz@kernel.org>, "seanjc@google.com"
	<seanjc@google.com>, Robin Murphy <robin.murphy@arm.com>,
	"jim.harris@samsung.com" <jim.harris@samsung.com>, "a.manzanares@samsung.com"
	<a.manzanares@samsung.com>, Bjorn Helgaas <helgaas@kernel.org>, "Zeng, Guang"
	<guang.zeng@intel.com>, "robert.hoo.linux@gmail.com"
	<robert.hoo.linux@gmail.com>
Subject: RE: [PATCH v2 10/13] x86/irq: Extend checks for pending vectors to
 posted interrupts
Thread-Topic: [PATCH v2 10/13] x86/irq: Extend checks for pending vectors to
 posted interrupts
Thread-Index: AQHah6hgttNy4xVG0Emr3Eje1s1aQLFkZmJAgACXWICABVSIQA==
Date: Tue, 16 Apr 2024 03:47:48 +0000
Message-ID: <BN9PR11MB5276129A5784849F2D06104D8C082@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240405223110.1609888-1-jacob.jun.pan@linux.intel.com>
	<20240405223110.1609888-11-jacob.jun.pan@linux.intel.com>
	<BN9PR11MB5276215478903C50701D05498C042@BN9PR11MB5276.namprd11.prod.outlook.com>
 <20240412112331.5a3c1d18@jacob-builder>
In-Reply-To: <20240412112331.5a3c1d18@jacob-builder>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cPE49uNt0sfPmju6T15djiUPBzN9SMqDId845QGTJIfiNt8YWBI3it3CRnJZ?=
 =?us-ascii?Q?VpNyG/zYCgeItL/opzsXnbKi3rXmioP2VrLjHibjMQfzBLmqHa7OxQ5BHJfH?=
 =?us-ascii?Q?HuhK1AZ+QvdHkVS/ruq8KkivRQVaypWREmQpa9jCgHe7oregx6Oc3PDI/amE?=
 =?us-ascii?Q?/jk47UT5IQgKRSrwre0TP9NuEdUXRhy7tXfiY3wEnE5DeBMGZrjwMeAcjBnt?=
 =?us-ascii?Q?FUdMUgHLJrE+3QXT4nvv6CqD2PdFDmOvI0Gt7xTIJkHAMbU9kBsGwmrycxsy?=
 =?us-ascii?Q?nYfhqHTGrOf75lkyQ9ypaC+rNsbzPTIKByN4OzfeBQs6DypblIg8jeRU4wo1?=
 =?us-ascii?Q?RhNZZQzaP3sGr9/PoH+w+eKsj9YOhoKyGpiMn0FKWzb9QndDNivEpZ4HBc48?=
 =?us-ascii?Q?4Rj+KoQmR4Mvcs4oJByAZP56rFdVDTwoWj/t/KS2m/lRARayQ1QSCFNllbBQ?=
 =?us-ascii?Q?ZOi7fFbTaoe6dgMF7PhYZMQacFb/r6gKqF28Dw0v4lIBZd4WixX0bIo2O9/s?=
 =?us-ascii?Q?iv14LQcis8Ctdb0LpswUR9CkvLYSJfFwpP1z5GJGDPBMnSYlVLY3Ye15A/2c?=
 =?us-ascii?Q?oyFZAhkKXhFNwnuze3xNYu9HNHXpOfo8uafDIK2c3xOWcnpy3GnkVX9eRM5Q?=
 =?us-ascii?Q?ROfJdEgDxDrispZbf1RSoS2qmVPhWW+PkM+QDAlaOUAoXfhetYL2xr9aEGgt?=
 =?us-ascii?Q?IPq9rmXww77Lv+BlWaRlxVqWRHfnnDfCR3TD0+Hf6rBG4AqxiQ8iMoR1HPcl?=
 =?us-ascii?Q?3+G11EloRnr5+8lo81LHwrtbBL+V50uMZGBCKnwqu3/D0hOMbtKXLo70wMxX?=
 =?us-ascii?Q?G9ZCq/i5htuIKX04rrOgppgoj1QG6o8zv1yAUSrQnBzD5JBwVVJqgyB8q+f5?=
 =?us-ascii?Q?vvqG+3MNzOVp7+hnHfV5SpCwmpv0elQMXGV+vPQOWdEgqXGza2Vju4tsde6+?=
 =?us-ascii?Q?i5q7uStoGocEfZpydqs6W9QCCQev8GMvEhsUTEdnGnApSqJKGSy+JVnXTmkN?=
 =?us-ascii?Q?yUBqX5EdNC/0ZjDC14tIIEyiCg4DPRb4MK2WiXq7M1ufHwKYS5lSYtdxXFXr?=
 =?us-ascii?Q?34Vy2xtxHmb3FaK3YHk7e2lRcY+TMjwx8OOtNV9MnF8op0LtinNtBtWSbaW0?=
 =?us-ascii?Q?3sLsiWo3dghfsTi8beZYNzCi2HrNKLWu7DPUchfVeqSnCLmSIhfIo5Aosu+b?=
 =?us-ascii?Q?X/NlsLjd4ZCDh0oaJ3mWl4z31Avg5Wfwb6ZGlwCMusAHSMYYhlxiT+67okqG?=
 =?us-ascii?Q?MuGYuJVrqi1dG0/dOOFanTxRy3Q981owlAyWFN7jh/w6XjmSSjmp4LoaiUrf?=
 =?us-ascii?Q?0FlD6iUI6OdnZW73/4IDGKJ32n79/3Ev1R2kwaMnbOuULULaJCgSLMaaqXLH?=
 =?us-ascii?Q?+N4XoHzijN6QSQr+26PZbqxqV5pAfobntZaFnHpRf7sIZujsVDXHdveT+xK/?=
 =?us-ascii?Q?5CEbNo3srfY85b02uldEVJ47t+3B5L7/o0amRH2VSVSJJMMbZeLbjVISqSpD?=
 =?us-ascii?Q?HZpoRMNbzXicU0XQeB0DpoedxoTSg+Txy7vqTapYoWbE0LDpTCGmvEg++0x3?=
 =?us-ascii?Q?SqBbzSKbfwBChaAQTp/Nv2gfIwEmZ2g+h9Gxu8tG?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 567dbb34-a5d0-4ea1-fc73-08dc5dc7fbfd
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2024 03:47:48.6975
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QTHMJCqReRjpIrhvJYS7d2/TXv3a28bNmO0LAQRkB6tBLaOKKr8P5diOoadbwOjYcxIQHr8HVR6oC99RQ1F+kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6010
X-OriginatorOrg: intel.com

> From: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Sent: Saturday, April 13, 2024 2:24 AM
>=20
> Hi Kevin,
>=20
> On Fri, 12 Apr 2024 09:25:57 +0000, "Tian, Kevin" <kevin.tian@intel.com>
> wrote:
>=20
> > > From: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > > Sent: Saturday, April 6, 2024 6:31 AM
> > >
> > > During interrupt affinity change, it is possible to have interrupts
> > > delivered to the old CPU after the affinity has changed to the new on=
e.
> > > To prevent lost interrupts, local APIC IRR is checked on the old CPU.
> > > Similar checks must be done for posted MSIs given the same reason.
> > >
> > > Consider the following scenario:
> > > 	Device		system agent		iommu
> > > 	memory CPU/LAPIC
> > > 1	FEEX_XXXX
> > > 2			Interrupt request
> > > 3						Fetch IRTE	->
> > > 4						->Atomic Swap
> > > PID.PIR(vec) Push to Global
> > > Observable(GO)
> > > 5						if (ON*)
> > > 	i						done;*
> >
> > there is a stray 'i'
> will fix, thanks
>=20
> >
> > > 						else
> > > 6							send a
> > > notification ->
> > >
> > > * ON: outstanding notification, 1 will suppress new notifications
> > >
> > > If the affinity change happens between 3 and 5 in IOMMU, the old CPU'=
s
> > > posted
> > > interrupt request (PIR) could have pending bit set for the vector bei=
ng
> > > moved.
> >
> > how could affinity change be possible in 3/4 when the cache line is
> > locked by IOMMU? Strictly speaking it's about a change after 4 and
> > before 6.
> SW can still perform affinity change on IRTE and do the flushing on IR
> cache after IOMMU fectched it (step 3). They are async events.
>=20
> In step 4, the atomic swap is on the PID cacheline, not IRTE.
>=20

yeah, I mixed IRTE with PID.