Received-SPF: pass (google.com: domain of linux-kernel+bounces-146194-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240415171857.19244-1-ryncsn@gmail.com> <20240415171857.19244-4-ryncsn@gmail.com>
 <Zh16ndI5aN8r4yOR@casper.infradead.org>
In-Reply-To: <Zh16ndI5aN8r4yOR@casper.infradead.org>
From: Kairui Song <ryncsn@gmail.com>
Date: Tue, 16 Apr 2024 11:51:31 +0800
Message-ID: <CAMgjq7Bg_p8ztuOy=25CR5u_=ZXRx64L5DxQm9mWEp-BJAq4sA@mail.gmail.com>
Subject: Re: [PATCH v3 3/4] lib/xarray: introduce a new helper xas_get_order
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 16, 2024 at 3:06=E2=80=AFAM Matthew Wilcox <willy@infradead.org=
> wrote:
>
> On Tue, Apr 16, 2024 at 01:18:55AM +0800, Kairui Song wrote:
> >  /**
> > - * xa_get_order() - Get the order of an entry.
> > - * @xa: XArray.
> > - * @index: Index of the entry.
> > + * xas_get_order() - Get the order of an loaded entry after xas_load.
>
> I'd just leave that as "Get the order of an entry." as it doesn't have
> to be after calling xas_load(), it could be from any other operation
> that moves xas.  Also this is the short description!

Good suggestion!

>
> >               if (slot >=3D XA_CHUNK_SIZE)
> >                       break;
> > -             if (!xa_is_sibling(xas.xa_node->slots[slot]))
> > +             if (!xa_is_sibling(xas->xa_node->slots[slot]))
>
> Could you fold in this change I have locally?
>
> -               if (!xa_is_sibling(xas->xa_node->slots[slot]))
> +               if (!xa_is_sibling(xa_entry(xas.xa, xas.xa_node, slot)))
>
> That fixes a sparse warning which existed before your modifications.
>

OK.