Received-SPF: pass (google.com: domain of linux-kernel+bounces-146221-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 15 Apr 2024 21:23:10 -0700
From: Vanshidhar Konda <vanshikonda@os.amperecomputing.com>
To: Beata Michalska <beata.michalska@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
	ionela.voinescu@arm.com, sudeep.holla@arm.com, will@kernel.org, catalin.marinas@arm.com, 
	vincent.guittot@linaro.org, sumitg@nvidia.com, yang@os.amperecomputing.com, 
	lihuisong@huawei.com
Subject: Re: [PATCH v4 4/4] cpufreq: Use arch specific feedback for
 cpuinfo_cur_freq
Message-ID: <76zutrz47zs6i2cquvjo2qn7myxpq7e3c6alhper7n3wrkhf5h@22l5t5pio2cd>
References: <20240405133319.859813-1-beata.michalska@arm.com>
 <20240405133319.859813-5-beata.michalska@arm.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20240405133319.859813-5-beata.michalska@arm.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?p1+KBZ/zVpoYNaLzIEzXap0eCvED9WqZQG8TlKwTgoqjR21cRCvXqPiI11r9?=
 =?us-ascii?Q?l6PBGwqwPKWbJ1+j7CrcXBvVPAEkTMnvwQZ469XMVVaJXHRH5U8WjDv+MsJx?=
 =?us-ascii?Q?IM0t04YGM9l8y3QnzgWLY66WwSNX/tZWZtGid0nzxiRJi3jEgl9xNW4yc9Ga?=
 =?us-ascii?Q?6JddPyk+LANUKmT6X+95uklmwQmAljo1D+B8aQ5tNUEDflkJziKqDvgPTNRB?=
 =?us-ascii?Q?Ib2OVYIc1TJQkbFMgJILmMJjfr4ZwGmNo0FmWCTVIds3nZPwE875x8KSAlzE?=
 =?us-ascii?Q?gDfhwvwikPczJWhGdkzHSwjcUM+M6qwffIzPAzpISYwUS8t02/kxKCSUl3Iz?=
 =?us-ascii?Q?f0iOyQLmkkNNUhcIgJ8m003KbyMxn96CSPlO0eD8BEa+V/chp0CrJz4jm3pq?=
 =?us-ascii?Q?ppAdxEY/9oRUfBjUqNqTaVj3hx+lot6rZrVP1uYJIabD2woFZhTAjYvgMGgF?=
 =?us-ascii?Q?/p5q3Y0Y6Qj8Gr0jUBl1LZr4nSzniy7jKTv7idcS+mzncVma1/vNGa0f5p8J?=
 =?us-ascii?Q?kXE07wFMWSikRvZ6z2GdfHVMBlZo+R4N+Z+r5L0EJC6TOYeRH8Zizap1V8Ai?=
 =?us-ascii?Q?LVj1GwTAduNm9ZYJcttC9UmKkMNSd8QOfbFZEAUDI/ATD3KJxGT5j6ohxXFu?=
 =?us-ascii?Q?RwCgSqn0Ah+/LgmPC9RHjDOMySAOm/Qh9CuM1GF5aSfR7yUU9mQNCn58Ua1U?=
 =?us-ascii?Q?15n2vn6GU2ux9/9zSn8FM7R1p99N6/e7XYZcuQPNAKodFRAvxth6NRHtfWRI?=
 =?us-ascii?Q?Y+PySNfeLUJlKTh2NHwVrBLU2k19Ph83Mttnp7YY8PlnW5MRhPvm59hqYWPL?=
 =?us-ascii?Q?8g8ykeMUA5JE9A8KgVvL3kfgeoK6g6DAKNjDZ27HNueY76Jj8SLE6G1onY8N?=
 =?us-ascii?Q?HydoD9rKKJ3dAuS8FZMOkpw2i3UVAGKIwOV3rMY22YU4RSRrtSxv+tZWJdR/?=
 =?us-ascii?Q?NlQoK3ep8kjmtgjbkJ9YxfA67nMECWYpeuWgIswmU+gOmkjoa71isprbQGKn?=
 =?us-ascii?Q?VEKaxf+/qzf5Y0qJN/vL3mdMIzQKFDMyFpE8Q+23mTNfEoNZVcghXSUArSx6?=
 =?us-ascii?Q?THLutaCcfVWOIjOt8XLzpAupxE10soiMC8eROHlpAiszWdhNQyr6xfNoV9mP?=
 =?us-ascii?Q?fZiNGYAETTDoTMgd7Do4OhKY5scEbhnnjzY8uvvwo1EFRc0SsA/6bY+0OYtS?=
 =?us-ascii?Q?fnJ9SdoXDcNzer+msPE3m0S23LG5s8SOxcRfDAGG6d+eg9v6t8XfunIItVVX?=
 =?us-ascii?Q?XYCVO7JddtE8a9ixyLFazVOHWOn3Lud7RoUtjrgrn0MlahRsSiX/WRfOK0dF?=
 =?us-ascii?Q?nlJC9a00unyGlsfuB3kiwPhHBYOy0tjCao/QKOakh9D0q1gIvtO9kSbdkaUJ?=
 =?us-ascii?Q?0ZPHCHevAU7Ae7rrHygtMWS9nk6i4uIBXscPmh4h4GyYqvK7TFrqcDvwFjvn?=
 =?us-ascii?Q?NRb024SSU+r8BI0oEeDwKDpxduABBPe9OR5OoxMoakt2Ibdnp05H6TVJiq5W?=
 =?us-ascii?Q?GMy4Vc58SWg0elc5O8Dy/yjhw1S7MKZRTdylOFg3qgknwb4wmeAgpFhiUgtu?=
 =?us-ascii?Q?HKQPCPfGmKveew7BXNh7jTczyvjX228xRcyR96aWO8ksHJs3z76nH2N50Hm5?=
 =?us-ascii?Q?RqyT4VTrqkQUJ10bYHrn2gw=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e23f762-c9fc-4208-eeb1-08dc5dccee69
X-MS-Exchange-CrossTenant-AuthSource: MW4PR01MB6498.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 04:23:13.6354
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pxZrgJ7pXUUIyEACKu+52WcyVNlkkUM4BZpBFTNVMNYoBCWIQCkMxg6PRy3m6478ZxQ36e3AeFz8EByD5aoE5jnXHxUkbnDJ9f2qxBgH4nLgofIej4JBy/qcG57thL+j
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR01MB7742

On Fri, Apr 05, 2024 at 02:33:19PM +0100, Beata Michalska wrote:
>Some architectures provide a way to determine an average frequency over
>a certain period of time based on available performance monitors (AMU on
>ARM or APERF/MPERf on x86). With those at hand, enroll arch_freq_get_on_cpu
>into cpuinfo_cur_freq policy sysfs attribute handler, which is expected to
>represent the current frequency of a given CPU, as obtained by the hardware.
>This is the type of feedback that counters do provide.
>

--- snip ---

While testing this patch series on AmpereOne system, I simulated CPU
frequency throttling when the system is under power or thermal
constraints.

In this scenario, based on the user guilde, I expect scaling_cur_freq
is the frequency the kernel requests from the hardware; cpuinfo_cur_freq
is the actual frequency that the hardware is able to run at during the
power or thermal constraints.

The AmpereOne system I'm testing on has the following configuration:
- Max frequency is 3000000
- Support for AMU registers
- ACPI CPPC feedback counters use PCC register space
- Fedora 39 with 6.7.5 kernel
- Fedora 39 with 6.9.0-rc3 + this patch series

With 6.7.5 kernel:
Core        scaling_cur_freq        cpuinfo_cur_freq
----        ----------------        ----------------
0             3000000                 2593000
1             3000000                 2613000
2             3000000                 2625000
3             3000000                 2632000

With 6.9.0-rc3 + this patch series:
Core        scaling_cur_freq        cpuinfo_cur_freq
----        ----------------        ----------------
0             2671875                 2671875
1             2589632                 2589632
2             2648437                 2648437
3             2698242                 2698242

In the second case we can't identify that the CPU frequency is
being throttled by the hardware. I noticed this behavior with
or without this patch.

Thanks,
Vanshi