Received-SPF: pass (google.com: domain of linux-kernel+bounces-146225-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 15 Apr 2024 21:29:27 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Danielle Ratson <danieller@nvidia.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>, <edumazet@google.com>,
 <pabeni@redhat.com>, <corbet@lwn.net>, <linux@armlinux.org.uk>,
 <sdf@google.com>, <kory.maincent@bootlin.com>,
 <maxime.chevallier@bootlin.com>, <vladimir.oltean@nxp.com>,
 <przemyslaw.kitszel@intel.com>, <ahmed.zaki@intel.com>,
 <richardcochran@gmail.com>, <shayagr@amazon.com>,
 <paul.greenwalt@intel.com>, <jiri@resnulli.us>,
 <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
 <mlxsw@nvidia.com>, <petrm@nvidia.com>, <idosch@nvidia.com>
Subject: Re: [PATCH net-next v2 07/10] ethtool: cmis_cdb: Add a layer for
 supporting CDB commands
Message-ID: <20240415212927.2c87ddca@kernel.org>
In-Reply-To: <20240415120717.1251864-8-danieller@nvidia.com>
References: <20240415120717.1251864-1-danieller@nvidia.com>
	<20240415120717.1251864-8-danieller@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 15 Apr 2024 15:07:14 +0300 Danielle Ratson wrote:
> +	page_data->data = kmalloc(page_data->length, GFP_KERNEL);
> +	if (!page_data->data)
> +		return -ENOMEM;
> +
> +	memcpy(page_data->data, data, page_data->length);

coccicheck suggests to use kmemdup() here:

net/ethtool/cmis_cdb.c:504:19-26: WARNING opportunity for kmemdup
-- 
pw-bot: cr