Received-SPF: pass (google.com: domain of linux-kernel+bounces-146242-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <065243cc-09cf-4087-8842-bd4394fb324f@amperemail.onmicrosoft.com>
Date: Tue, 16 Apr 2024 11:52:58 +0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 3/3] dt-bindings: hwmon: max31790: Add
 maxim,pwmout-pin-as-tach-input property
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Chanh Nguyen <chanh@os.amperecomputing.com>, Jean Delvare
 <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Justin Ledford
 <justinledford@google.com>, devicetree@vger.kernel.org,
 linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
 OpenBMC Maillist <openbmc@lists.ozlabs.org>,
 Open Source Submission <patches@amperecomputing.com>
Cc: Phong Vo <phong@os.amperecomputing.com>,
 Thang Nguyen <thang@os.amperecomputing.com>,
 Quan Nguyen <quan@os.amperecomputing.com>
References: <20240414042246.8681-1-chanh@os.amperecomputing.com>
 <20240414042246.8681-4-chanh@os.amperecomputing.com>
 <13b195e6-cbbd-4f74-a6fa-d874cb4aaa45@linaro.org>
Content-Language: en-US
From: Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
In-Reply-To: <13b195e6-cbbd-4f74-a6fa-d874cb4aaa45@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Si9DWGhEVno5OXZ1NE9VelRxUGhGenBuWDF3ckl4cnU5MDFwKzNVbmEwNEx4?=
 =?utf-8?B?NnYvVHB5U0EyRnhlNEREaXRXVDRTNXBNTWFKWU9LOTFBV3FBdUNzL0ZqSDVh?=
 =?utf-8?B?N2pxK2doRUtWYnhwZ3BlSkNRVm5RNHVpWWpmRmxPc25YSDliUmZiRThKaExM?=
 =?utf-8?B?SFZrcXFkR01TaXFkU1FjaVJtQWwrY0trcGFrTDRONWxTeEhTQyszdFdsLzVh?=
 =?utf-8?B?WktNY0VGZnZTdkxNQUdURUE5MCtERWE2cU43N3RZcC8vYndzTCtOYU1IRzdG?=
 =?utf-8?B?TGJFU0pJNjBmSy96YW1BZHM1bEdEcnBCeTR1K2hyZ2dqVzFBRnpSOXNYY1B6?=
 =?utf-8?B?ZDFSZDU4ZlVibCt3NDdFM0VBVWJjNS9WVDh3amh2RTFIN1NNeWpudU4rZDV4?=
 =?utf-8?B?WDdTdzRwNWNBdlgrblJBTnZJSk9MeUdrcC9YcE1Ba3NtSXA0SmNjRzlYOHJl?=
 =?utf-8?B?QlZhVDBDZHVmdXhGb3RLRG5ISlFzYkgwZlluR1RjeFdjTDNOMFlaaDRUdzNm?=
 =?utf-8?B?TEhxMnM5UzVld1hGYVdkR1gzbzBTUjRoS1JvOTlReC80ZUVxdDlLRmxFdjY4?=
 =?utf-8?B?elN3VXlqNGFWYVY1TG9IdlUvOE43WDZnTFhEUnJYUjdLRHBWMGhrMW5Nck5r?=
 =?utf-8?B?Z2FBZ0xwZ1BoUU1nbS9iN2hCbGR4VkVGRFFKYUpwdFdNWnM4T1NLOEhzOXNF?=
 =?utf-8?B?NlBHb2JJb1dqWk1keG5MVVM4RVdSbmYvNk9qZURyQzB4MFFwUDZzL0FhTU1i?=
 =?utf-8?B?QzQvNEdQMGFtcVQ4QUpMbTNFLzl5eU5mZXRxeFM5Q3N0S0hRWDBlamFuSjc5?=
 =?utf-8?B?Q3U5S21OQTZmeVg4bmc2WXVPZmdxbjhCY1RiaU1nUVNpSGVjUEdHc3FNMjBl?=
 =?utf-8?B?b3R0ME1tWVBaZHpZQmp0QnNUN3MyQ3oxUC95NWNpWkxGcncvZHBqa0p5L3hE?=
 =?utf-8?B?aXF0RUN1dWJCdVZOaGgwTlZWeDZxRUZtdHhUaThHSnpVUkdEWVdVZmF6ekVu?=
 =?utf-8?B?ZjhNTWxjWkZGVTdSYm5mb1REUWlVdkkwTGl2UXhKdnNoSzhxNVA0Q1VRVWtM?=
 =?utf-8?B?V2lkb2VxUXlsZjRwOWp1NHRvWWc2SUcxRzhRQ3JXb3VBUlFIaFBOc0FaU1ZZ?=
 =?utf-8?B?Slk1bFIyZ2Y5cG5SWnArdEpKME5TV1VMNngxVFEzSmtQOFdoYkljeTVRcHFU?=
 =?utf-8?B?RE4yc3Q2WDlxUlVFUElCaCtkUDlRZzBxdFAyVGwwMFAvckFwd3FlY0ZNNHFz?=
 =?utf-8?B?QUNMQU51SEJvTjZXSnllMEErM2dibWsySGp4RXJ5VnBiNnBpZm12VVJKeEVQ?=
 =?utf-8?B?b0hXQUQ1emNaV2RJUVVrTE9WNkZ0dmNRS1hwWUl0amY3R3hlZk5NbC9VV0R0?=
 =?utf-8?B?Qi9rNFFUd0c1VVhqMVgxNkJaL2ZVWkovZ1JPdmZZR1BvTFkrUkR2MDB6UUIy?=
 =?utf-8?B?bjNuMzBJcW5nbkRVWUU3MERhcTdwdDZqY0gvaXdzK25EYkhJcXFNSnlrdkdV?=
 =?utf-8?B?T3p2VUUwblVvY3dDNk9kSWt4cHBZc1FNVjRzZU91U21ZSzJkZTFodTU1RDR5?=
 =?utf-8?B?TndpRmxza1NVUkZjZFE0d3pJUTVVOHplSGY5akdYK1N1dklNRmppTm5QTU9r?=
 =?utf-8?B?L3pMY2VJT09RNlp3dHJGKzFFb2JpYTNEMlRqQWZvUGttWkpUa0FTdWNqOFgw?=
 =?utf-8?B?V2VuVllhUXpxVS9EbEVYWVZKem8xRi8zY3FFdW5vdndBQitkSlUyVSsyYWtm?=
 =?utf-8?B?ZGljMHhIZlpiN3Avd2g4a0FkejJPa0Y2TVd4K1FWaUNjeWRkOFc1b3NDQm9P?=
 =?utf-8?B?N2d1QVpKQmpvd1hJRlk4YTVIMThJM3IrbnBBanJjSUlqeks3TmxpQUNqQ2JS?=
 =?utf-8?B?Y2lYRktPbTFVMFhhbHhNdHBlSTJwVkU3YkFnckp5RHNUVkFweWJpdjBsTmNI?=
 =?utf-8?B?bSs5UGxSQi8xa3QyT2xjU2UycHVMTVNRUHZCa2U1TmhYN0tiWFJQSUxrRGZL?=
 =?utf-8?B?VXRyZ2gwRHJBTnN0NU5yWkYva2JzQ1NQNG1FeFJMK0Vid2VDelJnSytyWGVD?=
 =?utf-8?B?aFQzQTdyViswSlg1L1kxZVorQXdMbzJhVWFsVkZJS1NpcUZFWVdydkVsbGZP?=
 =?utf-8?B?TzZTd093THJJR3pDZHE5c1JWQmpNZzlrNFhTUTVCdFhpd3NEaE9lQkpvNlJ1?=
 =?utf-8?Q?l9RtCINBemgcO9wD4+NcHlc=3D?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46423229-9995-4785-a908-08dc5dd11e1d
X-MS-Exchange-CrossTenant-AuthSource: DM6PR01MB5947.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 04:53:11.5978
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VWtZadn1zTS95l6PMaZqudrSYQ6IHY684CzmbqQ0+3KaRedBwNPZSXopkom3L9vwJHZhSjTDlvtwKFK0c7E+SO7rP6hSTFVntR9ik0EHzPoO8uUeAU+zjhcvsexdHqZm
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR01MB8182


On 14/04/2024 13:07, Krzysztof Kozlowski wrote:
> On 14/04/2024 06:22, Chanh Nguyen wrote:
>> The max31790 supports six pins, which are dedicated PWM outputs. Any of the
>> six PWM outputs can also be configured to serve as tachometer inputs,
>> allowing for up to 12 tachometer fans to be monitored.
>>
>> Add a new vendor-specific property, 'maxim,pwmout-pin-as-tach-input',
>> to allow PWMOUT to become a TACH input.
>>
>> An array of six integers responds to six PWM channels for configuring
>> the PWM to TACH mode. When set to 0, the associated PWMOUT produces
>> a PWM waveform for control of fan speed. When set to 1, PWMOUT becomes
>> a TACH input.
>>
>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>> ---
>> Changes in v2:
>>   - Update the vendor property name to "maxim,pwmout-pin-as-tach-input"   [Rob]
>>   - Update commit message                                                 [Krzysztof]
> 
> Please put binding before its user.
> 

Hi Krzysztof, I'll drop this [Path 3/3] in the patch series v3.

My patch series will only be two patches. They are "dt-bindings: hwmon: 
Add maxim max31790" and "hwmon: (max31790): Support config PWM output 
becomes TACH"

>> ---
>>   .../devicetree/bindings/hwmon/maxim,max31790.yaml     | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
>> index a561e5a3e9e4..2d4f50bc7c41 100644
>> --- a/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
>> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max31790.yaml
>> @@ -30,6 +30,16 @@ properties:
>>     resets:
>>       maxItems: 1
>>   
>> +  maxim,pwmout-pin-as-tach-input:
>> +    description: |
>> +      An array of six integers responds to six PWM channels for
>> +      configuring the pwm to tach mode.
>> +      When set to 0, the associated PWMOUT produces a PWM waveform for
>> +      control of fan speed. When set to 1, PWMOUT becomes a TACH input
>> +    $ref: /schemas/types.yaml#/definitions/uint8-array
>> +    maxItems: 6
>> +    minItems: 6
> 
> tach-ch solves your case. You define which inputs should be used for tach.
> 

Agree Krzysztof. I'll use the tach-ch property from the fan-common.yaml 
to solve my case. So I will not need to define a new vendor property as 
"maxim,pwmout-pin-as-tach-input". I'll drop this [Path 3/3] in the patch 
series v3.


> Best regards,
> Krzysztof
>