Received-SPF: pass (google.com: domain of linux-kernel+bounces-146245-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 15 Apr 2024 21:55:41 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Tom Lendacky <thomas.lendacky@amd.com>, <linux-kernel@vger.kernel.org>,
	<x86@kernel.org>, <linux-coco@lists.linux.dev>, <svsm-devel@coconut-svsm.dev>
CC: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>, "Peter
 Zijlstra" <peterz@infradead.org>, Dan Williams <dan.j.williams@intel.com>,
	Michael Roth <michael.roth@amd.com>, Ashish Kalra <ashish.kalra@amd.com>
Subject: Re: [PATCH v3 10/14] configfs-tsm: Allow the privlevel_floor
 attribute to be updated
Message-ID: <661e04cd345af_4d56129468@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <cover.1711405593.git.thomas.lendacky@amd.com>
 <bb088b1409283cd323515138feda224759a247ec.1711405593.git.thomas.lendacky@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <bb088b1409283cd323515138feda224759a247ec.1711405593.git.thomas.lendacky@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LkDl5qxC0uXOl9Z/D39v4khjjrMtx0BJhMgipHTyP0KmYHv+kk+I+3y/uiFk?=
 =?us-ascii?Q?K0wWkwD+PLhrjZCwKqKvqWHyujyNcpgtWLriwjOLrV48BcqKGgtjp+0LbZjf?=
 =?us-ascii?Q?XqLUfkF9DV4Ny3AWbXFr9H9mYXKf6tiH1P1nGiMflDUlaupgr/m4JcCpXJXx?=
 =?us-ascii?Q?3OOlTPbtuZx7/qOeK7u6AGWJw0YWxvedxXYkUy2j/2TBFUArZJZXlMo12c1f?=
 =?us-ascii?Q?2JsC0IRe3U3oPA3JHzyTViyw8yLDS52hPEsNzWatMBgn4ClqSIwRHIDT4meT?=
 =?us-ascii?Q?r3CG00w19E9JnzGINqUVpJg5v63LcqgVNOBCpQc/Aow946mDhZ0Z8SAKPnc9?=
 =?us-ascii?Q?0jaF40pMVxbLzMPE/vie7i/8DpzwewPJomj3bxUWDqegjFNJy4SiSxE4x3k1?=
 =?us-ascii?Q?0bEFy360yLKL9H5EXfSNUcNBGX8DVa1Vw2ZKXUH6NADRZMTJD6Fbh/VqMlBJ?=
 =?us-ascii?Q?91a5kCsKXwqQhARecGM2F/On0Knv77GgM1VB2yn4Y7HHVvIxseNl/HzDvz1C?=
 =?us-ascii?Q?6JxdDWNQuacoh8Gx5IGTjYBscXaDiB5TMVhZqn2KQGV4XILC92SUTxjpoYJ9?=
 =?us-ascii?Q?n2BMENx1iy9/VpwNWd7xGd3ttrFcnlj2vpVxFpAWGtPizv5YgNfCtESR4pVm?=
 =?us-ascii?Q?CwtBQ90sBCZ1hHKX4VYJqMOqn1ecnDkxnlgNTJzMPCYkkTRd5LBOFiqqM2hk?=
 =?us-ascii?Q?0XQUvnZe+P/nZ0af1u44GUVOR9eEazmel0taL25cIFJ5mVPFFWlzk/RcIaIq?=
 =?us-ascii?Q?8vAaGk0BRZ1LNdcBu8BLmn1lMgdPo0L3gKEcmw8ySjLA3toPmL+COnqOclJF?=
 =?us-ascii?Q?nxSntRrcDRstnZTV+trg6FWShK+O7Hbusq+95laYokaDfeXgjg+SGayuL9Jj?=
 =?us-ascii?Q?w0j2FPK+6/z2rJYtuhYT9UXyvasdlpUwePnN1hsq1Z3EDy0UibNaEZEia79w?=
 =?us-ascii?Q?GAwIaSy2oGhQmP6zRQ9hRKobOrBkoXX4kwxU8kyR+jhNOUpulYX97lHUayi+?=
 =?us-ascii?Q?JGxHFlI+c1mHpAifdcRTVymugOUcXZwTxCWZJMx72/g+xDmvHGhA87wWZagy?=
 =?us-ascii?Q?F9NLAD0sQSgPInZ0qxZbEdLqVPXb+8q2PD4YiqjYKQl/KoQOGSpZYOdCA4Gz?=
 =?us-ascii?Q?bdPVklRP6CaxGAG9+ejl4qKHDvllPaJo2LuPoiGIURCKH9aeVy+n5qt1UnNH?=
 =?us-ascii?Q?O6oIOjygDP2CEOlGfMtG17Nzy2qwHX6rFZ4Hy3/eW6uEtq6bDclGUKn85oHH?=
 =?us-ascii?Q?XumbBOogmMi+LCI4LvK7dG6YLen6iXzf1BRO19p1UC1wkMh1UDvqA5Hky/Q5?=
 =?us-ascii?Q?3qQvgFC1MolCYc4mpEPeAi7XSg+5beNUI8aR4PGpBqb07pA8YzzA9y/ROjis?=
 =?us-ascii?Q?3bx9YltyoMcQ7O8IJpSCnP6DcXzjV91oKG+wwRMd5fvMwQJ8HAQelcEtlAtp?=
 =?us-ascii?Q?w2zH495WS5RyLvhFrwV50500Ln0SIGs2OtDtFL59G16ewH9FcpOjWdwXwdro?=
 =?us-ascii?Q?e1QDEk+0d9k1YPLMZCRnX1LsV9yaRZ5I8aYDQmHP2O8ml5AohJlIkQ+cEpzk?=
 =?us-ascii?Q?pKKl4Tf388W1myjuv+Zvpyc4f8z7L65b8A3hRFEwvrlP/cDaSoeJT55/P/bo?=
 =?us-ascii?Q?Ig=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c0eb621f-f781-4d86-981f-08dc5dd17907
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 04:55:44.0674
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7j3e3PFte61Z6+eSdXolQ6yDBx1xoSHyOD5ZHhUU0eDOdYxUOpYR5tGJvnAqzAMJLn8wIxKVoKsnHGtxld3E5QQmIEAVHILt/sQoYUpPOiE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6436
X-OriginatorOrg: intel.com

Tom Lendacky wrote:
> With the introduction of an SVSM, Linux will be running at a non-zero
> VMPL. Any request for an attestation report at a higher priviledge VMPL
> than what Linux is currently running will result in an error. Allow for
> the privlevel_floor attribute to be updated dynamically so that the
> attribute may be set dynamically.
> 
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
>  drivers/virt/coco/sev-guest/sev-guest.c | 5 ++++-
>  include/linux/tsm.h                     | 2 +-
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/sev-guest/sev-guest.c
> index 1ff897913bf4..bba6531cb606 100644
> --- a/drivers/virt/coco/sev-guest/sev-guest.c
> +++ b/drivers/virt/coco/sev-guest/sev-guest.c
> @@ -885,7 +885,7 @@ static int sev_report_new(struct tsm_report *report, void *data)
>  	return 0;
>  }
>  
> -static const struct tsm_ops sev_tsm_ops = {
> +static struct tsm_ops sev_tsm_ops = {
>  	.name = KBUILD_MODNAME,
>  	.report_new = sev_report_new,
>  };
> @@ -972,6 +972,9 @@ static int __init sev_guest_probe(struct platform_device *pdev)
>  	snp_dev->input.resp_gpa = __pa(snp_dev->response);
>  	snp_dev->input.data_gpa = __pa(snp_dev->certs_data);
>  
> +	/* Set the privlevel_floor attribute based on the current VMPL */
> +	sev_tsm_ops.privlevel_floor = snp_get_vmpl();

Why is this not vmpck_id?