Received-SPF: pass (google.com: domain of linux-kernel+bounces-146267-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240414045124.3098560-1-dmitrii.bundin.a@gmail.com> <Zh0ZhEU1xhndl2k8@krava>
In-Reply-To: <Zh0ZhEU1xhndl2k8@krava>
From: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
Date: Tue, 16 Apr 2024 08:27:21 +0300
Message-ID: <CANXV_Xwmf-VH5EfNdv=wcv8J=2W5L5RtOs8n-Uh5jm5a1yiMKw@mail.gmail.com>
Subject: Re: [PATCH] bpf: btf: include linux/types.h for u32
To: Jiri Olsa <olsajiri@gmail.com>
Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, haoluo@google.com, 
	sdf@google.com, kpsingh@kernel.org, john.fastabend@gmail.com, 
	yonghong.song@linux.dev, song@kernel.org, eddyz87@gmail.com, 
	andrii@kernel.org, daniel@iogearbox.net, ast@kernel.org, martin.lau@linux.dev, 
	khazhy@chromium.org, vmalik@redhat.com, ndesaulniers@google.com, 
	ncopa@alpinelinux.org, dxu@dxuuu.xyz
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 15, 2024 at 3:11=E2=80=AFPM Jiri Olsa <olsajiri@gmail.com> wrot=
e:
> lgtm, did it actualy cause problem anywhere?
>
> there's also tools/include/linux/btf_ids.h

It caused the problems exactly in the file
tools/include/linux/btf_ids.h and was reported in
https://bugzilla.kernel.org/show_bug.cgi?id=3D218647
The patch including linux/types.h in tools/include/linux/btf_ids.h is
already there https://lore.kernel.org/all/20240328110103.28734-1-ncopa@alpi=
nelinux.org/
I also faced the same compile-error of the form

    error: unknown type name 'u32'
                              u32 cnt;
                              ^~~
when compiling the bpf tool with glibc 2.28.

I think it might be reasonable to add the inclusion in
include/linux/btf_ids.h as well to prevent build problems like this.