Received-SPF: pass (google.com: domain of linux-kernel+bounces-146361-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Peng Fan <peng.fan@nxp.com>
To: Peng Fan <peng.fan@nxp.com>, Rob Herring <robh@kernel.org>, "Peng Fan
 (OSS)" <peng.fan@oss.nxp.com>
CC: Linus Walleij <linus.walleij@linaro.org>, Krzysztof Kozlowski
	<krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, Shawn Guo
	<shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix
 Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>,
	Sudeep Holla <sudeep.holla@arm.com>, Cristian Marussi
	<cristian.marussi@arm.com>, "linux-gpio@vger.kernel.org"
	<linux-gpio@vger.kernel.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/3] dt-bindings: firmware: arm,scmi: support i.MX95 SCMI
 Pinctrl
Thread-Topic: [PATCH 2/3] dt-bindings: firmware: arm,scmi: support i.MX95 SCMI
 Pinctrl
Thread-Index: AQHajG9fogbrSJSEIkC/zlbnV4Z6dbFp93iAgABErECAADwqIA==
Date: Tue, 16 Apr 2024 06:41:25 +0000
Message-ID:
 <DU0PR04MB941794994D2D0A2CE5D0C33B88082@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240412-pinctrl-scmi-oem-v1-v1-0-704f242544c1@nxp.com>
 <20240412-pinctrl-scmi-oem-v1-v1-2-704f242544c1@nxp.com>
 <20240415225637.GA234203-robh@kernel.org>
 <DU0PR04MB941714AFCDC74997BFF34DFD88082@DU0PR04MB9417.eurprd04.prod.outlook.com>
In-Reply-To:
 <DU0PR04MB941714AFCDC74997BFF34DFD88082@DU0PR04MB9417.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?wa8ehcEj+Vk87xjH63szBYzVTv+R2Vn5FqkSrvfvxTEQXWTSN0vYEGCZWLhs?=
 =?us-ascii?Q?WuTGyrVkP9HWAC3aR8jYH+rUp/vXRW5tGQMUzz0+dnjn7DpinAN7Bep50Vp1?=
 =?us-ascii?Q?NoxRIRV0jc5/hGTaFxbSlCkO+1mt/slE9NVGLzZzE4hhkK/6THaPXSI0Zfl2?=
 =?us-ascii?Q?+kN9w8VVhl2+Z6xyIvUuHk0jZ1Nygk9hxGsA1GUxZMCOoydOn6E6wTHN7lAT?=
 =?us-ascii?Q?IJlZibX1qVD6u8BV3phqe5v+PGFHYteZHCu1tIPjOIYAwrhXS/L4gbkxoae4?=
 =?us-ascii?Q?WFeSAOcrbfInzFxSIvRbckp0KoKXwF4nQ8vttZEktMj1xjz1OqN6irrYmhAv?=
 =?us-ascii?Q?Y011hOsyBoksCxYWs7P0ARM0xLUrZo1kDnQ+y62JCT9iy1OBZTAgKSrteMwt?=
 =?us-ascii?Q?HE3bjIdQ8ZPVN3wur/aqmvHqzQZfo2qaxQAXBTrlIHB0YuTebVFL85Pg2n+S?=
 =?us-ascii?Q?706xuSX5LH125agEht/XQe+1jre3VGDntxp51jeHvqjGJUyl2YYpdU1RTmeb?=
 =?us-ascii?Q?1UtbdikaT1DoVNIQJqb/Dng/OxucYoPa5UyvHb6UKnJH2f4ZJQ2TfaZ1X3Uz?=
 =?us-ascii?Q?dHkn/hIk5LEQ6HdWdrSRK0vLrmoLmGBXk1Sg8yiMeNe1kZAgF06TBDQsxVez?=
 =?us-ascii?Q?XDYWbghFabFGptY27jvXZ5vzLuarkUDvZ+Vi8doApxbKnMp//3RP77/yaJwj?=
 =?us-ascii?Q?R7TaicgGAeFe6yMu6YcfWyzM26XFFKzmFLPu//jISOPkyoLDpyhujZvtz0d2?=
 =?us-ascii?Q?9hRD5ZDQ0/Dj7g2F9Oe8MDqCStFVKticDljvdNgEMdtdxWh1pSsj/yOuGF3K?=
 =?us-ascii?Q?tUZvYnaePZwJK1ZLEEv1NMj7L7vn2l3QF7IsvbQVpBf8ZPSS6MJylTucUjgB?=
 =?us-ascii?Q?8yXjWMHvcTikrgceSrZ1yk0MeYeZtSGEnJkuZMtjUV59Kv/0Hi9fFAyUyry2?=
 =?us-ascii?Q?39hOjDmpONfM4/p4KuBirAaM7m3zlCQwsoMni3rrzkGSyU+BO3mV0SQsO47C?=
 =?us-ascii?Q?wdhcC5rRDP+N1ZKLw8HnqfovTj0coAeIZmQBPRh353PVKCbY2/CY8W8CGRdM?=
 =?us-ascii?Q?rP1Svs+fk94vy0CxQbIqLcvDYt/7CewQgdUMuAjMKdph8baMTgDl9GgRUGg3?=
 =?us-ascii?Q?HE4xBPJ19VnKctmD3Q+2wEmy9+4Ue8hC4jMkoriGfcxqL9U+XMXvm3CT68sX?=
 =?us-ascii?Q?EfbDtiqfbI45WD2fr8abTyjI6EMKGAE7tirr0TATi69fKVcWkKYZg32zh+De?=
 =?us-ascii?Q?fKqxj2uFQ/a3+qrePts7PwGuw0z4fwhxq0IjAOWBqhoXJxfUfQNsgh0tJUPx?=
 =?us-ascii?Q?waOSDGSwUKl917YWLCHF0Kw1pI1jWh/7+QETqGZLvoBVbRT1P4gwAX8M98dw?=
 =?us-ascii?Q?LQNaxvoG+QKWgyj6oN9r/Y4L0fs3iaAe5vtxRA5pLUOkH3Q+wjalXlA7udr3?=
 =?us-ascii?Q?XSIjE+g0lcVeK/i6Hj3v6Q2o50xgYC6F0KqYgnykHppHaGUWP2oaJoE7za1Z?=
 =?us-ascii?Q?ECckeHlo2ELHXlzOXpk0GrnQoTMBNhXW78dBWpPXYHKaSm2IKkJk/kO59xDf?=
 =?us-ascii?Q?uBLj/2h2DK3x+9BDt24=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32490c32-5fc2-48eb-c339-08dc5de03cbb
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2024 06:41:25.2568
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zj6zJzFdy2LGoraMfzOyI5Qjb87gfSqCbhFxw8BYLAsfrj2sbtB5YpELVYrA24yJWI/D5gI/unR84ZUC3kGUeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB9969

> Subject: RE: [PATCH 2/3] dt-bindings: firmware: arm,scmi: support i.MX95
> SCMI Pinctrl
>=20
> Hi Rob,
>=20
> > Subject: Re: [PATCH 2/3] dt-bindings: firmware: arm,scmi: support
> > i.MX95 SCMI Pinctrl
> >
> > On Fri, Apr 12, 2024 at 08:29:26AM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > i.MX95 SCMI Pinctrl uses OEM specific units, so add '$ref' to
> > > '/schemas/pinctrl/nxp,imx95-pinctrl.yaml' and an example.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >  Documentation/devicetree/bindings/firmware/arm,scmi.yaml | 8
> > > +++++---
> > >  1 file changed, 5 insertions(+), 3 deletions(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > index e9d3f043c4ed..ebc6c083b538 100644
> > > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > @@ -249,9 +249,11 @@ properties:
> > >
> > >    protocol@19:
> > >      type: object
> > > -    allOf:
> > > -      - $ref: '#/$defs/protocol-node'
> > > -      - $ref: /schemas/pinctrl/pinctrl.yaml
> >
> > I don't think anything from here was actually used...
>=20

After some check, I work out the following:
diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Doc=
umentation/devicetree/bindings/firmware/arm,scmi.yaml
index e9d3f043c4ed..26b7395c4326 100644
--- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
+++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
@@ -262,9 +262,12 @@ properties:
     patternProperties:
       '-pins$':
         type: object
-        allOf:
-          - $ref: /schemas/pinctrl/pincfg-node.yaml#
-          - $ref: /schemas/pinctrl/pinmux-node.yaml#
+        anyOf:
+          - $ref: /schemas/pinctrl/nxp,imx95-pinctrl.yaml
+          - allOf:
+              - $ref: /schemas/pinctrl/pincfg-node.yaml#
+              - $ref: /schemas/pinctrl/pinmux-node.yaml#
+
         unevaluatedProperties: false
=20
         description:

The nxp,imx95-pinctrl.yaml:
+patternProperties:
+  '[a-f0-9]+$':
+    type: object
+    unevaluatedProperties: false
+
+    properties:
+      pins:
+        $ref: /schemas/types.yaml#/definitions/string
+        description: name of the pin
+
+      nxp,func-id:
+        $ref: /schemas/types.yaml#/definitions/uint32
+        description: Indicates the PAD connections which function module
+
+      nxp,pin-conf:
+        $ref: /schemas/types.yaml#/definitions/uint32
+        description: The PAD configuration
+
+      nxp,daisy-id:
+        $ref: /schemas/types.yaml#/definitions/uint32
+        description: The select input register ID
+
+      nxp,daisy-conf:
+        $ref: /schemas/types.yaml#/definitions/uint32
+        description: The select input register value
+
+additionalProperties: true


The node will as below:
           scmi_pinctrl: protocol@19 {                                     =
                       =20
                reg =3D <0x19>;                                            =
                          =20
                                                                           =
                        =20
                sd-pins {                                                  =
                        =20
                  sd1cmd {                                                 =
                        =20
                    pins =3D "sd1cmd";                                     =
                          =20
                    nxp,func-id =3D <0>;                                   =
                          =20
                    nxp,pin-conf =3D <0x138e>;                             =
                          =20
                  };                                                       =
                        =20
                  sd1data0 {                                               =
                        =20
                    pins =3D "sd1data0";                                   =
                          =20
                    nxp,func-id =3D <0>;                                   =
                          =20
                    nxp,pin-conf =3D <0x138e>;                             =
                          =20
                  };                                                       =
                        =20
                };

I will use the upper in v2.

Thanks,
Peng.
> You mean this not used?
> allOf:
>   - $ref: '#/$defs/protocol-node'
>   - $ref: /schemas/pinctrl/pinctrl.yaml
>=20
> Or below?
> >
> >
> > > +    anyOf:
> > > +      - $ref: /schemas/pinctrl/nxp,imx95-pinctrl.yaml
> > > +      - allOf:
> > > +          - $ref: '#/$defs/protocol-node'
> >
> > This must always apply and should not be under the anyOf.
>=20
> I just try in arm,scmi.yaml:
>   protocol@19:
>     type: object
>     allOf:
>       - $ref: '#/$defs/protocol-node'
>       - anyOf:
>           - $ref: /schemas/pinctrl/nxp,imx95-pinctrl.yaml
>           - $ref: /schemas/pinctrl/pinctrl.yaml
>=20
>     unevaluatedProperties: false
>=20
> And in nxp,imx95-pinctrl.yaml:
> patternProperties:
>   'grp$':
>     type: object
>     additionalProperties: false
>=20
>     patternProperties:
>       '[a-f0-9]+$':
>         type: object
>         unevaluatedProperties: false
>=20
> But the following example always reports:
>                 pinctrl_usdhc1: usdhc1grp {
>                     sd1-pin0 {
>                         pins =3D "sd1cmd";
>                         nxp,func-id =3D <0>;
>                         nxp,pin-conf =3D <0x138e>;
>                     };
>                 };
>=20
> arm,scmi.example.dtb: scmi: protocol@19: Unevaluated properties are not
> allowed ('usdhc1grp' was unexpected)
>=20
> Do you have any suggestions on how to write the yaml correct?
>=20
> Thanks,
> Peng.
>=20
> >
> > > +          - $ref: /schemas/pinctrl/pinctrl.yaml
> > >
> > >      unevaluatedProperties: false
> > >
> > >
> > > --
> > > 2.37.1
> > >