Received-SPF: pass (google.com: domain of linux-kernel+bounces-146404-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 16 Apr 2024 07:04:47 +0000 (UTC)
From: Prasad Pandit <pjp@fedoraproject.org>
Reply-To: Prasad Pandit <pj.pandit@yahoo.in>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Joe Perches <joe@perches.com>, Dwaipayan Ray <dwaipayanray1@gmail.com>, 
	Lukas Bulwahn <lukas.bulwahn@gmail.com>, 
	Dan Carpenter <dan.carpenter@linaro.org>, 
	Greg KH <gregkh@linuxfoundation.org>, 
	Andy Whitcroft <apw@canonical.com>
Message-ID: <1568855168.5949322.1713251087824@mail.yahoo.com>
In-Reply-To: <20240330033858.3272184-1-ppandit@redhat.com>
References: <20240330033858.3272184-1-ppandit@redhat.com>
Subject: Re: [PATCH] checkpatch: error if file terminates without a new-line
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

[+linux-kernel]

On Saturday, 30 March, 2024 at 09:09:12 am IST, Prasad Pandit <ppandit@redh=
at.com> wrote:=C2=A0
From: Prasad Pandit <pjp@fedoraproject.org>

Add check to flag an error if a patch terminates a file
without a new line (\n) character.

Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Prasad Pandit <pjp@fedoraproject.org>
---
scripts/checkpatch.pl | 7 +++++++
1 file changed, 7 insertions(+)

-> https://lore.kernel.org/all/CAE8KmOxG=3D3sWKpeB5fdWTK-SCipS=3DJyDE-_DNgY=
--DtoSQZ0Qw@mail.gmail.com/T/#t

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9c4c4a61bc83..df34c0709410 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2795,6 +2795,13 @@ sub process {
=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 $is_patch =3D 1;
=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 }

+# check if patch terminates file without a new line (\n)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 if ($line =3D~ /^\\ No newline at end of file$=
/
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 and $rawlines[$linenr - 2] =3D~ =
/^\+.*$/) {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ERROR("NOEOL_FILE",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "patch term=
inates file without a new line (\\n).");
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 }
+
#extract the line range in the file after the patch is applied
=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 if (!$in_commit_log &&
=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0 =C2=A0 $line =3D~ /^\@\@ -\d+(=
?:,\d+)? \+(\d+)(,(\d+))? \@\@(.*)/) {
--=20
2.44.0