Received-SPF: pass (google.com: domain of linux-kernel+bounces-146420-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Jiri Olsa <olsajiri@gmail.com>
Date: Tue, 16 Apr 2024 09:23:26 +0200
To: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
Cc: olsajiri@gmail.com, andrii@kernel.org, ast@kernel.org,
	bpf@vger.kernel.org, daniel@iogearbox.net, dxu@dxuuu.xyz,
	eddyz87@gmail.com, haoluo@google.com, john.fastabend@gmail.com,
	khazhy@chromium.org, kpsingh@kernel.org,
	linux-kernel@vger.kernel.org, martin.lau@linux.dev,
	ncopa@alpinelinux.org, ndesaulniers@google.com, sdf@google.com,
	song@kernel.org, vmalik@redhat.com, yonghong.song@linux.dev
Subject: Re: [PATCH bpf-next v2] bpf: btf: include linux/types.h for u32
Message-ID: <Zh4nbvndaho6kCRP@krava>
References: <Zh0ZhEU1xhndl2k8@krava>
 <20240416051527.3109380-1-dmitrii.bundin.a@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240416051527.3109380-1-dmitrii.bundin.a@gmail.com>

On Tue, Apr 16, 2024 at 08:15:27AM +0300, Dmitrii Bundin wrote:
> Inclusion of the header linux/btf_ids.h relies on indirect inclusion of
> the header linux/types.h. Including it directly on the top level helps
> to avoid potential problems if linux/types.h hasn't been included
> before.
> 
> Signed-off-by: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>

Acked-by: Jiri Olsa <jolsa@kernel.org>

jirka

> ---
> 
> Changes in v2: Add bpf-next to the subject
> 
>  include/linux/btf_ids.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/btf_ids.h b/include/linux/btf_ids.h
> index e24aabfe8ecc..c0e3e1426a82 100644
> --- a/include/linux/btf_ids.h
> +++ b/include/linux/btf_ids.h
> @@ -3,6 +3,8 @@
>  #ifndef _LINUX_BTF_IDS_H
>  #define _LINUX_BTF_IDS_H
>  
> +#include <linux/types.h> /* for u32 */
> +
>  struct btf_id_set {
>  	u32 cnt;
>  	u32 ids[];
> -- 
> 2.34.1
>