Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp1894186lqp; Tue, 16 Apr 2024 00:24:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWB5hZGcUIbS3rTIzfrQ8b4KuqpQy4UZrXHrVrGDih4MA064YvK+bRoIN1nks32IeZC27xYgEISXZjgYkp3jCwCQfIXzt0dgweT1m2Rkg== X-Google-Smtp-Source: AGHT+IGecrNSGEvQtCWxYEAotriYmUP6XDgn+C6WUoODqg8JYjHw0y7OPh55kT8P3PcHyypGqfyK X-Received: by 2002:a05:6808:9ad:b0:3c5:e671:a441 with SMTP id e13-20020a05680809ad00b003c5e671a441mr12410266oig.18.1713252268686; Tue, 16 Apr 2024 00:24:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713252268; cv=pass; d=google.com; s=arc-20160816; b=yDR6Nu90mBJHRyp770oCcHSheFIQhtyfUYOXvU4SMm9sW9M3R95GQ42zXymL/eugxX C0ER+8lImH2qB5N8/4mQMYzSt+UIpxp3TXi3f2IWuuCp872kXo41xQbdNVHW3/aJ0okR Rrp/eW8N8RXxrK4AaWZAHfVyG+DjeaUSD5gC8m73L05JAC4cv6drxQUz+SiQLzPmE4ho PdSsCeYGZtXP6oY/gtkrULA5QXphMtfJp25KnjdJ3LmL+yX9lJx+YkZUohHCLVRtVS2V 6t48if8Wo7N7UU4iXT4CNNzAPgL8e75mqm5fAlI7NeIsnoSnrG/mmdxmucWJwz/xaBNY pCyA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=nebwr34inJA/ZYYAC9fSM7aQwvQVIq10txEmBjSfFYU=; fh=X1/oBJvTGJUQ0YtRp03u+3tPfRw/dXXALWynfOSlfQQ=; b=Qf5Ks9oTJNrtrKII6LrzXtWc5XHhnWEQPxmSHavoS0ydBjyqEnyV2qtn/oOAxdjSn4 bU+CD+Uq7OsPPsUlBxZDY4jVR/0Eeqh59t6NADrOe/5nlAaDnPypROf5ZrS/KexD1pCl UhEEOwPL59fvRUvCOVIsoQI+aredd/IqaypnsMnphDiVM+8Ji6weUShDeMFJ7437xpb4 /rlu+4utARD11CZeQOnEEAKVrSr5MiubrGh9w8dxZnj5RyK99jmAoCkm9+a8AP3EB/zN goaKgNjmEl+nY8MdRji5drg6lwdFh0xQkSRxHMNPWueNEN7elgo9HsDpbYjncPVSgCjt A7uA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FoxT+UxJ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-146421-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-146421-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 1-20020a631041000000b005dc7e74bd95si9031542pgq.564.2024.04.16.00.24.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 00:24:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-146421-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FoxT+UxJ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-146421-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-146421-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 586DB283A76 for ; Tue, 16 Apr 2024 07:24:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 832901598F5; Tue, 16 Apr 2024 07:23:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FoxT+UxJ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB044158D98 for ; Tue, 16 Apr 2024 07:23:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713252213; cv=none; b=VTMSB/DCC1KIBxkoUiL+FhIZ0HS/WO9qBsuXOsqafrRZ3JzfSP/6uGnkt0vPzEfEUSj1L/F9WSBEeZUwngBhcridu1w14jhkKYEAYjzy1jS9220Z0hNYo8yWtFOCw08NaAAqthrTo+dqzvBrZyRp7dMS3qVqbGwbzpmaIlywz4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713252213; c=relaxed/simple; bh=+rHA/TjA7B8eR6kxVZ+90vp2Y9xGqpF27dl9oDGOTCU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lQwtEPhHcOrJTIOvLmt0jVg094H0YLkMQlOyXA0fvk4r9lNZrrmRYo6wclaDcC92Bosphn4CGacPoKLBPEeNImzhy5x4/t/fPOuRX1Yvbj0lRyi5/wxkwsi9elLB94EcGfPFgt3MVPDI2DewitACVKvm0+j36JW6wFvzYo9KRE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FoxT+UxJ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCED4C4AF07; Tue, 16 Apr 2024 07:23:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713252213; bh=+rHA/TjA7B8eR6kxVZ+90vp2Y9xGqpF27dl9oDGOTCU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FoxT+UxJEf+VaWlxWxF+lc6GlEDeXmwoSWwYq9YqLCgs+z6+8IJV+I34mp1l1k5QC I8Qf1H7YCeViM7zxMI3Rk4rsntyhRzjYyKLkmqqjYqlFYz5RBYUnXfaGZNE1Poz6Sk W/V5d+tyfya1T/tozU40xqeBgLUFOrnc8Z4OOBXiLcVFLBFuxmTRzm60gi9Rem3L9x FXJr81HS8fFpRn8C3RvBhTnlV/AIvMdize9pZQpdu0r604uTJyo6jq9JBYWM2ru8KZ 8uB2OM8Y6m0GpH2diij3Xrx5aMZGateWpOZheqLPEx7ldeMX0uiiNC/7IqnARph3UV aXbjHwY1JKhqg== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Subject: [PATCH 2/4] f2fs: convert f2fs_read_single_page() to use folio Date: Tue, 16 Apr 2024 15:23:16 +0800 Message-Id: <20240416072318.6486-2-chao@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240416072318.6486-1-chao@kernel.org> References: <20240416072318.6486-1-chao@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert f2fs_read_single_page() to use folio and related functionality. Signed-off-by: Chao Yu --- fs/f2fs/data.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 14dcd621acaa..c35107657c97 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -2092,7 +2092,7 @@ static inline loff_t f2fs_readpage_limit(struct inode *inode) return i_size_read(inode); } -static int f2fs_read_single_page(struct inode *inode, struct page *page, +static int f2fs_read_single_page(struct inode *inode, struct folio *folio, unsigned nr_pages, struct f2fs_map_blocks *map, struct bio **bio_ret, @@ -2105,9 +2105,10 @@ static int f2fs_read_single_page(struct inode *inode, struct page *page, sector_t last_block; sector_t last_block_in_file; sector_t block_nr; + pgoff_t index = folio_index(folio); int ret = 0; - block_in_file = (sector_t)page_index(page); + block_in_file = (sector_t)index; last_block = block_in_file + nr_pages; last_block_in_file = bytes_to_blks(inode, f2fs_readpage_limit(inode) + blocksize - 1); @@ -2138,7 +2139,7 @@ static int f2fs_read_single_page(struct inode *inode, struct page *page, got_it: if ((map->m_flags & F2FS_MAP_MAPPED)) { block_nr = map->m_pblk + block_in_file - map->m_lblk; - SetPageMappedToDisk(page); + folio_set_mappedtodisk(folio); if (!f2fs_is_valid_blkaddr(F2FS_I_SB(inode), block_nr, DATA_GENERIC_ENHANCE_READ)) { @@ -2147,15 +2148,15 @@ static int f2fs_read_single_page(struct inode *inode, struct page *page, } } else { zero_out: - zero_user_segment(page, 0, PAGE_SIZE); - if (f2fs_need_verity(inode, page->index) && - !fsverity_verify_page(page)) { + folio_zero_segment(folio, 0, folio_size(folio)); + if (f2fs_need_verity(inode, index) && + !fsverity_verify_folio(folio)) { ret = -EIO; goto out; } - if (!PageUptodate(page)) - SetPageUptodate(page); - unlock_page(page); + if (!folio_test_uptodate(folio)) + folio_mark_uptodate(folio); + folio_unlock(folio); goto out; } @@ -2165,14 +2166,14 @@ static int f2fs_read_single_page(struct inode *inode, struct page *page, */ if (bio && (!page_is_mergeable(F2FS_I_SB(inode), bio, *last_block_in_bio, block_nr) || - !f2fs_crypt_mergeable_bio(bio, inode, page->index, NULL))) { + !f2fs_crypt_mergeable_bio(bio, inode, index, NULL))) { submit_and_realloc: f2fs_submit_read_bio(F2FS_I_SB(inode), bio, DATA); bio = NULL; } if (bio == NULL) { bio = f2fs_grab_read_bio(inode, block_nr, nr_pages, - is_readahead ? REQ_RAHEAD : 0, page->index, + is_readahead ? REQ_RAHEAD : 0, index, false); if (IS_ERR(bio)) { ret = PTR_ERR(bio); @@ -2187,7 +2188,7 @@ static int f2fs_read_single_page(struct inode *inode, struct page *page, */ f2fs_wait_on_block_writeback(inode, block_nr); - if (bio_add_page(bio, page, blocksize, 0) < blocksize) + if (!bio_add_folio(bio, folio, blocksize, 0)) goto submit_and_realloc; inc_page_count(F2FS_I_SB(inode), F2FS_RD_DATA); @@ -2453,7 +2454,7 @@ static int f2fs_mpage_readpages(struct inode *inode, read_single_page: #endif - ret = f2fs_read_single_page(inode, &folio->page, max_nr_pages, &map, + ret = f2fs_read_single_page(inode, folio, max_nr_pages, &map, &bio, &last_block_in_bio, rac); if (ret) { #ifdef CONFIG_F2FS_FS_COMPRESSION -- 2.40.1