Received-SPF: pass (google.com: domain of linux-kernel+bounces-146424-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <b4a721c2-567d-4ab3-8a85-963e3f323e61@intel.com>
Date: Tue, 16 Apr 2024 15:27:27 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH 3/6] PCI/AER: Enable RCEC to report internal error for
 CXL root port
To: Terry Bowman <Terry.Bowman@amd.com>, <dan.j.williams@intel.com>,
	<rrichter@amd.com>
CC: <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240313083602.239201-1-ming4.li@intel.com>
 <20240313083602.239201-4-ming4.li@intel.com>
 <7172ec2f-7cba-460b-a6c6-9fff45ba938b@amd.com>
Content-Language: en-US
From: "Li, Ming" <ming4.li@intel.com>
Organization: Intel
In-Reply-To: <7172ec2f-7cba-460b-a6c6-9fff45ba938b@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVB2dFRuTHdrMS9NNUN4dmYzeFR3cS9LRWRDVDdjYW9FNVkxbkZZY2NUV3h0?=
 =?utf-8?B?QXBJYXRpMXkrT0ppZm1Kb3dPc1plV1JJQnpqdGgzN3hlM1hiRk4xNGxkSWhZ?=
 =?utf-8?B?bHd1VHpBUTVPWEZ3Sm11Nkh0ZG9hY05KeHlxc3lpQkpPWTdBdVIwUDF6NU5J?=
 =?utf-8?B?bW1sQmZUTG9DUWxFQzU5N1Q4VTZySlY3UmdJKzd1aEVqekZmUE1LcHhlMEpn?=
 =?utf-8?B?K0dpQ2hZeGw1andIVHlOQ2U0RFZaaGRtbG1xSWhORkxuZGFNRzlCNjVCTnho?=
 =?utf-8?B?TEozZ1RBM1lidGY0WjdkMTNGclhoU0g1dzJMWHVaQVhZdklkZExZM2VKMFFF?=
 =?utf-8?B?Q09yTXRyZDh3aU1sUnlIYmFFeVpLY0xWWGx0RHNmMjdXc3JLcWxhNk1Ya2Yr?=
 =?utf-8?B?TlpSdjc3bjZlSWdLQVNMTm5nNjdRdnk1VThhWUJoZmU1RC9QZDZMOGIvUXJo?=
 =?utf-8?B?ZjBLOU1vUlZaaE0yZ2s5Y2lzbkN6d3J1WDVReHN1cXdOL3FDS0xtUUNZaS81?=
 =?utf-8?B?Zm83aEx0c0hyYXQ0SnAwUXV4K3h0QlUxbG4rc1U0MkNKS3hJZFdZWGNiZjR0?=
 =?utf-8?B?TUJXL08yVmxGR2p6a0JEckllOWJ1clNMT1hvYVo4MXpqNmlMaEd3c3BOSkVq?=
 =?utf-8?B?UTRNT2lxQTNrUVUxY1k2ZFpWV2M0WjdFOWM2c2NSdk9mV3VDd084NzRHK2lY?=
 =?utf-8?B?a1VMRE1JcUZEdW5hU1JhS0VLYW5IWFpkYVF2MWpnK0VRMDNSRm9JRlNtL1Jw?=
 =?utf-8?B?U2lDYndOK21JMEJ5eXdDUkpOakZHaWtvUTVzbjduejFlaE9YQm0yeDFySWcy?=
 =?utf-8?B?S0pWOXJ3SXZxYk95SS9RcUcyVkYwRGxNYlF3cjdJVHZPeDJ3YTE4YVRwTEdX?=
 =?utf-8?B?V1F1Y2VVS0E5dC93Qm4yZE5hSzhOZkJhTzgyVlNQWTF4dGRYZ0I1MmJ1TGxr?=
 =?utf-8?B?NFVvTHdFNy8xbGJtaFJDaDRVd2s2Yi9qQ0xhUVpRQk4zZnJMNVRzZkUyYVhZ?=
 =?utf-8?B?V1dJdnFtWkU5UzZ3dUlwc1hFbElMdS91WTlISXN5V08rUGFSbVI4WTM2aWcy?=
 =?utf-8?B?U01TeE53UmNZNzNuR3lVTXAyU1BlWFI1QldId05DRnQ1eXpzL2ZkSlFNeHRp?=
 =?utf-8?B?MWRGalJWSU5xd2FuRkROY1VZQWtLOWNSeUJmNzdLQXU1RXpVajd4aGFLQkVn?=
 =?utf-8?B?RjdGYkhPWmYvUG5EWUc4TnphVTF3WkhXdUIrdFJ3Z2tMSWJqYVR6aUFlNDJk?=
 =?utf-8?B?WmRjNlVuaEE2Y1ZDQlk2bWg0VG9KMExneDN0L0NiWDd6MFZhVXlyekRla3By?=
 =?utf-8?B?UVBGbzdLUE1tV1c0c3RkR2VTRk5wREMyR08xWWtYRm53RTFxS0lPRXM0WjFm?=
 =?utf-8?B?Y3FmOVhzUWp6cFA3VS9hakxxeHlwQ2ZDMytNb2NYMmhkZzVCRTJwMUpuRkw0?=
 =?utf-8?B?QlNnZStiQ2N5RHdqVm1OUG5tK0J2Q2ZUaGJHSjJJZm9ZdE42OUpITXRtc0Fq?=
 =?utf-8?B?elQrc08yL0hyL2dzcUhBNXNBS25kYjhnRkxOSi9SeFg1bDI3elF5SWRIUGp6?=
 =?utf-8?B?SmdqRWkwY3NSZTZzdGhOaWlXamxrejA3SzJPMXpRS0d4WUdEUUF5SFFJWk5O?=
 =?utf-8?B?eWduSDBRSWl5ak9vN0R2cnozTzkzeG1aR0xhZnRsam1tODFNZW1KdU5TeEdx?=
 =?utf-8?B?SDFLOUtHTVJFbzQ4aXlPMUlRTDdtRy9SMVlCZzlTcDhrb0VnOGNIODF4Zm5o?=
 =?utf-8?B?SjltSmlTSEpJVlcyNUtaMlA0YnowekZlQ0xmMHFUOHNyQjJuUkcvTzFneWdr?=
 =?utf-8?B?NDFPU2pTZXc0bXQ3UEs3YU1kbGlrRWRQNnpQMGoyV0QyMFF3S3Vtamh4QjBV?=
 =?utf-8?B?YWQzREdnMHNnMmIwaFBldEZhWk1GcXkrZEEwVzM0ZjFlQmlJS1B5dzdyVHpv?=
 =?utf-8?B?MFk1dVhrSnJwdmJ2eWsvSjZhYm5sN2w3VVcwcENzS00wMi9uQWtOc2MzZmha?=
 =?utf-8?B?V0NvTGJKR2wrR1BGbysydGtnMER1ZTNPYTR2TmNIUzYxdzk3eU9wRENjL0hS?=
 =?utf-8?B?TnU0RGJVYW9oVkRKQzBEYUN2UWRZeUQyd1YvRUxBcndaTjVWS01wT0pnZDVq?=
 =?utf-8?Q?xiqqOIgZYEws9FIapEGqcKFVA?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b79f351-9e5a-4934-60cd-08dc5de6b099
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB7200.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 07:27:36.9634
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HUIPJp+vX3O47Uwi9lR8A7sc2fC7BM94cVbv8jn1S6GwaouB1jlSziCxuP3M/tL46Ca/DpHyGpV5nwmraqYmVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7604
X-OriginatorOrg: intel.com

On 3/26/2024 3:42 AM, Terry Bowman wrote:
> Hi Li, 
> 
> I added comments below.
> 
> On 3/13/24 03:35, Li Ming wrote:
>> Per CXl r3.1 section 12.2.2, CXL.cachemem protocol erros detected by CXL
>> root port could be logged in RCEC AER Extended Capability as
>> PCI_ERR_UNC_INTN or PCI_ERR_COR_INTERNAL. Unmask these errors for that
>> case.
>>
>> Signed-off-by: Li Ming <ming4.li@intel.com>
>> ---
>>  drivers/pci/pcie/aer.c | 24 +++++++++++++++++-------
>>  1 file changed, 17 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
>> index 42a3bd35a3e1..364c74e47273 100644
>> --- a/drivers/pci/pcie/aer.c
>> +++ b/drivers/pci/pcie/aer.c
>> @@ -985,7 +985,7 @@ static bool cxl_error_is_native(struct pci_dev *dev)
>>  {
>>  	struct pci_host_bridge *host = pci_find_host_bridge(dev->bus);
>>  
>> -	return (pcie_ports_native || host->native_aer);
>> +	return (pcie_ports_native || host->native_aer) && host->is_cxl;
>>  }
>>  
>>  static bool is_internal_error(struct aer_err_info *info)
>> @@ -1041,8 +1041,13 @@ static int handles_cxl_error_iter(struct pci_dev *dev, void *data)
>>  {
>>  	bool *handles_cxl = data;
>>  
>> -	if (!*handles_cxl)
>> -		*handles_cxl = is_cxl_mem_dev(dev) && cxl_error_is_native(dev);
>> +	if (!*handles_cxl && cxl_error_is_native(dev)) {
>> +		if (pci_pcie_type(dev) == PCI_EXP_TYPE_RC_END &&
>> +		    dev->rcec && is_cxl_mem_dev(dev))
>> +			*handles_cxl = true;
>> +		if (pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT)
>> +			*handles_cxl = true;
>> +	}
> I understand a root port can be found under an RCEC. It's possible. But, does the downstream 
> root port forward AER to the upstream RCEC? My understanding is AER is handled and processed
> at the first root port/RCEC upstream from the device/RCH/USP/DSP.
>  
> Regards,
> Terry
> 

CXL r3.1 section 12.2.2 mentions this:

"If the CXL.cachemem protocol errors detected by a CXL root port are logged as
CIEs or UIEs in an RCEC’s AER Extended Capability, it is recommended that the System
Firmware populate an RDPAS record (see Section 9.18.1.5) to establish the association
between the RCEC and the root port."

I think it means that CXL root port is possible to forward its AER to RCEC.

Thanks
Ming

>>  
>>  	/* Non-zero terminates iteration */
>>  	return *handles_cxl;
>> @@ -1054,13 +1059,18 @@ static bool handles_cxl_errors(struct pci_dev *rcec)
>>  
>>  	if (pci_pcie_type(rcec) == PCI_EXP_TYPE_RC_EC &&
>>  	    pcie_aer_is_native(rcec))
>> -		pcie_walk_rcec(rcec, handles_cxl_error_iter, &handles_cxl);
>> +		pcie_walk_rcec_all(rcec, handles_cxl_error_iter, &handles_cxl);
>>  
>>  	return handles_cxl;
>>  }
>>  
>> -static void cxl_rch_enable_rcec(struct pci_dev *rcec)
>> +static void cxl_enable_rcec(struct pci_dev *rcec)
>>  {
>> +	/*
>> +	 * Enable RCEC's internal error report for two cases:
>> +	 * 1. RCiEP detected CXL.cachemem protocol errors
>> +	 * 2. CXL root port detected CXL.cachemem protocol errors.
>> +	 */
>>  	if (!handles_cxl_errors(rcec))
>>  		return;
>>  
>> @@ -1069,7 +1079,7 @@ static void cxl_rch_enable_rcec(struct pci_dev *rcec)
>>  }
>>  
>>  #else
>> -static inline void cxl_rch_enable_rcec(struct pci_dev *dev) { }
>> +static inline void cxl_enable_rcec(struct pci_dev *dev) { }
>>  static inline void cxl_rch_handle_error(struct pci_dev *dev,
>>  					struct aer_err_info *info) { }
>>  #endif
>> @@ -1494,7 +1504,7 @@ static int aer_probe(struct pcie_device *dev)
>>  		return status;
>>  	}
>>  
>> -	cxl_rch_enable_rcec(port);
>> +	cxl_enable_rcec(port);
>>  	aer_enable_rootport(rpc);
>>  	pci_info(port, "enabled with IRQ %d\n", dev->irq);
>>  	return 0;