Received-SPF: pass (google.com: domain of linux-kernel+bounces-146427-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Jiri Olsa <olsajiri@gmail.com>
Date: Tue, 16 Apr 2024 09:28:14 +0200
To: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
Cc: Jiri Olsa <olsajiri@gmail.com>, linux-kernel@vger.kernel.org,
	bpf@vger.kernel.org, haoluo@google.com, sdf@google.com,
	kpsingh@kernel.org, john.fastabend@gmail.com,
	yonghong.song@linux.dev, song@kernel.org, eddyz87@gmail.com,
	andrii@kernel.org, daniel@iogearbox.net, ast@kernel.org,
	martin.lau@linux.dev, khazhy@chromium.org, vmalik@redhat.com,
	ndesaulniers@google.com, ncopa@alpinelinux.org, dxu@dxuuu.xyz
Subject: Re: [PATCH] bpf: btf: include linux/types.h for u32
Message-ID: <Zh4ojsD-aV2vHROI@krava>
References: <20240414045124.3098560-1-dmitrii.bundin.a@gmail.com>
 <Zh0ZhEU1xhndl2k8@krava>
 <CANXV_Xwmf-VH5EfNdv=wcv8J=2W5L5RtOs8n-Uh5jm5a1yiMKw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CANXV_Xwmf-VH5EfNdv=wcv8J=2W5L5RtOs8n-Uh5jm5a1yiMKw@mail.gmail.com>

On Tue, Apr 16, 2024 at 08:27:21AM +0300, Dmitrii Bundin wrote:
> On Mon, Apr 15, 2024 at 3:11 PM Jiri Olsa <olsajiri@gmail.com> wrote:
> > lgtm, did it actualy cause problem anywhere?
> >
> > there's also tools/include/linux/btf_ids.h
> 
> It caused the problems exactly in the file
> tools/include/linux/btf_ids.h and was reported in
> https://bugzilla.kernel.org/show_bug.cgi?id=218647
> The patch including linux/types.h in tools/include/linux/btf_ids.h is
> already there https://lore.kernel.org/all/20240328110103.28734-1-ncopa@alpinelinux.org/
> I also faced the same compile-error of the form
> 
>     error: unknown type name 'u32'
>                               u32 cnt;
>                               ^~~
> when compiling the bpf tool with glibc 2.28.
> 
> I think it might be reasonable to add the inclusion in
> include/linux/btf_ids.h as well to prevent build problems like this.

ok, it's in the bpf/master already

jirka