Received-SPF: pass (google.com: domain of linux-kernel+bounces-146504-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <dc4563a4-949a-4e5e-a87b-2068a42eea85@ti.com>
Date: Tue, 16 Apr 2024 14:05:59 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v5 1/2] net: ethernet: ti: am65-cpts: Enable RX
 HW timestamp for PTP packets using CPTS FIFO
Content-Language: en-US
To: Paolo Abeni <pabeni@redhat.com>, Dan Carpenter <dan.carpenter@linaro.org>,
        Siddharth Vadapalli <s-vadapalli@ti.com>,
        Heiner Kallweit
	<hkallweit1@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
        Roger Quadros
	<rogerq@kernel.org>,
        Richard Cochran <richardcochran@gmail.com>,
        Jakub
 Kicinski <kuba@kernel.org>, Eric Dumazet <edumazet@google.com>,
        "David S.
 Miller" <davem@davemloft.net>
CC: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
References: <20240402114405.219100-1-c-vankar@ti.com>
 <20240402114405.219100-2-c-vankar@ti.com>
 <7c8be16329668d343a971e265e923543cba5e304.camel@redhat.com>
From: Chintan Vankar <c-vankar@ti.com>
In-Reply-To: <7c8be16329668d343a971e265e923543cba5e304.camel@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 04/04/24 16:10, Paolo Abeni wrote:
> On Tue, 2024-04-02 at 17:14 +0530, Chintan Vankar wrote:
>> Add a new function "am65_cpts_rx_timestamp()" which checks for PTP
>> packets from header and timestamps them.
>>
>> Add another function "am65_cpts_find_rx_ts()" which finds CPTS FIFO
>> Event to get the timestamp of received PTP packet.
>>
>> Signed-off-by: Chintan Vankar <c-vankar@ti.com>
>> ---
>>
>> Link to v4:
>> https://lore.kernel.org/r/20240327054234.1906957-1-c-vankar@ti.com/
>>
>> Changes from v4 to v5:
>> - Updated commit message.
>> - Replaced "list_del_entry()" and "list_add()" functions with equivalent
>>    "list_move()" function.
>>
>>   drivers/net/ethernet/ti/am65-cpts.c | 64 +++++++++++++++++++++++++++++
>>   drivers/net/ethernet/ti/am65-cpts.h |  6 +++
>>   2 files changed, 70 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/ti/am65-cpts.c b/drivers/net/ethernet/ti/am65-cpts.c
>> index c66618d91c28..bc0bfda1db12 100644
>> --- a/drivers/net/ethernet/ti/am65-cpts.c
>> +++ b/drivers/net/ethernet/ti/am65-cpts.c
>> @@ -906,6 +906,70 @@ static int am65_skb_get_mtype_seqid(struct sk_buff *skb, u32 *mtype_seqid)
>>   	return 1;
>>   }
>>   
>> +static u64 am65_cpts_find_rx_ts(struct am65_cpts *cpts, u32 skb_mtype_seqid)
>> +{
>> +	struct list_head *this, *next;
>> +	struct am65_cpts_event *event;
>> +	unsigned long flags;
>> +	u32 mtype_seqid;
>> +	u64 ns = 0;
>> +
>> +	am65_cpts_fifo_read(cpts);
>> +	spin_lock_irqsave(&cpts->lock, flags);
> 
> am65_cpts_fifo_read() acquires and releases this same lock. If moving
> to a lockless schema is too complex, you should at least try to acquire
> the lock only once. e.g. factor out a lockless  __am65_cpts_fifo_read
> variant and explicitly acquire the lock before invoke it.
> 

Moving to a lockless schema is complex for now, but I will make the
changes suggested by you in next version.

>> +	list_for_each_safe(this, next, &cpts->events) {
>> +		event = list_entry(this, struct am65_cpts_event, list);
>> +		if (time_after(jiffies, event->tmo)) {
>> +			list_del_init(&event->list);
>> +			list_add(&event->list, &cpts->pool);
> 
> Jakub suggested to use list_move() in v4, you should apply that here,
> too.
> 
Okay. I will update that too.

> Cheers,
> 
> Paolo
> 
>