Received-SPF: pass (google.com: domain of linux-kernel+bounces-146527-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 16 Apr 2024 11:59:43 +0300
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Prasad Pandit <pj.pandit@yahoo.in>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Joe Perches <joe@perches.com>,
	Dwaipayan Ray <dwaipayanray1@gmail.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] checkpatch: error if file terminates without a new-line
Message-ID: <edf23b1b-303a-46eb-b455-8c766c84ddf1@moroto.mountain>
References: <20240330033858.3272184-1-ppandit@redhat.com>
 <1568855168.5949322.1713251087824@mail.yahoo.com>
 <2024041627-overgrown-ripping-2348@gregkh>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2024041627-overgrown-ripping-2348@gregkh>

On Tue, Apr 16, 2024 at 10:48:27AM +0200, Greg KH wrote:
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 9c4c4a61bc83..df34c0709410 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -2795,6 +2795,13 @@ sub process {
> > ??? ??? ??? $is_patch = 1;
> > ??? ??? }
> > 
> > +# check if patch terminates file without a new line (\n)
> > +? ? ? ? if ($line =~ /^\\ No newline at end of file$/
> > +? ? ? ? ? ? and $rawlines[$linenr - 2] =~ /^\+.*$/) {
> > +? ? ? ? ? ? ERROR("NOEOL_FILE",
> > +? ? ? ? ? ? ? ? ? "patch terminates file without a new line (\\n).");
> > +? ? ? ? }
> 
> Why is this a problem?  files without a new line should not cause
> problems with a compiler, right?  You don't have a justification for why
> this change needs to be checked for anywhere.
> 

I gave him such a good reason too...  It breaks `cat file.c`.  Plus, it
looks weird in `git log -p` because it has a "No newline at the end of
file" comment.

regards,
dan carpenter

diff --git a/test.c b/test.c
new file mode 100644
index 000000000000..d808cac2d962
--- /dev/null
+++ b/test.c
@@ -0,0 +1,12 @@
+#include <stdio.h>
+#include <stdbool.h>
+#include "check_debug.h"
+
+void kfree(int *p);
+
+int *p;
+int main(void)
+{
+       kfree(p);
+       *p = 1;
+}
\ No newline at end of file

commit f4a997924122d0094675c897a220371f0a129d90