Received-SPF: pass (google.com: domain of linux-kernel+bounces-146559-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <eba70259-9b10-4bf7-ac4f-d7accf6b8891@smtp-relay.sendinblue.com> <CALNs47uct--R4CGEQEO1vXTwMuBiqLaO1tREL2T4pP-ebZC+=Q@mail.gmail.com>
In-Reply-To: <CALNs47uct--R4CGEQEO1vXTwMuBiqLaO1tREL2T4pP-ebZC+=Q@mail.gmail.com>
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date: Tue, 16 Apr 2024 11:34:38 +0200
Message-ID: <CANiq72msHmV7CXZVKehZLw4jtG9S_XsmX48OGNVp6sz32TMhtw@mail.gmail.com>
Subject: Re: [PATCH] rust: update `dbg!()` to format column number
To: Trevor Gross <tmgross@umich.edu>
Cc: dev@raxyte.com, ojeda@kernel.org, alex.gaynor@gmail.com, 
	wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, 
	bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, 
	aliceryhl@google.com, rust-for-linux@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 16, 2024 at 7:58=E2=80=AFAM Trevor Gross <tmgross@umich.edu> wr=
ote:
>
> The second link could be "Fixes: ..." (but whoever picks this up can
> probably do that)

`Fixes:` references a commit, not a URL. I think you meant `Closes:`,
but that one in turn is meant for bug fixes, which does not really fit
either. That is why I suggested `Link:` in the issue instead.

> Reviewed-by: Trevor Gross <tmgross@umich.edu>

Thanks!

Cheers,
Miguel