Received-SPF: pass (google.com: domain of linux-kernel+bounces-146562-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <d8d5b480-ec59-4fc5-a726-34aec5575a8d@arm.com>
Date: Tue, 16 Apr 2024 10:36:49 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 16/30] perf/arm_pmu: Assign parents for event_source
 devices
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
 Mark Rutland <mark.rutland@arm.com>, Peter Zijlstra <peterz@infradead.org>,
 Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>,
 Will Deacon <will@kernel.org>, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org
Cc: linuxarm@huawei.com, Shaokun Zhang <zhangshaokun@hisilicon.com>,
 Yicong Yang <yangyicong@hisilicon.com>, Jiucheng Xu
 <jiucheng.xu@amlogic.com>, Khuong Dinh <khuong@os.amperecomputing.com>,
 Atish Patra <atishp@atishpatra.org>, Anup Patel <anup@brainfault.org>,
 Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>,
 Frank Li <Frank.li@nxp.com>, Shuai Xue <xueshuai@linux.alibaba.com>,
 Vineet Gupta <vgupta@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
 Fenghua Yu <fenghua.yu@intel.com>, Dave Jiang <dave.jiang@intel.com>,
 Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
 linux-fpga@vger.kernel.org, Liang Kan <kan.liang@linux.intel.com>
References: <20240412161057.14099-1-Jonathan.Cameron@huawei.com>
 <20240412161057.14099-17-Jonathan.Cameron@huawei.com>
Content-Language: en-US
From: Suzuki K Poulose <suzuki.poulose@arm.com>
In-Reply-To: <20240412161057.14099-17-Jonathan.Cameron@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 12/04/2024 17:10, Jonathan Cameron wrote:
> Currently the PMU device appears directly under /sys/devices/
> Only root busses should appear there, so instead assign the pmu->dev
> parent to be the platform device.
> 
> Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@kroah.com/
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
>   drivers/perf/arm_pmu_platform.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/perf/arm_pmu_platform.c b/drivers/perf/arm_pmu_platform.c
> index 3596db36cbff..4b1a9a92ea11 100644
> --- a/drivers/perf/arm_pmu_platform.c
> +++ b/drivers/perf/arm_pmu_platform.c
> @@ -196,6 +196,7 @@ int arm_pmu_device_probe(struct platform_device *pdev,
>   	if (!pmu)
>   		return -ENOMEM;
>   
> +	pmu->pmu.parent = &pdev->dev;
>   	pmu->plat_device = pdev;
>   
>   	ret = pmu_parse_irqs(pmu);


Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>