Received-SPF: pass (google.com: domain of linux-kernel+bounces-146603-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "D, Lakshmi Sowjanya" <lakshmi.sowjanya.d@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>, "jstultz@google.com"
	<jstultz@google.com>, "giometti@enneenne.com" <giometti@enneenne.com>,
	"corbet@lwn.net" <corbet@lwn.net>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: "x86@kernel.org" <x86@kernel.org>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "linux-doc@vger.kernel.org"
	<linux-doc@vger.kernel.org>, "intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>, "andriy.shevchenko@linux.intel.com"
	<andriy.shevchenko@linux.intel.com>, "Dong, Eddie" <eddie.dong@intel.com>,
	"Hall, Christopher S" <christopher.s.hall@intel.com>, "Brandeburg, Jesse"
	<jesse.brandeburg@intel.com>, "davem@davemloft.net" <davem@davemloft.net>,
	"alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>,
	"joabreu@synopsys.com" <joabreu@synopsys.com>, "mcoquelin.stm32@gmail.com"
	<mcoquelin.stm32@gmail.com>, "perex@perex.cz" <perex@perex.cz>,
	"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>, "Nguyen, Anthony
 L" <anthony.l.nguyen@intel.com>, "peter.hilber@opensynergy.com"
	<peter.hilber@opensynergy.com>, "N, Pandith" <pandith.n@intel.com>, "Mohan,
 Subramanian" <subramanian.mohan@intel.com>, "T R, Thejesh Reddy"
	<thejesh.reddy.t.r@intel.com>
Subject: RE: [PATCH v6 01/11] x86/tsc: Add base clock properties in
 clocksource structure
Thread-Topic: [PATCH v6 01/11] x86/tsc: Add base clock properties in
 clocksource structure
Thread-Index: AQHaiz0PazTrRHQXt0yKbKUcSArdGrFiA2oAgAiwZpA=
Date: Tue, 16 Apr 2024 10:10:24 +0000
Message-ID: <CY8PR11MB7364EAD4BE0E1038A13C695DC4082@CY8PR11MB7364.namprd11.prod.outlook.com>
References: <20240410114828.25581-1-lakshmi.sowjanya.d@intel.com>
 <20240410114828.25581-2-lakshmi.sowjanya.d@intel.com> <87frvs3oer.ffs@tglx>
In-Reply-To: <87frvs3oer.ffs@tglx>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fZCem3OfmRUeadGxLm3Cl0AeviwAjXW5YG+w0oxua+WA9hjGMqE0BfrDlo6y?=
 =?us-ascii?Q?92eqSYfM+RNGb0JjvK4J5rtMWReKzT07+My3BawvUndpu1gD0eWfz9XH9sAy?=
 =?us-ascii?Q?VjetWVWFYOP4QJlM+cTuzu0UeFJgMkTD1kzONoKA5QxquFgByHqm3eEwsvDa?=
 =?us-ascii?Q?p3IPSlULX6CDsDe625iHADPPcU8cnpc5kZnU0svE9s6oHwDD+untMDsvbudk?=
 =?us-ascii?Q?jRnrCfYvzIQkPrG0mzDT4AcA9AigWhh9s9hieHhhy0DSG+hfAoba3nwimka6?=
 =?us-ascii?Q?UElYmswymiWadqtPnyqNvzqNnsE3198+An0AsjPFz3fiUUYX5wGvH4Mcr7zl?=
 =?us-ascii?Q?2aNueSyftcMni63kE1+cDwIx5qd5h5rgreICmWWLvAL0IHhXKywDQhY3jsjF?=
 =?us-ascii?Q?swWhpi1Jid+nbtX8hP2J7s0Qc4kBlibuxIqM4RNPqjLsxptPtn5WtKgQ+Bpu?=
 =?us-ascii?Q?8NXIk6OJwTzv0PE+LxAyIwquVS8/yg8HmyM14Q3Invnt4mwc0eJ54xZnuE6J?=
 =?us-ascii?Q?YvHDGcUg51F5OkjP6CGsWM/Iz582QMjBPWv2cK25hPOIEt5dlwIVMo1uqb2u?=
 =?us-ascii?Q?9stDOd6AF2dQd5oUJF/4QyKbNpchF08/H3GzciWHjSHO14Kl5PUUpSnqxc7k?=
 =?us-ascii?Q?omeywCAE8tAUvP48Hkbe6UlxFAl76WJXwTce8w3vIUZjMpiwU7JISob0cOUg?=
 =?us-ascii?Q?D4+bcgMLpBIStFVelZBHBBZ528KXhXRO9+m7J//1yN3+OpEavF9OfOSUdySP?=
 =?us-ascii?Q?razx7TtZqETjFF+WJwEixeofBnIruVGVby8cVKaV5PIZ5BlyCFAtCX11t45K?=
 =?us-ascii?Q?JHRNreLVaVpXo51ysG9/JDH4KeoJcSv+afXabEJrmPajIL+O7n9HGh2AaMC7?=
 =?us-ascii?Q?Mx9Jf7XITKvTUE3DnlYINouTmm4bmDiQ22ui/YflZfA/fZJecpHCnwo4HBXN?=
 =?us-ascii?Q?mYdY7ZG/NLhidlYk5XpIhpJGpFZh7eUP/sj8hhvxkhX1nR82eFuI88Wb5xvo?=
 =?us-ascii?Q?SHKPtB8+h44fCmOJ0i3XTlRaYId6lEaUC4FnSzqvoH/32EotFMdoRZIIfEp3?=
 =?us-ascii?Q?7Hf5AudjdKu6qSGMd3wz+PWyxXYaWLVLJhj78jvK0AwLM0KdKv6bD7+sUnot?=
 =?us-ascii?Q?N+r92W0a6Qid1B3wE8YmP+j0JyJmbdCZ1o70c9+HA1fbrBb1Zc2VIpuBZ6Ve?=
 =?us-ascii?Q?ZEQoB78v3+/XvQSyV7VJyycPyN8VvKzh+hsy50Q1qPqfmz6ZF5grEpIm8qoo?=
 =?us-ascii?Q?EUq4nhmRX3LU+3xtTJrM8UpHOAx16yURlk+t2Fz0qzdEqZublLyY1vpoTU8k?=
 =?us-ascii?Q?13351P8f9v9ONJx/RyJ4QWO2v8Sl/IG2mzrTyJir0qRLG20lE5m/XP1tCBIr?=
 =?us-ascii?Q?13xodUGY6qI81OeMoqU21v55PRHPGniie0tgKAoo3KUo9JLvj4K2BT8OUR5S?=
 =?us-ascii?Q?4yNiSt9d9WSkc7ygwQFsiO3yGnz7rK5S6rUFItCQkicLbVDxFPxhMth/VMh0?=
 =?us-ascii?Q?B8Vo7C3UWiRnX5UhC+Tw1sSMvcodGJPDLTbobL9LcIDu0MotgpPbnwWxqmQZ?=
 =?us-ascii?Q?iPJcs5ZFFsSB6EXW/1TW3jwckqPFq+AMz/mzuGWlLMBNcSQlKv0O+oBFF7NS?=
 =?us-ascii?Q?Hg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7364.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 877dfa4a-73c9-4314-a941-08dc5dfd6e9a
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2024 10:10:24.3316
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xlzBk8Cqa+5gwmqz/F/tMSwkbRX9lwjASXOtiD8h+SSsQWVci8DLT37rC8fgTqk2vjmLs/k8kQ9RcKb/U4z2+QB+mZ7YuLvmvA0Jacg00Gk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6617
X-OriginatorOrg: intel.com


> -----Original Message-----
> From: Thomas Gleixner <tglx@linutronix.de>
> Sent: Thursday, April 11, 2024 2:51 AM
> To: D, Lakshmi Sowjanya <lakshmi.sowjanya.d@intel.com>;
> jstultz@google.com; giometti@enneenne.com; corbet@lwn.net; linux-
> kernel@vger.kernel.org
> Cc: x86@kernel.org; netdev@vger.kernel.org; linux-doc@vger.kernel.org; in=
tel-
> wired-lan@lists.osuosl.org; andriy.shevchenko@linux.intel.com; Dong, Eddi=
e
> <eddie.dong@intel.com>; Hall, Christopher S <christopher.s.hall@intel.com=
>;
> Brandeburg, Jesse <jesse.brandeburg@intel.com>; davem@davemloft.net;
> alexandre.torgue@foss.st.com; joabreu@synopsys.com;
> mcoquelin.stm32@gmail.com; perex@perex.cz; linux-sound@vger.kernel.org;
> Nguyen, Anthony L <anthony.l.nguyen@intel.com>;
> peter.hilber@opensynergy.com; N, Pandith <pandith.n@intel.com>; Mohan,
> Subramanian <subramanian.mohan@intel.com>; T R, Thejesh Reddy
> <thejesh.reddy.t.r@intel.com>; D, Lakshmi Sowjanya
> <lakshmi.sowjanya.d@intel.com>
> Subject: Re: [PATCH v6 01/11] x86/tsc: Add base clock properties in clock=
source
> structure
>=20
> On Wed, Apr 10 2024 at 17:18, lakshmi.sowjanya.d@intel.com wrote:
> > From: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>
> >
> > Add base clock hardware abstraction in clocksource structure.
> >
> > Add clocksource ID for x86 ART(Always Running Timer). The newly added
> > clocksource ID and conversion parameters are used to convert time in a
> > clocksource domain to base clock and vice versa.
> >
> > Convert the base clock to the system clock using convert_base_to_cs()
> > in get_device_system_crosststamp().
>=20
> In https://lore.kernel.org/all/875xxhi1ty.ffs@tglx I asked you to provide=
 a
> change log which explains the WHY and not the WHAT. The new change log st=
ill
> fails to explain WHY this change is needed and which problem it is trying=
 to
> solve.

Rephrased the commit message to:
" Add base clock hardware abstraction in clocksource structure.

The core code has a mechanism to convert the ART base clock to
the corresponding tsc value.=20
Provide the generic functionality in convert_base_to_cs() to convert
base clock timestamps to system clocksource without requiring
architecture specific parameters.

Add the infrastructure in get_device_system_crosststamp()."

>=20
> I further asked you to do:
>=20
>     1) Add the clocksource_base struct and provide the infrastructure in
>        get_device_system_crosststamp()
>=20
>     2) Make TSC/ART use it
>=20
> But this still does #1 and #2 in one go.
>=20
> If you don't understand my review comments, then please ask. If you disag=
ree
> with them then please tell me and argue with me.
>=20
> Just ignoring them is not an option.

Sorry Thomas, that was a mis-understanding. We had split only realtime as s=
eparate patch.
We will split the first patch as suggested.=20
	1. Timekeeping part(convert_base_to_cs() and infrastructure in get_device_=
system_crosststamp())
	2. x86(TSC/ART values update into the structure)

Thanks,
Sowjanya

>=20
> Thanks,
>=20
>         tglx