Received-SPF: pass (google.com: domain of linux-kernel+bounces-146614-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 16 Apr 2024 11:22:36 +0100
From: Simon Horman <horms@kernel.org>
To: Sai Krishna <saikrishnag@marvell.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, sgoutham@marvell.com,
	gakula@marvell.com, hkelam@marvell.com, sbhatta@marvell.com
Subject: Re: [net-next PATCH] octeontx2-pf: Add ucast filter count
 configurability via devlink.
Message-ID: <20240416102236.GH2320920@kernel.org>
References: <20240414105830.678293-1-saikrishnag@marvell.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240414105830.678293-1-saikrishnag@marvell.com>

On Sun, Apr 14, 2024 at 04:28:30PM +0530, Sai Krishna wrote:
> Added a devlink param to set/modify unicast filter count. Currently
> it's hardcoded with a macro.

Hi Sai,

I think it would be nice to provide a sample devlink command in
the patch description, as you did for:

2da489432747 ("octeontx2-pf: devlink params support to set mcam entry count")

> Signed-off-by: Sai Krishna <saikrishnag@marvell.com>

..

> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.c

..

> +static int otx2_dl_ucast_flt_cnt_get(struct devlink *devlink, u32 id,
> +				     struct devlink_param_gset_ctx *ctx)
> +{
> +	struct otx2_devlink *otx2_dl = devlink_priv(devlink);
> +	struct otx2_nic *pfvf = otx2_dl->pfvf;
> +
> +	if (!pfvf->flow_cfg) {
> +		ctx->val.vu8 = 0;
> +		return 0;
> +	}
> +
> +	ctx->val.vu8 = pfvf->flow_cfg->ucast_flt_cnt;

nit: perhaps this could be more succinctly expressed as follows
     (completely untested!):

	ctx->val.vu8 = pfvf->flow_cfg ? pfvf->flow_cfg->ucast_flt_cnt : 0;

> +
> +	return 0;
> +}

..