Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp1964768lqp; Tue, 16 Apr 2024 03:23:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVArBJB6L4ycjGq8z3usXWv0PhTLrLJCVcYtS/qZUVjWYyVRvYnDN7JjJ8YOrmhP+23M+4bJ+sfhO650AfCwqnMO0ybXWKUFLjmYD0mGw== X-Google-Smtp-Source: AGHT+IGbCqXg7S3kyQl+FU72hqgKo2pHAGiset8oqH3H3OsLB6NKpGG7zq0uIYpIBqF2Byh/mFcd X-Received: by 2002:a05:6808:18f:b0:3c6:92c:fe0f with SMTP id w15-20020a056808018f00b003c6092cfe0fmr15853457oic.3.1713263013757; Tue, 16 Apr 2024 03:23:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713263013; cv=pass; d=google.com; s=arc-20160816; b=gaSM2+h7Z2nOD1A8KUzG7e9M9nUuPDPihxS5OOeVSfOK7DYUlkAp2ouyjm4BP3qg8J YIb8BigzvJgigoFo+2/5kEmQ6lpTPv0VBd07yJFf+usgsis7LUl0hHAFDtyi18Xpd1nh PDu5K1277rFdhDr32MZ1yuBx77/YVsJcOObeE7Uv8ZjoaYP7w5mV3gkNbQqzQmx0xYdh I5v0EKcA8M1BO99xIiAbpcFwmmBf67gHxI20BddL7R7zPZHS6lN8MSit3Be5qnKh3VWV pDT6ar+/6KsZGjit28Ed8MUNAcx073takC2rkMoMt6jX5v8nQebpZ4uEQwpaUiW9xxaO bZVg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id; bh=suW8/tLpFvlwUe54rBmmg2aiFYahRLtszTpUONNcvmM=; fh=Ciq99JfoZnUWBSHc6DCKpR9JCQCv8SV2em2mg5sgOeM=; b=JxAcTx1mj82OnqT5nTUHE7EFhM/PGsjHuNHWvdR02Q1d4/BXG+NX7V5/2J4vs/20RC 9kTp8dJgayskLuZhN0MvSZfkhYvLnMSAUdeb1IJ92BOduDcoiR55Yf8a7gyCgMYDEg2s WnxCn0qAoZwi73iAii53NFZSNu51KWxiA2o/xAS5TROUIum0gjl5U+Av79yXDEtgvRnU Zn0J01kIce7jxG9OaYZwLpMXCswbe+Z1ZO3gx2M/p5L/uVumJozvdSDEbfEJUriAfzCU yZ9Y8TGv33EN0+hYjy2SBCzz/4VIrQAreFsQ7Kvlige8nkwDygcYqEV3gy+F4DBpKaYl Sv8A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-146615-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-146615-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id cm9-20020a056a020a0900b005f3fe76ea9esi9949305pgb.649.2024.04.16.03.23.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 03:23:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-146615-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-146615-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-146615-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 3B8C7B20D76 for ; Tue, 16 Apr 2024 10:23:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4B14085942; Tue, 16 Apr 2024 10:23:18 +0000 (UTC) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3641B127B47; Tue, 16 Apr 2024 10:23:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713262997; cv=none; b=QHqojxKRulgIeSn6hTwxjkh3cnXWyOLWubnEJvPBo25+vaRqlQnnNXIPTLH1zPE50ezqRjsV0Lav3W/PmZf2r32ZKR8jJyDWhiBcu/3vwahEzd0SLHyTv/Hdt78ikQm7lIkk7nfwwYJiS/UtdZyC4Eybwl3oi7UIXLFIW5OZVcw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713262997; c=relaxed/simple; bh=rMjwkrwAOltl09/IG3yP8jEU5vYs2FMx8bZ7IyDk/fU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N1428HA67L8FS+fMLy1ULFJm0+wNVu+ddsvLV2/htVjyXUFGjjHJPza0UK/XIE6hsPmEdmDPkd3Mjwz97OkiWRu5P2NAGb3t4z8iI9mAUoyLwl6f2KbzRX0fpa9LzdARP7qNNkayJTNORF+pHktY1bo99Ao5sALpqiqw8+GxNx8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a51b008b3aeso514930466b.3; Tue, 16 Apr 2024 03:23:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713262994; x=1713867794; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=suW8/tLpFvlwUe54rBmmg2aiFYahRLtszTpUONNcvmM=; b=AhVYRZS0RYlTFHfttZgG7zO6FGLpTbINJoqL5TVoUtpi/llNdmMycnPc6+I9Bd+UJP 2meGXcgWUb9iLiDcCZmmnMArAXm9b/DT75byjh15aJb1R2DqQDeK12nfUXt68L+MkQj1 WIAPWVgZDlSvXjY+O4RmsC0Ta6dUghYmmS5pny9tDABItiNdFUUNQhJyugyUatQNfqCc RKmZ5B6YKqNyivLlcvrVdd3yz5LKWUOjhgluJxtgELKGMHrLYCu7zN3LoVkKBJOeiH7A a6QrsfnuI1yyCc9kZ2VfzQXFbORJAfea8G5vhUFagGC45R2UVxUDJs8vWhibdCpnh5si Pbkg== X-Forwarded-Encrypted: i=1; AJvYcCWP+vCSCkIGJ6jCjToacgLxFzv8r6HGJoitFiNQSahLeJ1Z3PBLf/B/uMOh1928OlPijqSAH/VWXlcPtPD+KUzGgPvdHsFZf0BACfz0LQ1FuYDFd+4LM/fgryD1IaAfTxSpMi99SAZ9f6p3UQ== X-Gm-Message-State: AOJu0Yx8xq4Y++u1aEh4vcIjkBrFjxkPIkazvQBK7L2bpTMCLCzGU5GT yPJtILET5AsvRkUitxJzJJ0KBv6LGqrtLRdgesgpYxu5ICJyuBEhKpQNgLTo5Ds= X-Received: by 2002:a17:906:48ce:b0:a55:339d:bd20 with SMTP id d14-20020a17090648ce00b00a55339dbd20mr2796054ejt.51.1713262994315; Tue, 16 Apr 2024 03:23:14 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:69? ([2a0b:e7c0:0:107::aaaa:69]) by smtp.gmail.com with ESMTPSA id o17-20020a1709061b1100b00a525492801dsm3967477ejg.119.2024.04.16.03.23.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Apr 2024 03:23:13 -0700 (PDT) Message-ID: <54679d54-3957-489d-a8b5-b98ea1c8a93c@kernel.org> Date: Tue, 16 Apr 2024 12:23:12 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/15] tty: msm_serial: use dmaengine_prep_slave_sg() To: Marek Szyprowski , gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org References: <20240405060826.2521-1-jirislaby@kernel.org> <20240405060826.2521-12-jirislaby@kernel.org> Content-Language: en-US From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 15. 04. 24, 23:17, Marek Szyprowski wrote: > On 05.04.2024 08:08, Jiri Slaby (SUSE) wrote: >> This is a preparatory for the serial-to-kfifo switch. kfifo understands >> only scatter-gatter approach, so switch to that. >> >> No functional change intended, it's just dmaengine_prep_slave_single() >> inline expanded. >> >> And in this case, switch from dma_map_single() to dma_map_sg() too. This >> needs struct msm_dma changes. I split the rx and tx parts into an union. >> TX is now struct scatterlist, RX remains the old good phys-virt-count >> triple. >> >> Signed-off-by: Jiri Slaby (SUSE) >> Cc: Bjorn Andersson >> Cc: Konrad Dybcio >> Cc: linux-arm-msm@vger.kernel.org > > I've just found that this patch broke UART operation on DragonBoard > 410c. I briefly checked and didn't notice anything obviously wrong here, > but the board stops transmitting any data from its serial port after the > first message. I will try to analyze this issue a bit more tomorrow. I double checked, but I see no immediate issues in the patch too. So please, if you can analyze this more… thanks, -- js suse labs