Message-ID: <4798EB07.50002@zytor.com>
Date: Thu, 24 Jan 2008 11:46:15 -0800
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Thunderbird 2.0.0.9 (X11/20071115)
MIME-Version: 1.0
To: Miklos Szeredi <miklos@szeredi.hu>
CC: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
       linux-kernel@vger.kernel.org
Subject: Re: [patch 10/26] mount options: fix devpts
References: <20080124193341.166753833@szeredi.hu> <20080124193429.480166399@szeredi.hu>
In-Reply-To: <20080124193429.480166399@szeredi.hu>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 784
Lines: 24

Miklos Szeredi wrote:
> Also add minor fix: when parsing the "mode" option, mask with
> S_IALLUGO instead of ~S_IFMT, which could leave unsed bits in the
> mask.

umode_t is 16 bits, so it doesn't.  The change is still good, of course.

> +	if (config.mode != DEVPTS_DEFAULT_MODE)
> +		seq_printf(seq, ",mode=%03o", config.mode);

I would rather this be unconditional, than that it be conditional on 
something other than the user having specified it in the first place.

Other than that,

Acked-by: H. Peter Anvin <hpa@zytor.com>

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/