Received-SPF: pass (google.com: domain of linux-kernel+bounces-146643-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Lance Yang <ioworker0@gmail.com>
To: david@redhat.com
Cc: akpm@linux-foundation.org,
	cgroups@vger.kernel.org,
	chris@zankel.net,
	corbet@lwn.net,
	dalias@libc.org,
	fengwei.yin@intel.com,
	glaubitz@physik.fu-berlin.de,
	hughd@google.com,
	jcmvbkbc@gmail.com,
	linmiaohe@huawei.com,
	linux-doc@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-mm@kvack.org,
	linux-sh@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org,
	muchun.song@linux.dev,
	naoya.horiguchi@nec.com,
	peterx@redhat.com,
	richardycc@google.com,
	ryan.roberts@arm.com,
	shy828301@gmail.com,
	willy@infradead.org,
	ysato@users.sourceforge.jp,
	ziy@nvidia.com,
	Lance Yang <ioworker0@gmail.com>
Subject: Re: [PATCH v1 05/18] mm: improve folio_likely_mapped_shared() using the mapcount of large folios
Date: Tue, 16 Apr 2024 18:40:08 +0800
Message-Id: <20240416104008.41979-1-ioworker0@gmail.com>
In-Reply-To: <20240409192301.907377-6-david@redhat.com>
References: <20240409192301.907377-6-david@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hey David,

Maybe I spotted a bug below.

[...]
 static inline bool folio_likely_mapped_shared(struct folio *folio)
 {
-	return page_mapcount(folio_page(folio, 0)) > 1;
+	int mapcount = folio_mapcount(folio);
+
+	/* Only partially-mappable folios require more care. */
+	if (!folio_test_large(folio) || unlikely(folio_test_hugetlb(folio)))
+		return mapcount > 1;
+
+	/* A single mapping implies "mapped exclusively". */
+	if (mapcount <= 1)
+		return false;
+
+	/* If any page is mapped more than once we treat it "mapped shared". */
+	if (folio_entire_mapcount(folio) || mapcount > folio_nr_pages(folio))
+		return true;

bug: if a PMD-mapped THP is exclusively mapped, the folio_entire_mapcount()
function will return 1 (atomic_read(&folio->_entire_mapcount) + 1).

IIUC, when mapping a PMD entry for the entire THP, folio->_entire_mapcount
increments from -1 to 0.

Thanks,
Lance

+
+	/* Let's guess based on the first subpage. */
+	return atomic_read(&folio->_mapcount) > 0;
 }
[...]