Received-SPF: pass (google.com: domain of linux-kernel+bounces-146672-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240409192301.907377-6-david@redhat.com> <20240416104008.41979-1-ioworker0@gmail.com>
 <3ef81fe3-2584-4db8-ab66-eaa44c035707@redhat.com>
In-Reply-To: <3ef81fe3-2584-4db8-ab66-eaa44c035707@redhat.com>
From: Lance Yang <ioworker0@gmail.com>
Date: Tue, 16 Apr 2024 18:52:24 +0800
Message-ID: <CAK1f24kph=hV6Da=fAXFuKChx5JVasPLYC7efQbPr+JT0WxQ1A@mail.gmail.com>
Subject: Re: [PATCH v1 05/18] mm: improve folio_likely_mapped_shared() using
 the mapcount of large folios
To: David Hildenbrand <david@redhat.com>
Cc: akpm@linux-foundation.org, cgroups@vger.kernel.org, chris@zankel.net, 
	corbet@lwn.net, dalias@libc.org, fengwei.yin@intel.com, 
	glaubitz@physik.fu-berlin.de, hughd@google.com, jcmvbkbc@gmail.com, 
	linmiaohe@huawei.com, linux-doc@vger.kernel.org, 
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-mm@kvack.org, linux-sh@vger.kernel.org, 
	linux-trace-kernel@vger.kernel.org, muchun.song@linux.dev, 
	naoya.horiguchi@nec.com, peterx@redhat.com, richardycc@google.com, 
	ryan.roberts@arm.com, shy828301@gmail.com, willy@infradead.org, 
	ysato@users.sourceforge.jp, ziy@nvidia.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 16, 2024 at 6:47=E2=80=AFPM David Hildenbrand <david@redhat.com=
> wrote:
>
> On 16.04.24 12:40, Lance Yang wrote:
> > Hey David,
> >
> > Maybe I spotted a bug below.
>
> Thanks for the review!
>
> >
> > [...]
> >   static inline bool folio_likely_mapped_shared(struct folio *folio)
> >   {
> > -     return page_mapcount(folio_page(folio, 0)) > 1;
> > +     int mapcount =3D folio_mapcount(folio);
> > +
> > +     /* Only partially-mappable folios require more care. */
> > +     if (!folio_test_large(folio) || unlikely(folio_test_hugetlb(folio=
)))
> > +             return mapcount > 1;
> > +
> > +     /* A single mapping implies "mapped exclusively". */
> > +     if (mapcount <=3D 1)
> > +             return false;
> > +
> > +     /* If any page is mapped more than once we treat it "mapped share=
d". */
> > +     if (folio_entire_mapcount(folio) || mapcount > folio_nr_pages(fol=
io))
> > +             return true;
> >
> > bug: if a PMD-mapped THP is exclusively mapped, the folio_entire_mapcou=
nt()
> > function will return 1 (atomic_read(&folio->_entire_mapcount) + 1).
>
> If it's exclusively mapped, then folio_mapcount(folio)=3D=3D1. In which c=
ase
> the previous statement:
>
> if (mapcount <=3D 1)
>         return false;
>
> Catches it.

You're right!

>
> IOW, once we reach this point we now that folio_mapcount(folio) > 1, and
> there must be something else besides the entire mapping ("more than once"=
).
>
>
> Or did I not address your concern?

Sorry, my mistake :(

Thanks,
Lance

>
> --
> Cheers,
>
> David / dhildenb
>