Received-SPF: pass (google.com: domain of linux-kernel+bounces-146709-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240415-minimax-v1-1-5feb20d66a79@chromium.org> <fbf22b53-7b68-4e60-99c7-ab38a77a53c8@web.de>
In-Reply-To: <fbf22b53-7b68-4e60-99c7-ab38a77a53c8@web.de>
From: Ricardo Ribalda <ribalda@chromium.org>
Date: Tue, 16 Apr 2024 13:32:52 +0200
Message-ID: <CANiDSCuvXvjfhw2mjSef1wR8RiL=9KrDEoh+3o1ed4+8P+AqGw@mail.gmail.com>
Subject: Re: [PATCH] coccinelle: misc: minmax: Suppress reports for err returns
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Julia Lawall <Julia.Lawall@inria.fr>, cocci@inria.fr, 
	LKML <linux-kernel@vger.kernel.org>, Denis Efremov <efremov@linux.com>, 
	Nicolas Palix <nicolas.palix@imag.fr>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Markus

On Tue, 16 Apr 2024 at 13:30, Markus Elfring <Markus.Elfring@web.de> wrote:
>
> =E2=80=A6
> > +++ b/scripts/coccinelle/misc/minmax.cocci
> > @@ -50,11 +50,26 @@ func(...)
> >       ...>
> >  }
> >
> > +// Ignore errcode returns.
> > +@errcode@
> =E2=80=A6
>
> I see that you would like to omit the specification =E2=80=9Cdepends on p=
atch=E2=80=9D
> from the previous SmPL rule location.
>
> Would you really like to influence and adjust SmPL code any more
> according to affected coccicheck operation modes?

I probably do not know what I am doing :), it is my first .cocci patch.

If I leave the "depends on patch", then the change is ignored in report mod=
e.

I think errcode needs to be executed in report and in patch mode, but
there might be a better way to do it.

>
> Regards,
> Markus


--=20
Ricardo Ribalda