Received-SPF: pass (google.com: domain of linux-kernel+bounces-146710-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240415094821.3060892-1-dawei.li@shingroup.cn>
In-Reply-To: <20240415094821.3060892-1-dawei.li@shingroup.cn>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Tue, 16 Apr 2024 13:34:32 +0200
Message-ID: <CAJZ5v0hgeRo0oVviN8GHNaR_wNOBxGyYF=S-2LU3GEOFSUzytQ@mail.gmail.com>
Subject: Re: [PATCH] powercap: Avoid explicit cpumask allocation on stack
To: Dawei Li <dawei.li@shingroup.cn>
Cc: daniel.lezcano@kernel.org, rafael@kernel.org, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 15, 2024 at 11:48=E2=80=AFAM Dawei Li <dawei.li@shingroup.cn> w=
rote:
>
> In general it's preferable to avoid placing cpumasks on the stack, as
> for large values of NR_CPUS these can consume significant amounts of
> stack space and make stack overflows more likely.
>
> Use cpumask_weight_and() to avoid the need for a temporary cpumask on
> the stack.
>
> Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
> ---
>  drivers/powercap/dtpm_cpu.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/powercap/dtpm_cpu.c b/drivers/powercap/dtpm_cpu.c
> index bc90126f1b5f..6b6f51b21550 100644
> --- a/drivers/powercap/dtpm_cpu.c
> +++ b/drivers/powercap/dtpm_cpu.c
> @@ -43,13 +43,11 @@ static u64 set_pd_power_limit(struct dtpm *dtpm, u64 =
power_limit)
>         struct dtpm_cpu *dtpm_cpu =3D to_dtpm_cpu(dtpm);
>         struct em_perf_domain *pd =3D em_cpu_get(dtpm_cpu->cpu);
>         struct em_perf_state *table;
> -       struct cpumask cpus;
>         unsigned long freq;
>         u64 power;
>         int i, nr_cpus;
>
> -       cpumask_and(&cpus, cpu_online_mask, to_cpumask(pd->cpus));
> -       nr_cpus =3D cpumask_weight(&cpus);
> +       nr_cpus =3D cpumask_weight_and(cpu_online_mask, to_cpumask(pd->cp=
us));
>
>         rcu_read_lock();
>         table =3D em_perf_state_from_pd(pd);
> @@ -123,11 +121,9 @@ static int update_pd_power_uw(struct dtpm *dtpm)
>         struct dtpm_cpu *dtpm_cpu =3D to_dtpm_cpu(dtpm);
>         struct em_perf_domain *em =3D em_cpu_get(dtpm_cpu->cpu);
>         struct em_perf_state *table;
> -       struct cpumask cpus;
>         int nr_cpus;
>
> -       cpumask_and(&cpus, cpu_online_mask, to_cpumask(em->cpus));
> -       nr_cpus =3D cpumask_weight(&cpus);
> +       nr_cpus =3D cpumask_weight_and(cpu_online_mask, to_cpumask(em->cp=
us));
>
>         rcu_read_lock();
>         table =3D em_perf_state_from_pd(em);
> --

Applied as 6.10 material, thanks!