Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp2000139lqp; Tue, 16 Apr 2024 04:42:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU4cz0rUqibTCLLt1ugulG7+hwWxXo0vy3m3TaAHWsXPZT8MhPNJ+cvfYY09XTeBtyzoSPJArjowv6klLmBF617fDb43E68ZBh6oAFVXA== X-Google-Smtp-Source: AGHT+IFejJxySE7GkfOJWsy99IJ5YsfMHEuSirfaBovS9FYyNPJxI1K/LyTmZKlOwdmyCd9i2p8h X-Received: by 2002:a17:902:c40a:b0:1e4:8c64:33c6 with SMTP id k10-20020a170902c40a00b001e48c6433c6mr14289716plk.59.1713267762444; Tue, 16 Apr 2024 04:42:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713267762; cv=pass; d=google.com; s=arc-20160816; b=gCivX2lxfKVMONrXOiuZMTKDB4lhN4mOVd9nMlwRB/7RLNz8SaKhmcEf+Y5fsEr3dF M9PDwPJBGGbFsexWqnJHdpJd6QJyv+OHeB381kGwB62sFtEOXZJqNPvfGtGE/JGnrw3W ZLVEQnPivhY8rFbyQjclh/+nw53OR7bU7lbX6nvYDhGpqV/5eO+ynagFyaOcBGp/pHTz nDSHdnlneyzXgsgTTwlyn5BuqC8y3ntmrWjgbfdHg594e9Yzbq0ijehkHEg2PbxNq4Oh iwk/JoVETUNVMXbfRj+a1WxpNX2SV3wM0D/fT3+dLL5s9FWuvN5dQnKpmmSTd7z75hPd NxVQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=12kte0YV4pJElifMBgdQAsbLqUzJwS7BYU0HKUwijZk=; fh=W/ih3Tm08Vw/VNl1Mx5C3DbabE968Wd38szWcNMHAR4=; b=v6/ijeFL4emi5xKoigrYwLTIVO3LXcsTBQ/M2ScSewVAHJyhnlRsjXts85bqSnF0VG eq1fB4SwJEzzHdcrUJX1r7ooMsK0T+TGg4/2pQelUnhpuVg4xmnE7AbBOWzh1hj8fsBl fLnZ0FplBKqH1ISrBpL3YV9YvpEtV+cVdUyRrXnUwiKk99/KPCjU36bAtHz2o1LjTc7I 9XlD5R8ICZl8G1PHTrffOEuGyUzVfRMjx5Y+JgOyy8rtfbT2bzEgbAIjyrypr3bmdI5z +VRzrZFbWv9Mh3YhJs6gTLKy4vK6w6OLP2Wf1g5GhfCURmuxRHV+Qm7rAKLOGLcu0eRy sz6A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=DOyuMTCa; arc=pass (i=1 spf=pass spfdomain=linux.ibm.com dkim=pass dkdomain=ibm.com dmarc=pass fromdomain=linux.ibm.com); spf=pass (google.com: domain of linux-kernel+bounces-146718-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-146718-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id p2-20020a170902f08200b001e3db9672dfsi9089036pla.567.2024.04.16.04.42.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 04:42:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-146718-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=DOyuMTCa; arc=pass (i=1 spf=pass spfdomain=linux.ibm.com dkim=pass dkdomain=ibm.com dmarc=pass fromdomain=linux.ibm.com); spf=pass (google.com: domain of linux-kernel+bounces-146718-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-146718-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 00CFF2832CB for ; Tue, 16 Apr 2024 11:42:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6B83F129E74; Tue, 16 Apr 2024 11:42:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="DOyuMTCa" Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D22E71292F9; Tue, 16 Apr 2024 11:42:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713267751; cv=none; b=gXJSgiDqkEFqGyLHbCKGoyYvPPU2VtPWzM5biqK0vB8Ztm8aj1cGwQHB0ZbN22vugDB9/qBGNZfXCRxyNnc9DtOtLXDMRJgy1RpCv2O/xmBEmOYvtjQymohL2d5rTy3UzWp32ZxTPe9pjt54m4GYJJHlLSbRYRifRg4vDAqTVwc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713267751; c=relaxed/simple; bh=GY8azhWTTIbSChM3ls4UcusD1MBHbKtXYmQjovgHkPE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WMAHd0BA1lCYiL/kPrbGqob9+r3txez53+YV1bZJBKxP0oY6NcMULsvsSDyGACLd9gj6UWs6C61g3QQtq+ncQ0O8A1OX7y9Y44Udf0gFz4+vnBmT1lFqcxlpF+WRRXOupfJcLscLePeR+JcnPkA7hRIJ2kyppPCNz6TqBDO4oq4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=DOyuMTCa; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43GATYaw001101; Tue, 16 Apr 2024 11:42:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=12kte0YV4pJElifMBgdQAsbLqUzJwS7BYU0HKUwijZk=; b=DOyuMTCaBmptzaKIUAc0fLFr3lhpnCJRYWhpTTR3D3+F/KEX77to9LVzjRS6iRwxaw8h CbzAl6d9zB5oIWlTozc74Y4oGN6wra3+KvCIAOpphkBroEitf/S3srJ98dWL3OQWb3on A57nA2tUvoxlbn4jaVSgr9c8VXvyvau6BilcRkEBPhI/DVyf7+lRjZ3qCBnFQT1OPKAo W9VFNzBCakegBmgTu9ohRmvWb9c1CBtw2rLltrN6hWPfD2kupFQAQT0YU3jC3xFYFehR sbaQLk/UsHLTl158X48Ek7+Bvll1VKJnk9xRDzD6uhM/nQtLEwGrUpYexgBSpdhd8hAF Sg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xhqky046n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Apr 2024 11:42:27 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43GBgQ1C009358; Tue, 16 Apr 2024 11:42:26 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xhqky046k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Apr 2024 11:42:26 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43GBVmHZ018222; Tue, 16 Apr 2024 11:42:26 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3xg4ct61wj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Apr 2024 11:42:26 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43GBgKf055378186 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Apr 2024 11:42:22 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B7A742004B; Tue, 16 Apr 2024 11:42:20 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8A8892004D; Tue, 16 Apr 2024 11:42:20 +0000 (GMT) Received: from p-imbrenda.boeblingen.de.ibm.com (unknown [9.152.224.66]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 16 Apr 2024 11:42:20 +0000 (GMT) From: Claudio Imbrenda To: linux-s390@vger.kernel.org Cc: linux-kernel@vger.kernel.org, frankja@linux.ibm.com, nrb@linux.ibm.com, nsg@linux.ibm.com, borntraeger@de.ibm.com, hca@linux.ibm.com, gerald.schaefer@linux.ibm.com, david@redhat.com Subject: [PATCH v1 2/2] s390/mm: fix clearing storage keys for huge pages Date: Tue, 16 Apr 2024 13:42:20 +0200 Message-ID: <20240416114220.28489-3-imbrenda@linux.ibm.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240416114220.28489-1-imbrenda@linux.ibm.com> References: <20240416114220.28489-1-imbrenda@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: oQpE0fQIwnxE4EDtpAqRVi_X0CG23LZH X-Proofpoint-ORIG-GUID: Y31KQI-gAlbdeS3w9tBDaN_iekTo93tD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-16_08,2024-04-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 adultscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404160072 The function __storage_key_init_range() expects the end address to be the first byte outside the range to be initialized. I.e. end - start should be the size of the area to be initialized. The current code works because __storage_key_init_range() will still loop over every page in the range, but it is slower than using sske_frame(). Fixes: 3afdfca69870 ("s390/mm: Clear skeys for newly mapped huge guest pmds") Signed-off-by: Claudio Imbrenda --- arch/s390/mm/hugetlbpage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/mm/hugetlbpage.c b/arch/s390/mm/hugetlbpage.c index c2e8242bd15d..dc3db86e13ff 100644 --- a/arch/s390/mm/hugetlbpage.c +++ b/arch/s390/mm/hugetlbpage.c @@ -139,7 +139,7 @@ static void clear_huge_pte_skeys(struct mm_struct *mm, unsigned long rste) } if (!test_and_set_bit(PG_arch_1, &page->flags)) - __storage_key_init_range(paddr, paddr + size - 1); + __storage_key_init_range(paddr, paddr + size); } void __set_huge_pte_at(struct mm_struct *mm, unsigned long addr, -- 2.44.0