Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp2001651lqp; Tue, 16 Apr 2024 04:46:04 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUfqlkHy0mHSkTFcKN92mLJIDoyJsEoFVMnX9gHjeK0rvLhdlnvu33PSqGOKdrjHSLXxrWazFcwftTP2kIbo7KQmJ4K1PfMcqX8UqKyiQ== X-Google-Smtp-Source: AGHT+IEAH1qnt1MB/e4l+fVF/3O/xLTX8Lw8M1XuxHzEJR7avLV9aHSbXFz06zZHtOp2ivFuZJPD X-Received: by 2002:a05:6214:10c5:b0:69b:57da:902a with SMTP id r5-20020a05621410c500b0069b57da902amr9774547qvs.16.1713267964586; Tue, 16 Apr 2024 04:46:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713267964; cv=pass; d=google.com; s=arc-20160816; b=iDz7l/a1URwObY6b26zacgO52Vly4RzZSxh4efuHE6P+TfrBdRf0TcZJeWfTpMlsSH Qzvrb/Qn3pnXfhfqxM+DvSsNBIZWFCDV/m0YUSSHMOMDwzageK3g0BId+HQr2MepaRqP Pw9pzlmDBIk/xkHqhvNCpQugPvWZQWPS2wrMUC9TMC5/wQcK2UT2bWBIQ7sFhTgYL5m/ vNB6uQSdZmO0aTQAWoN5SrhSYPdgq3t3/Mp0FHO5zU6BDP3i3DVImkTH8g5eDeTto1Hj +fphwRUc5VmIg5vRY0s4ngpeDBfodGEZ+54etrk5c/g8AYzuAGSCK6k2PcJAg9tmRGFo LtVw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=tdUnM3xBjzgia4zPdFCDDh/Nsg4sb223JIagygk0RiE=; fh=VJaUJw0RVT4EpjLJNEBo0cigmQwbnVZp+vngCU/FVCc=; b=NN8MDoN2Jm2PQdYqHay6AVS/1TOyin95Hit4YDfy5L0Zf87jmvCyj0wx4Z7VsXu98A iCkL1yG9pagsZ+NtWJt0MZOpdKo6x0EHWUqp+Fo279BB9hG/2qs7NDo8zPuYLI+nO7gh LDN4ZIRSwAaSN3B5LC9wScpo9n9VhTCtSVqMV89NH3Cu/67EOfcNfAN/3t80V7VPYS3Q pdYUrbnYusj/Sr3y6F6ktO31GeWtVTSrn2IpO9R4nhr/Ib6prWye+G5X9o1DnytOf+0N gH2zIAdvepdRIWdryNxaFcIu2Vmm4t7iSGQW9SFlRz1U1kX+t4xTGQZxHJVPGov7zZoH sfWg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-146722-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-146722-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id t15-20020a0cf98f000000b006992073ffd4si12169991qvn.507.2024.04.16.04.46.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 04:46:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-146722-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-146722-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-146722-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 378821C20CAB for ; Tue, 16 Apr 2024 11:46:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 87A9D129E7F; Tue, 16 Apr 2024 11:45:56 +0000 (UTC) Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3769E129A73; Tue, 16 Apr 2024 11:45:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713267956; cv=none; b=RY68/1bhZ4gv76DJubTP+33V/RzQPpCeAwOzRzNCMwl9OCz5bXVm5Fw4wRZaCXtghoyMSOD8991/1WxHw3fbtr4UKUcEbdclTZEoKpwzdL7ecL4JJMalTnuzcPyVHbscprJLnM6YXAHwy7hJJh183dBn76sGBJjpnQnemb/Xg+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713267956; c=relaxed/simple; bh=2EiEuGAYLJcLczJGOTsB1MV+9H93nFB6tDeDt5gKoFc=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=lfiTO4lA+cqxKGzakB4NtpXLwU7gSPJ0UFqSRxfnf/Pfro3+e4LHiGSsfIiqcop6QV8Xh0hKcFJR9V4qH3oKnf/roF5BazgF9kIvSiAp4yJL0sDseiNfzThd1jHP4XyL+jdLNl4DyQhCQzKN85IL77wSBhZIG50/b//iXu6NS3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from msk1wst434n.omp.ru (81.22.207.138) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Tue, 16 Apr 2024 14:45:37 +0300 From: Roman Smirnov To: Michael Krufky , Mauro Carvalho Chehab , Jia-Ju Bai , Hans Verkuil CC: Roman Smirnov , , , Sergey Shtylyov , Subject: [PATCH 1/3] media: tuners: tda18271: fix error code handling in tda18271_attach() Date: Tue, 16 Apr 2024 14:45:07 +0300 Message-ID: <20240416114509.198069-1-r.smirnov@omp.ru> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 04/16/2024 11:28:46 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 19 X-KSE-AntiSpam-Info: Lua profiles 184736 [Apr 16 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.4 X-KSE-AntiSpam-Info: Envelope from: r.smirnov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 17 0.3.17 f2153f38d75b12894d9cf445f96cd15c9ef63a9d X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 81.22.207.138 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: msk1wst434n.omp.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;127.0.0.199:7.1.2;omp.ru:7.1.1;81.22.207.138:7.1.2 X-KSE-AntiSpam-Info: ApMailHostAddress: 81.22.207.138 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 19 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 04/16/2024 11:34:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 4/16/2024 8:38:00 AM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit tda18271_attach() uses the hybrid_tuner_request_state() macro. It may return the error code -ENOMEM, but the function handle the value 0 instead. Found by Linux Verification Center (linuxtesting.org) with Svace. Fixes: b9302fa7ed97 ("media: tuners: fix error return code of hybrid_tuner_request_state()") Signed-off-by: Roman Smirnov --- drivers/media/tuners/tda18271-fe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/tuners/tda18271-fe.c b/drivers/media/tuners/tda18271-fe.c index a7e721baaa99..23432210f06a 100644 --- a/drivers/media/tuners/tda18271-fe.c +++ b/drivers/media/tuners/tda18271-fe.c @@ -1255,7 +1255,7 @@ struct dvb_frontend *tda18271_attach(struct dvb_frontend *fe, u8 addr, hybrid_tuner_instance_list, i2c, addr, "tda18271"); switch (instance) { - case 0: + case -ENOMEM: goto fail; case 1: /* new tuner instance */ -- 2.34.1