Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp2009542lqp; Tue, 16 Apr 2024 05:03:13 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUS+3OhaHBP+W8BW8eXsBa/8IUn9rlTwflppENXIXk3gsgoGndQ6We0uyOO8cX7e6I6uFG19DUns2Y2ny933iNL6hdRvR0GdZO1NFezsw== X-Google-Smtp-Source: AGHT+IFo5KmKQqPf0V3d6cJTqPm2FyMV7vl7Q7e6rUes3epGBrUnrnYETLGJEPnyvR+d89PDOgyz X-Received: by 2002:a17:906:b892:b0:a51:8672:66e4 with SMTP id hb18-20020a170906b89200b00a51867266e4mr2241601ejb.22.1713268992993; Tue, 16 Apr 2024 05:03:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713268992; cv=pass; d=google.com; s=arc-20160816; b=tv7dlJzr7w23+4UUsxDT2Uawqj/2SDQqMUhBZdvmFoiYsEDh+FF+4s3PxzEs4p/vqH T4/W0tglbv8qMF7plo2BYeTxYaLPZ/XIaTCbwMpjgxb9gQdfJNvfv05voUxSVmG+BDPo b/0KWL17Fng/oKYb3O1uZbSogNZ1Z3KM725FFIGiK9+ECA45U9cTVLMJbVXNFW0tccTx Ug2LIXRLjjDJkDgwWw4K7X6qzrcoTtpabQF01DufZAWYLw+wQY07wWWXV8VRxlkb06T2 O+8ufV55oYxVOEHpwji5ZmpksqUXojq6jcCPShvivIZWA1LWIeUfQmjBwdTc+pwrKDKw q7nA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=RL4SldF35NlNvMsqOFwvpvMKNHxNrohbBmlz5SARb3A=; fh=AaYFKcHLjCY63mFBFLuryF/5/DKfnsH8X7QySyyRwEE=; b=ehH9AcK01b2g1SrvEZ1m9EI236Nu6P3gqcj5AJuvm0WgFyHvDDg/iLLa3CkLiusXjc l7kOYeIoOjqPb5ggbkLmEd8c+pBTtBzA02u3KUEevVHy/5h2fZnGHp6GHShhhPSqxBCw 0wUK0j70r2FiHdfYbXa9tV2pcxnIV2qfXxyufQOfkAK+QMWTVPTIAq578A89HWv8KQ0h 9uwSyExigsydqVhLYCi0cRD+DpZPIsWT6Ld+Shj6QaAYfKew3vDpeClhjqLNYwKRY3lX hMBtkVeveRA217F1UCN0F358Rzgs2GiwUBNCVxFytBSrQx6oWPD4etRuCK9bKbUuy1xQ DnVA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=efSm+JIt; arc=pass (i=1 spf=pass spfdomain=linux.ibm.com dkim=pass dkdomain=ibm.com dmarc=pass fromdomain=linux.ibm.com); spf=pass (google.com: domain of linux-kernel+bounces-146738-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-146738-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id y7-20020a1709060a8700b00a553488eb9bsi1233837ejf.930.2024.04.16.05.03.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 05:03:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-146738-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=efSm+JIt; arc=pass (i=1 spf=pass spfdomain=linux.ibm.com dkim=pass dkdomain=ibm.com dmarc=pass fromdomain=linux.ibm.com); spf=pass (google.com: domain of linux-kernel+bounces-146738-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-146738-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B5C2A1F21784 for ; Tue, 16 Apr 2024 12:03:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B569C12B16E; Tue, 16 Apr 2024 12:02:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="efSm+JIt" Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1003512A170; Tue, 16 Apr 2024 12:02:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713268957; cv=none; b=qs+6Lp/t4es8xR/mTx8r/p0tRQN+tUKBQOGKdHteoDv+gz3skqtNawlIWioCl79E1uODTjzRjnc7vYN7Mmc6J+UPs2WR+B6HOjYsf+8EBlyPPnQl+kx+2NSc3O1K9w1Zpl7o13kJ9x+s6tslBSzJo+vZWHHyJnD95O4/slBGnDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713268957; c=relaxed/simple; bh=ZWpYfz4eCT9K2GMgCPAps04fnJ+d32kW6EGhaGfLoCc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mB+RDllI98riywtAjuUbNbhD+xJtc2jlnIS96FTaSkZupu6EV9Dhe1iqlEEWN4QmQcOW2j51DVwnXqOypM0raiKhzLXX4lt7Myo+hLSmgmNFwXAyRQmuhVTmz366aYQJ8zWRvzV0nh99znDzm+PImg+deDIGINKM3kMU0rwT2eY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=efSm+JIt; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43GAScMb031904; Tue, 16 Apr 2024 12:02:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=RL4SldF35NlNvMsqOFwvpvMKNHxNrohbBmlz5SARb3A=; b=efSm+JItYNBcGoyKi3IcXexxmeDEg0KGkbcb0KrVvHA3ComO6H83i1SwsZehZzFpptME diu1IoirH4sLxgs5gV2a+OlehqNnsUMziuxq2jS0w6isJyOzvrxikXZLE5rPeoexUsnL JAGDLFU9O9U0adFa3FI1VuikA7JRT/ECHnfkzv96gwQ1E1OJUNR2HUN7EWEekxG/zsFP Sw5rg8UgwDDkRPEvflR6qavz4FO1zzBa5o+0ChV5hyM4cSThjmPjlMKfkNa1IYznvX4u qG80nmD4zh42mpx7P1TOjTVCx9dt/kz5E+YL0TQYXIbuY2qFVoB1MHLD735YkOWzWlrN MQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xhqky0598-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Apr 2024 12:02:30 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43GC28mM004926; Tue, 16 Apr 2024 12:02:29 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xhqky0595-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Apr 2024 12:02:29 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43G9drqv015506; Tue, 16 Apr 2024 12:02:29 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3xg5vm5sye-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Apr 2024 12:02:28 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43GC2NBS40042794 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Apr 2024 12:02:25 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3764D2004B; Tue, 16 Apr 2024 12:02:23 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 914B120043; Tue, 16 Apr 2024 12:02:22 +0000 (GMT) Received: from [9.152.224.222] (unknown [9.152.224.222]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 16 Apr 2024 12:02:22 +0000 (GMT) Message-ID: <20d1d8c5-70e9-4b00-965b-918f275cfae7@linux.ibm.com> Date: Tue, 16 Apr 2024 14:02:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] s390/mm: re-enable the shared zeropage for !PV and !skeys KVM guests To: Alexander Gordeev , David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Janosch Frank , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Andrew Morton , Peter Xu , Sven Schnelle , Gerald Schaefer , Andrea Arcangeli , kvm@vger.kernel.org, linux-s390@vger.kernel.org References: <20240411161441.910170-1-david@redhat.com> <20240411161441.910170-3-david@redhat.com> <8533cb18-42ff-42bc-b9e5-b0537aa51b21@redhat.com> Content-Language: en-US From: Christian Borntraeger In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: rOCqEBPwxOZabIO0iThK6HIAofE6o9PZ X-Proofpoint-ORIG-GUID: c0NOLnVFYJU1pyCLAA0PU_HqyxkdNqbp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-16_08,2024-04-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 mlxlogscore=768 spamscore=0 mlxscore=0 adultscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404160074 Am 16.04.24 um 08:37 schrieb Alexander Gordeev: >> We could piggy-back on vm_fault_to_errno(). We could use >> vm_fault_to_errno(rc, FOLL_HWPOISON), and only continue (retry) if the rc is 0 or >> -EFAULT, otherwise fail with the returned error. >> >> But I'd do that as a follow up, and also use it in break_ksm() in the same fashion. > > @Christian, do you agree with this suggestion? I would need to look into that more closely to give a proper answer. In general I am ok with this but I prefer to have more eyes on that. From what I can tell we should cover all the normal cases with our CI as soon as it hits next. But maybe we should try to create/change a selftest to trigger these error cases?