Received-SPF: pass (google.com: domain of linux-kernel+bounces-146750-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240408071758.2526806-1-arnd@kernel.org>
In-Reply-To: <20240408071758.2526806-1-arnd@kernel.org>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Tue, 16 Apr 2024 21:08:19 +0900
Message-ID: <CAK7LNARRYJzOVP8eDhLHoqrcm165ztc4cwazu+tquqSzeGGUkg@mail.gmail.com>
Subject: Re: [PATCH] [v2] scripts/unifdef: avoid constexpr keyword
To: Arnd Bergmann <arnd@kernel.org>
Cc: linux-kbuild@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>, 
	Nathan Chancellor <nathan@kernel.org>, Nicolas Schier <nicolas@fjasle.eu>, Tony Finch <dot@dotat.at>, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 8, 2024 at 4:18=E2=80=AFPM Arnd Bergmann <arnd@kernel.org> wrot=
e:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Starting with c23, 'constexpr' is a keyword in C like in C++ and cannot
> be used as an identifier:
>
> scripts/unifdef.c:206:25: error: 'constexpr' can only be used in variable=
 declarations
>   206 | static bool             constexpr;              /* constant #if e=
xpression */
>       |                         ^
> scripts/unifdef.c:880:13: error: expected identifier or '('
>   880 |                 constexpr =3D false;
>       |                           ^
>
> Rename this instance to allow changing to C23 at some point in the future=
.
>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: Nicolas Schier <nicolas@fjasle.eu>
> Cc: linux-kbuild@vger.kernel.org
> Reviewed-By: Tony Finch <dot@dotat.at>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  v2: include fixup from Tony


Applied to linux-kbuild. Thanks.


> ---
>  scripts/unifdef.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/scripts/unifdef.c b/scripts/unifdef.c
> index db00e3e30a59..ff15efd6e7d7 100644
> --- a/scripts/unifdef.c
> +++ b/scripts/unifdef.c
> @@ -203,7 +203,7 @@ static int              depth;                      /=
* current #if nesting */
>  static int              delcount;              /* count of deleted lines=
 */
>  static unsigned         blankcount;            /* count of blank lines *=
/
>  static unsigned         blankmax;              /* maximum recent blankco=
unt */
> -static bool             constexpr;             /* constant #if expressio=
n */
> +static bool             constexpression;       /* constant #if expressio=
n */
>  static bool             zerosyms =3D true;       /* to format symdepth o=
utput */
>  static bool             firstsym;              /* ditto */
>
> @@ -819,7 +819,7 @@ static const struct ops {
>  /*
>   * Function for evaluating the innermost parts of expressions,
>   * viz. !expr (expr) number defined(symbol) symbol
> - * We reset the constexpr flag in the last two cases.
> + * We reset the constexpression flag in the last two cases.
>   */
>  static Linetype
>  eval_unary(const struct ops *ops, int *valp, const char **cpp)
> @@ -877,7 +877,7 @@ eval_unary(const struct ops *ops, int *valp, const ch=
ar **cpp)
>                 cp =3D skipcomment(cp);
>                 if (defparen && *cp++ !=3D ')')
>                         return (LT_ERROR);
> -               constexpr =3D false;
> +               constexpression =3D false;
>         } else if (!endsym(*cp)) {
>                 debug("eval%d symbol", ops - eval_ops);
>                 sym =3D findsym(cp);
> @@ -895,7 +895,7 @@ eval_unary(const struct ops *ops, int *valp, const ch=
ar **cpp)
>                         lt =3D *valp ? LT_TRUE : LT_FALSE;
>                         cp =3D skipargs(cp);
>                 }
> -               constexpr =3D false;
> +               constexpression =3D false;
>         } else {
>                 debug("eval%d bad expr", ops - eval_ops);
>                 return (LT_ERROR);
> @@ -955,10 +955,10 @@ ifeval(const char **cpp)
>         int val =3D 0;
>
>         debug("eval %s", *cpp);
> -       constexpr =3D killconsts ? false : true;
> +       constexpression =3D killconsts ? false : true;
>         ret =3D eval_table(eval_ops, &val, cpp);
>         debug("eval =3D %d", val);
> -       return (constexpr ? LT_IF : ret =3D=3D LT_ERROR ? LT_IF : ret);
> +       return (constexpression ? LT_IF : ret =3D=3D LT_ERROR ? LT_IF : r=
et);
>  }
>
>  /*
> --
> 2.39.2
>


--=20
Best Regards
Masahiro Yamada