Received-SPF: pass (google.com: domain of linux-kernel+bounces-146774-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 16 Apr 2024 13:19:09 +0100
From: Lee Jones <lee@kernel.org>
To: Ben Greear <greearb@candelatech.com>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-leds@vger.kernel.org,
	Johannes Berg <johannes@sipsolutions.net>
Subject: Re: 6.9.0-rc2+ kernel hangs on boot (bisected, maybe LED related)
Message-ID: <20240416121909.GU2399047@google.com>
References: <30f757e3-73c5-5473-c1f8-328bab98fd7d@candelatech.com>
 <30819e01-43ce-638f-0cc6-067d6a8d03c7@candelatech.com>
 <89a9eec3-337f-3c9f-6bbe-00a26a15287c@candelatech.com>
 <20240411070718.GD6194@google.com>
 <de43c7e1-7e8c-bdbe-f59e-7632c21da24a@candelatech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <de43c7e1-7e8c-bdbe-f59e-7632c21da24a@candelatech.com>

On Mon, 15 Apr 2024, Ben Greear wrote:

> On 4/11/24 00:07, Lee Jones wrote:
> > On Wed, 03 Apr 2024, Ben Greear wrote:
> > 
> > > On 4/2/24 10:38, Ben Greear wrote:
> > > > On 4/2/24 09:37, Ben Greear wrote:
> > > > > Hello,
> > > > > 
> > > > > Sometime between rc1 and today's rc2, my system quit booting.
> > > > > I'm not seeing any splats, it just stops.  Evidently before
> > > > > sysrq is enabled.
> > > > > 
> > > > > [  OK  ] Started Flush Journal to Persistent Storage.
> > > > > [  OK  ] Started udev Coldplug all Devices.
> > > > >            Starting udev Wait for Complete Device Initialization...
> > > > > [  OK  ] Listening on Load/Save RF …itch Status /dev/rfkill Watch.
> > > > > [  OK  ] Created slice system-lvm2\x2dpvscan.slice.
> > > > >            Starting LVM2 PV scan on device 8:19...
> > > > >            Starting LVM2 PV scan on device 8:3...
> > > > > [  OK  ] Started Device-mapper event daemon.
> > > > > iwlwifi 0000:04:00.0: WRT: Invalid buffer destination: 0
> > > > > sysrq: This sysrq operation is disabled.
> > > > > 
> > > > > I can start a bisect, but in case anyone knows the answer already, please let me know.
> > > > > 
> > > > > Thanks,
> > > > > Ben
> > > > > 
> > > > 
> > > > So, deadlock I guess....
> > 
> > Does this help you in any way?
> > 
> > https://lore.kernel.org/all/bbcdbc1b-44bc-4cf8-86ef-6e6af2b009c3@gmail.com/
> > 
> Hello Lee,
> 
> I cannot see how that patch above would fix my issues since I am not using that driver,
> but possibly some similar change needs to be made to iwlwifi.
> 
> Johannes, you had another suggestion: changing iwlwifi's request_module() to request_module_nowait() in
> iwl_req_fw_callback()
> 
> Is that still best thing to try in your opinion?

I mean the general principle, rather than the exact patch.

Yes, you would need to apply it to your own use-case.

-- 
Lee Jones [李琼斯]