Received-SPF: pass (google.com: domain of linux-kernel+bounces-146785-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Peng Fan <peng.fan@nxp.com>
To: Sudeep Holla <sudeep.holla@arm.com>, "Peng Fan (OSS)"
	<peng.fan@oss.nxp.com>
CC: "cristian.marussi@arm.com" <cristian.marussi@arm.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] firmware: arm_scmi: power_control: support suspend
 command
Thread-Topic: [PATCH] firmware: arm_scmi: power_control: support suspend
 command
Thread-Index: AQHajxwygJMjjnYsXEamYB79VvBL0LFqnqIAgAA1LnA=
Date: Tue, 16 Apr 2024 12:26:24 +0000
Message-ID:
 <DU0PR04MB9417549489A54D23D0F6F57E88082@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240415101141.1591112-1-peng.fan@oss.nxp.com>
 <Zh5BXAuLKM1uUOyD@bogus>
In-Reply-To: <Zh5BXAuLKM1uUOyD@bogus>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?QG6tRSI3CRntCUHTU/JzZ37vlETTB65ovyu4ndTHHQprPpL2ba67cOLiQ1v6?=
 =?us-ascii?Q?4VVKa9+ecFuPjOgaBF97bph/MiRWtjr/cbGFTqj8oGoPAtlCcK23/n8y3bRD?=
 =?us-ascii?Q?pv/0p62G9l5Gq1YswUvDHTv99kZm8z91o87g8ClFeBCqIEXzvPw6uC8Dfifc?=
 =?us-ascii?Q?CmNJD++oe9N3Zffpas5kfSyAtKJmoZykf4pzNKg71hri6XqYWrwD9Wk7jO1F?=
 =?us-ascii?Q?tt2d9swBklDWh7nT90iA3iMXEXQNV0pXxz40F75BCp1v5BvFZYDJlQSzRV64?=
 =?us-ascii?Q?VH6/O/yCwllq6Oc9jCnmZhyH8wx59CauRXdlWT0zeRMTg69YExr8jzpAxkfT?=
 =?us-ascii?Q?Xa87fQGfnfSEKRilFBg1bLMgnlZyVv/rP8TdRVcJ869ZJdUjR9/x/3pN+A+l?=
 =?us-ascii?Q?9DiPDJWhc3jGjr7zyQBxqEFXLOmEE9VjDT7H4w4ojg9aqEtReTyYNg35cXYE?=
 =?us-ascii?Q?1KzwXdw3dLoXr++qr2mJ+msixl2hnmgz/qGqhkGexHBRreXxnUwVK6aRK0U9?=
 =?us-ascii?Q?o+1ctKwbcsWUEv/8rA1uIbubIvaqE0SjqpnyOWygASOPx04J0gu0m6Md20kj?=
 =?us-ascii?Q?unZdjr/9UirGL0TcfVizoTdHmKkgJnb+vSW8no5AIcmgU3orG6mRmHXJA9C4?=
 =?us-ascii?Q?0HiPMXCj6lt72TD7prKxbYA4cpoj/XanZ2FM0a6VnK0fCgzB5wq2Dk0Ouy2b?=
 =?us-ascii?Q?JXILgVQJurVgRxDDXtt+WUxZtDUc4Nz4qN31HGm0DS5WiqnSxCXqhm3hLfuI?=
 =?us-ascii?Q?aDpf23WCezEbv0XShUeMApcVHdCMABw1JnkjKmBrEiZJcjrRaavIHWupDzcS?=
 =?us-ascii?Q?SNYatNQeH8UY42/DqZ8JS1Njl0yZbRwZalM3kxaB8eVkewEog7y/WNXwFV7w?=
 =?us-ascii?Q?ILYC/DcrIqibFiMLMWnK2iObSeF51DHK/pBDX+E3FqdpOVz8Kp9WU56+dOmI?=
 =?us-ascii?Q?ZAsKzw5bPyVrqlX362SW9JfhbKb3ungMjNslHEYVbIWXnvMEzpPQE1qD36R0?=
 =?us-ascii?Q?HovzOjRceRD8BsKygiOGqOOrRfW8dCQ3irI9k5dJaYKB8to5sQWRc82mTXci?=
 =?us-ascii?Q?L/cHh+uAsmA4G5oIY4V54Bh0myH1lQCeh0w6wdPgx1K4OkOTnE5hmTJcuvGO?=
 =?us-ascii?Q?RbXfcwKniT3IXkULcBlFF/iEQLi7pIZnsG0aVHDHZibdWAWtyQlZdrpkHBvd?=
 =?us-ascii?Q?WKRIK2NmUeXS5lK3SWzLoD3S0nein0YI7NcSqz2zNbVkP0hVIxI8QfvAngHy?=
 =?us-ascii?Q?q+7zMe2+rOkpOl8fBaKjdVGGPiiMpquOwAz3uuKUaV/rx2C8/djNhfaTMb1W?=
 =?us-ascii?Q?ajG4tXcmtEDIypEKqbVc6wdRreNbTHA19YJKAHm11Fi1dG26BIm9oHJsM/y3?=
 =?us-ascii?Q?hM/9Fq/fLJlR/WqARIh1sVXu4Wkop1tPso6TChrvlisCeYq2CYP+m1oU3qQ9?=
 =?us-ascii?Q?DWe0KvCrnl9NevOq18ncenizzH8Onvk1dQiOzonqZSot9heZZ010rq7l0aul?=
 =?us-ascii?Q?mUAsqdTKZvTCAW+ytnz6zblOBKKQW9RBQSAE2XTG8sHxtchaAONAAFWjaLgj?=
 =?us-ascii?Q?oFs1LYXuOidm8GPBKtw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f210e39-a3a7-44a4-af3d-08dc5e106e6d
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2024 12:26:24.4670
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UcDaWscOrCGZZmdaQhOg4+p0sD9ndpRDbbv2/N7K5s+QZTDcALYzsgrP1t7Dwxu9koHHPXdI6wwHDciMZwDXhg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9836

Hi Sudeep,

> Subject: Re: [PATCH] firmware: arm_scmi: power_control: support suspend
> command
>=20
> On Mon, Apr 15, 2024 at 06:11:41PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Support System suspend notification. Using a work struct to call
> > pm_suspend. There is no way to pass suspend level to pm_suspend, so
> > use MEM as of now.
> >
>=20
> While the change itself is simple and no-controversial, I am bit worried
> about:
>=20
> 1. The choice of S2R(MEM) by default - not sure if different system
>    prefer different things. The userspace can configure whatever default
>    behaviour expected as S2R IIUC, so should be OK. I need to check thoug=
h.
>=20
> 2. The userspace needs to keep the wakeup source enabled always which
>    I need to check if it is feasible on all the platforms. If wakeups
>    are not configured properly and suspend is triggered, the system can
>    never resume back.
>=20
> We may need to mention above points at-least as part of commit log.=20

ok, I will add the info you listed in V2 commit log.

I would
> wait for some feedback from SCMI users.

Agree.

Thanks,
Peng.
>=20
> --
> Regards,
> Sudeep