Received-SPF: pass (google.com: domain of linux-kernel+bounces-146802-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Julian Stecklina <julian.stecklina@cyberus-technology.de>
To: Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>
Cc: Thomas Prescher <thomas.prescher@cyberus-technology.de>,
	Julian Stecklina <julian.stecklina@cyberus-technology.de>,
	kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] KVM: nVMX: remove unnecessary CR4_READ_SHADOW write
Date: Tue, 16 Apr 2024 14:35:57 +0200
Message-ID: <20240416123558.212040-2-julian.stecklina@cyberus-technology.de>
In-Reply-To: <20240416123558.212040-1-julian.stecklina@cyberus-technology.de>
References: <20240416123558.212040-1-julian.stecklina@cyberus-technology.de>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?7qKqF0IADGO/IznKZXCMkvvC3Y4AcLA/EgfSS0DPQWnlZItl8iy7dPt4PLQZ?=
 =?us-ascii?Q?SyMsOCiprEB1iP/AM96csJXswDYE+lDIeWUd0jSuafev8gJRbl27b4nlnvri?=
 =?us-ascii?Q?z2p7+yO/jIXw4s9zjkOsAHIchRWw7YXQxiLfsoVxMQw+09FxZA01oC5XYIYy?=
 =?us-ascii?Q?NLhPJMqQ4Qicv2mihIfDNWfGK8gRCQdypKq2psoORRD7ntRo3zXU9aFZ99kg?=
 =?us-ascii?Q?Jb/KiWMDLvUjNWilUBT5rlwDVQ3q2AgpScZI2r+cX4CRoGcRuyD8QEKG/c92?=
 =?us-ascii?Q?g/x3Rfz3i8ZIbwZBEqTN+GaSejeaOmhXfUNKrkQ8eZEG8tukMMBhgzrlX/u6?=
 =?us-ascii?Q?O0/y+pL1J1+IOEQhJvq6c0bwRrAXq6JNr7PShXSR+0M2Sbcy1j6PKkvDzO/U?=
 =?us-ascii?Q?s66AkfH0w5VMXcRPDgx/qR683OnQv2cGxmn2ZBBXfSaGa0BTVCPttddhHYzU?=
 =?us-ascii?Q?hHn+lZj2b1VsAPc7IYNuuIO4ziivRy3hu04NN9In4oqZQ7cxT7aR7MM3RUD8?=
 =?us-ascii?Q?xvvM5/A7k1wM3qkUfVdnCxwTWfcUPx9XCx5ugKSOe72bfZeLGhE08xTZkTht?=
 =?us-ascii?Q?6T0N+7NOfGmzUpyLt36UR8ckex/JQRVlxEDUXo4N5lC3yaQkE8OEztj+Peml?=
 =?us-ascii?Q?Wl2DvrJrDSSRkrZ8/px9RXkJtuPRi+J3gHhzQ0/KLcBoczzomx06ukxBm3S+?=
 =?us-ascii?Q?zl8UDkw8imniDPJGR5BkZfK1u1v4DksHfS2j4ek9wocELp9XkiCX5mITysRW?=
 =?us-ascii?Q?8CXAVA0P2PKmtMR84Dfy+XkokG5g9WsuTHHFbE5PuN39tyC2Apblg+DZ0gnE?=
 =?us-ascii?Q?QswFsKB9x933QVdMiEGGB4iVxULbI2oq5ws3qNkJ2OydmpdQSlEQ/FZdBXQv?=
 =?us-ascii?Q?ZCzhCQ9LNHwGLMrjjJndXjXyHAEu+Ca13Sts0Ig30SksBzrXj4xrXBwRcwZx?=
 =?us-ascii?Q?SmXORYb25pHqPiclG4PHEaf+OXXSwqb9/6jTieDq0pPc7MADbbrSguufAYKd?=
 =?us-ascii?Q?W5oqGiJF2mmEIDSeY0uqQnCEqNQonXKOMEj0B7ZNnhmonlgivGrjqOQNHzJi?=
 =?us-ascii?Q?uhOtcz1ziW0wTL5UjvXSN8dIMyV2TcOTnSOVXtNgixXf91E3Q5FHX4yay9d0?=
 =?us-ascii?Q?Mxo5r6RraEbQI62UoA86QqgCLGnQnpkvaLMndfM78TpkkGKkezLrYfGfH0AL?=
 =?us-ascii?Q?oSi6Kiq5bgGqO1tc0stJ7/zxnEOr9MAP28+bez+PVh3enqZFcqa4guewlc75?=
 =?us-ascii?Q?7T0YQJLdby1bDhtXlWrKsNsxTKRwqo7A9xTNK63+b9No4mk58ontYajua/hw?=
 =?us-ascii?Q?EHGm3AOE+jOK2nGRjHBHF5PwQTUa9Ap9ICL68ZeTfmhhNWYUiqinJ/a1BlJe?=
 =?us-ascii?Q?S6NdBFBzM4hNwYBqEzmsbvNJ5MqA7mQK/p94ydIUROEwiU+jKfcTuiGEzuHU?=
 =?us-ascii?Q?U1ClkLLZOGfyWWtHa6fbYC/nrL7Jd568/vkpdAL9rngPZ8uRlwVmYATsGMXa?=
 =?us-ascii?Q?hOPFQmklJjp4mo/LyOqnlYajHV4RP7IKXz3xtLDWyAyoOXx7TzZoRzgkPePS?=
 =?us-ascii?Q?9huLDU43qUAG4G0xPTElepTZeoMwMyziYsJyu9KVc45Oge8SVX3Y6R16AHP8?=
 =?us-ascii?Q?fvC9HTRbZtiITnt4i2H4DrU=3D?=
X-OriginatorOrg: cyberus-technology.de
X-MS-Exchange-CrossTenant-Network-Message-Id: f4dee769-aa7d-4890-8267-08dc5e11dd0f
X-MS-Exchange-CrossTenant-AuthSource: FR2P281MB2329.DEUP281.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 12:36:39.8804
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f4e0f4e0-9d68-4bd6-a95b-0cba36dbac2e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /7UhVMmMGVk53/UTLYCOyASftyk+feDu5rUB4BGJXhyvJsQlXuLNKV5g7uuUNUzgXSBWKmjnwfQeTKtm8b4ot9osGUdSxHAS0Iytc8UYy5n6piYQVjXpHp3LLfvF0Nng
X-MS-Exchange-Transport-CrossTenantHeadersStamped: FR2P281MB1543

From: Thomas Prescher <thomas.prescher@cyberus-technology.de>

This explicit change of CR4_READ_SHADOW is no longer necessary because
it is now handled in vmx_set_cr4.

Signed-off-by: Julian Stecklina <julian.stecklina@cyberus-technology.de>
Signed-off-by: Thomas Prescher <thomas.prescher@cyberus-technology.de>
---
 arch/x86/kvm/vmx/nested.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
index d05ddf751491..e191bf5d4831 100644
--- a/arch/x86/kvm/vmx/nested.c
+++ b/arch/x86/kvm/vmx/nested.c
@@ -2639,7 +2639,6 @@ static int prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12,
 	vmcs_writel(CR0_READ_SHADOW, nested_read_cr0(vmcs12));
 
 	vmx_set_cr4(vcpu, vmcs12->guest_cr4);
-	vmcs_writel(CR4_READ_SHADOW, nested_read_cr4(vmcs12));
 
 	vcpu->arch.efer = nested_vmx_calc_efer(vmx, vmcs12);
 	/* Note: may modify VM_ENTRY/EXIT_CONTROLS and GUEST/HOST_IA32_EFER */
-- 
2.43.2