Received-SPF: pass (google.com: domain of linux-kernel+bounces-146809-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <654f6737-78bd-4aa7-bb35-84515d5fe3f4@intel.com>
Date: Tue, 16 Apr 2024 14:39:51 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC net-next 2/7] netdev_features: convert NETIF_F_LLTX to
 priv_flag IFF_LLTX
To: Simon Horman <horms@kernel.org>
CC: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
	<edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, David Ahern <dsahern@kernel.org>, Xuan Zhuo
	<xuanzhuo@linux.alibaba.com>, Andrew Lunn <andrew@lunn.ch>,
	<nex.sw.ncis.osdt.itp.upstreaming@intel.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
References: <20240405133731.1010128-1-aleksander.lobakin@intel.com>
 <20240405133731.1010128-3-aleksander.lobakin@intel.com>
 <20240415143728.GB2320920@kernel.org>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <20240415143728.GB2320920@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDVLV0xZYkFmUmdXd0c3a2g5YzloQUJsMjJFSVVyUXJBRzlCZ2djZWpSUU9r?=
 =?utf-8?B?TjhENjBRalkzbzB4NmRaWVNQbEhVMVlHcnlncWRwVW9GQmhGemtQWVpEZTRZ?=
 =?utf-8?B?R2pocnBJV3c3L21XVjc0VXhOYlFHenhMMTJPa0FEN1h5VHI1andDRFNnQzRB?=
 =?utf-8?B?dkFwV252QzF0NGUzODQxbFpkdTdhVGR0RFRJQmFPdEdZbmxYamhxcEdqT2ZK?=
 =?utf-8?B?b0toak8wK1ZZdjN5b0c0THVzekNnTzdmN1ZyLzVFcHVuT0hTZDkrUmhyRDlP?=
 =?utf-8?B?VVFSaXNheFVscGxpaXJLQnBSaDJFd3dndnU2NDRMNEpFczUxUk5EYWxiVTIw?=
 =?utf-8?B?dUgrcjh2TGZJcUN4Mlk4QTFlbURzZG1TaGhkMzNWZzVmWklxTlh4WFhmZW5O?=
 =?utf-8?B?eHArRTBaVXBGU3JSQmI3Zzl2TFpYN3FXVmhTOTFrdFEreHJwS0pnTXVzN2Ft?=
 =?utf-8?B?Q3RKdlRPZE9KM2xYSU9IcmxNU1hjdEYvVUlQRU1Ndzgyd1UyRDlscWQ1bVFQ?=
 =?utf-8?B?VmdJTEo1TU5rclhrSWxWMXFwRm1yaWw5MzdxUFAvUmRIRjk5bGRmdmN6SjFZ?=
 =?utf-8?B?a0thdjNLcXhOeXhVOU9tVndiRXczeDBvZUh3QVhHNVdGNUZIek5HSnV2aS9l?=
 =?utf-8?B?ZS8rT1QrL05BS05BRDdQQk1YNllIcGNmVHJiVDJ2eGFyUGg0QWlCTVY5N0R4?=
 =?utf-8?B?SytydWp3MmRoNGlpcHJNZVFSNUdHQ3NjZHc1VGl0M3pMeE40WTBoMmhHdVVM?=
 =?utf-8?B?bVN3SDhBR3NmWmFKcXl1SDBPeUNRenF4WjhFR3YvdEZxYmxGTDBSRUhGWUVD?=
 =?utf-8?B?U3EwcXp6S3lqcWtTN0lteHBqUHdpekpxWnN2eWdtc0Z4V0d1WXNBTE5CRXF4?=
 =?utf-8?B?bkhRRXorbE1EbTNwQmFLUzhYdC93VFhNVkI3TncwZFR5K2ZVTGZpdVgxSFor?=
 =?utf-8?B?aGlYa1kzNzlGUDRiL3BYRExBaGdaVWN5cjRmMjFldkJoRWxaSGRZcEdRck4z?=
 =?utf-8?B?ajErSE55Q2o5R1I4RE9jNHNCR0plZGEwYnp0TjFlWUl1RlYvVjVhaC9KODN2?=
 =?utf-8?B?b0oyR0UzanRDWnhQL0FBUEVQbHU4TFJVeERta1pMc3B1UkVabE14MG9HMjdL?=
 =?utf-8?B?SXhYY0cyVXk2MW9BRUpaU1lXT0YwNmJUUnBXelNLLzlFeDBGQkNqK0pEVXpm?=
 =?utf-8?B?RkNpRTIxY2UzYi9wU1RWcDhXajZFTnRMNmhldlFFS0NuODZGZGVjaC84WHl2?=
 =?utf-8?B?dmxpU3o5WWxkamlWNzBheFRrOWZ5NFRCaE0vdmtIaXMwVUJWVXJYOTBDclVU?=
 =?utf-8?B?Qmh4S20vd0xESU44STV4RERJZVJ2OHQ0akxaaFBEMmcwdG5LaWsya3VzL0RM?=
 =?utf-8?B?L2svQ01rRmJmdEJHbkJMWFZoc2NlV2N2UEhiaWtxUEw4UTBQUmVFd1RiNDRi?=
 =?utf-8?B?WGpqdHJwSFpZL2VaZGhHTHdYU0tTUXlIWFlYVXp6bkg4bmVOc1JNcE50VjI4?=
 =?utf-8?B?TjRrdFdWeDNnWnNmQzFuamxLSW5hbzNJWjFoMlA1VFBybDJyTGRYd1orUGcy?=
 =?utf-8?B?dGJ0VnFYbzNTKythcE1BbkcrKzhuNlIzdEx0WU5NMURvUXNIeU91MkJmRkcz?=
 =?utf-8?B?WWp0YWJ3eGY3aVA0cDdhMjlBNnNqd2d3NU13NTREZzR2MFFEcy9UL2FCdlVF?=
 =?utf-8?B?c0NHOHhyeVcxMnJnQVk4bXZkZHdiU0lBY3NEem9iNkpQUnpHVG9sbXA1azMx?=
 =?utf-8?B?Y1pRK2RkdWNnNkdaSHVKcUVOTGZ2N3VrTXhtbHBiZzJGa05TWFJrUXZDWm9R?=
 =?utf-8?B?cDhWK3JBY01sK2dkUHAzUmUrTlZSUEJwMmcrRzJMYVQ2aFlycnNGQy9NV2tC?=
 =?utf-8?B?K2VuaThzMWFkdmI0ZDNXR3dsN2ptS2h3ZEVaQWZvNlNnczhKM09HWWZYbEJN?=
 =?utf-8?B?ZXZjd1NsYXBTQ21FYlZVMlgyNm84d1pnY3ZoUnNwcGpVbFppOHJFQjZpb2NH?=
 =?utf-8?B?Y2x6dk56VTlkejBaYzFrdXpUOWs4SmtsR3NKQnZDd2o1OUNmZ2xEbnBjZTQv?=
 =?utf-8?B?NXdicVpjVUpjS3VjNVExWUsxN0JuRisyeUM5ZjhHQStSejROMENmb0p2cHNG?=
 =?utf-8?B?amtwelQ4Z3NodlpDM0ZGYkJPdGI3Zys1MnBqTHRDQXNwcTBXdDhFUDVoTVpo?=
 =?utf-8?B?aGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: eefe7ace-4c50-4588-5c21-08dc5e1251ed
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 12:39:55.9027
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: brUlA64i3oiZ8KJ2Zx1DoRUeORBIznSFU62wulTYBFw3sfIjgW2Au8mY+V2iCtwEfYEg1UFoI3/8t1DZtSBaSbEUaVk9tGH07FnkIRjADsE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8506
X-OriginatorOrg: intel.com

From: Simon Horman <horms@kernel.org>
Date: Mon, 15 Apr 2024 15:37:28 +0100

> On Fri, Apr 05, 2024 at 03:37:26PM +0200, Alexander Lobakin wrote:
>> NETIF_F_LLTX can't be changed via Ethtool and is not a feature, rather
>> an attribute, very similar to IFF_NO_QUEUE.
>> Free one netdev_features_t bit and make it a private flag.
>>
>> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> 
> ...
> 
>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
>> index 0c198620ac93..065dd68fe97c 100644
>> --- a/include/linux/netdevice.h
>> +++ b/include/linux/netdevice.h
>> @@ -1649,6 +1649,8 @@ struct net_device_ops {
>>   * @IFF_SEE_ALL_HWTSTAMP_REQUESTS: device wants to see calls to
>>   *	ndo_hwtstamp_set() for all timestamp requests regardless of source,
>>   *	even if those aren't HWTSTAMP_SOURCE_NETDEV.
>> + @ @IFF_LLTX: device supports lockless Tx. Mainly used by logical interfaces,
> 
> Hi Alexander,
> 
> Sorry if this has already been flagged - I thought so but I can't find it now.
> 
> " @ @IFF_LLTX:" should probably be " * @IFF_LLTX:"

Sorry, yes, I messed it up.
It's an RFC though, I fixed it already for the next sub.

> 
> Flagged by ./scripts/kernel-doc -none
> 
>> + *	such as tunnels.
>>   */
>>  enum netdev_priv_flags {
>>  	IFF_802_1Q_VLAN			= 1<<0,
> 
> ...

Thanks,
Olek