Received-SPF: pass (google.com: domain of linux-kernel+bounces-146860-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 16 Apr 2024 08:15:54 -0500
From: Rob Herring <robh@kernel.org>
To: skseofh@gmail.com
Cc: saravanak@google.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: of_reserved_mem: remove repeated call to get no-map
 property
Message-ID: <20240416131554.GA2105823-robh@kernel.org>
References: <20240412140938.137803-1-skseofh@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240412140938.137803-1-skseofh@gmail.com>

On Fri, Apr 12, 2024 at 11:09:38PM +0900, skseofh@gmail.com wrote:
> From: Daero Lee <skseofh@gmail.com>
> 
> In __reserved_mem_alloc_size, of_get_flat_dt_prop is called and checked
> whether the "no-map" property exists for the node. In
> fdt_init_reserved_mem, the only caller of __reserved_mem_alloc_size,
> we checked this again for the same node. Therefore, repeated
> of_get_flat_dt_prop call was removed and 'nomap' was passed as an input
> parameter to the callee function.

This code is all about to get rearranged[1], so holding off on this.

Rob

[1] https://lore.kernel.org/lkml/20240328211543.191876-1-quic_obabatun@quicinc.com/