Received-SPF: pass (google.com: domain of linux-kernel+bounces-146873-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 16 Apr 2024 15:24:31 +0200
From: Heiko Carstens <hca@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        frankja@linux.ibm.com, nrb@linux.ibm.com, nsg@linux.ibm.com,
        borntraeger@de.ibm.com, gerald.schaefer@linux.ibm.com,
        david@redhat.com
Subject: Re: [PATCH v1 0/2] s390/mm: fix improper use of
 __storage_key_init_range
Message-ID: <20240416132431.8615-A-hca@linux.ibm.com>
References: <20240416114220.28489-1-imbrenda@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240416114220.28489-1-imbrenda@linux.ibm.com>

On Tue, Apr 16, 2024 at 01:42:18PM +0200, Claudio Imbrenda wrote:
> The function __storage_key_init_range() expects the end address to be
> the first byte outside the range to be initialized. I.e. end - start
> should be the size of the area to be initialized.
> 
> This small series fixes two cases in which the last address in the
> range was passed as end address. This was still functionally correct,
> since __storage_key_init_range() will still loop over single pages and
> correctly clear the given range, but it will be slower than clearing
> the storage keys for the whole 1M block with a single instruction.
> 
> Claudio Imbrenda (2):
>   s390/mm: fix storage key clearing for guest huge pages
>   s390/mm: fix clearing storage keys for huge pages
> 
>  arch/s390/mm/gmap.c        | 2 +-
>  arch/s390/mm/hugetlbpage.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Heiko Carstens <hca@linux.ibm.com>