Received: by 2002:a05:7208:3228:b0:82:47:81bb with SMTP id cb40csp2624928rbb; Tue, 16 Apr 2024 07:08:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXJwC0o8ULaRQHubXP1tUtrbFXzWVF3SxV9+IKtts5vpEvMVL/30sFARAvgl9DgGhRJb0zePBUR69EY3CtQkinuDSSB9W/AiQYWDTAyog== X-Google-Smtp-Source: AGHT+IH/St4dCzucjrvx+BXPNv3NlLUA1VNrLjYORIR8sTYN67NyHQv1E0SPOeRJiWfISV2mPuT+ X-Received: by 2002:a50:9e4e:0:b0:56e:238e:372c with SMTP id z72-20020a509e4e000000b0056e238e372cmr9721584ede.26.1713276526904; Tue, 16 Apr 2024 07:08:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713276526; cv=pass; d=google.com; s=arc-20160816; b=gm7gLOfSmrh3m37iQe3ZKgcJHXVWl2l/7AtO0mc6BtX5bSO2nqvfSQH7q+WxQ0216k aNJi1M1FUCUMRq5xBi6FlAn6BWb9lTukkybGmMCics+lz/ucPsNWUWPnTbHCdFCzDBbq Kezgo8DftkCfdfX/o2pghIDohK5+KYf6VbfDmOxnRxxQ9D1ZAgy3VR8PLNrzGtM4TxB7 XpzJppp+v1O2FankS5uNpw9qUIYHkVR9WntvtOuEdRadLIypzpjPy0vw7yZowjvh/5wu 6XNSE8jZD9b/IRgfIqWq6mfxAkhMugJaIFb0ZJ+Cv11QwOaqKtrRNOfqS/6fKliVc42A jdsg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=t1+UhjWTOoYQbySduaUDvzXLNvMmIdKBxUHuSuBP5+k=; fh=QhvImkUQAq77xqRPHMvQJGtyXv+df3cJP1fNOzP9Z9k=; b=WWYSDs546iEdCleRMlFb2KMtimXd4tWuZ7fyEtzcgsocxlOIxHF5NxP2wlxrHwAcGw TLvsYBX5q0BDE7GFr3sP/16nGeKoxt5FRWOGtJvbC8mr5UTL4TD5a2dWfM8+yt0x8Byy xtK8fuH+05buSh2IBvfn6T5bBlIAl1Qk07aEHIb/+lp1Qm5pE1rkE8VryYbFHMVASLIQ QfFwGRAbNcqlZJXUsavmmkPiHbQKbpD0SwR8Ov2PBNDbEjt9waIhmIuY2OePUcTRB0h5 M3vqXhPmfQpia+UN8ijPy6Zss9eC7v/AWxSGzT76uOIO0CNM0GhSgZ7I4B+XdnwT5pO/ u+Ow==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RXd2NkHS; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-146945-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-146945-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id q26-20020a50aa9a000000b0056e43160cb4si5597363edc.410.2024.04.16.07.08.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 07:08:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-146945-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RXd2NkHS; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-146945-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-146945-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 630B91F21BA9 for ; Tue, 16 Apr 2024 14:08:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C89E012EBC5; Tue, 16 Apr 2024 14:07:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RXd2NkHS" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E31FE12E1C5; Tue, 16 Apr 2024 14:07:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713276469; cv=none; b=diW4Vbw+H+m+GwGSf3D1cXYXT3VV7k6kTV1m29jIj4XlGRZimJ8/yqsv5Ac6DFPy78mEvz4oj/8TDPmihbceVGFwc3bJtRnlp6YonNyfJYXozglHtRssQhP2xEilCduI736XJwzFK6NoJ8vBtoD7yMGWePTlRwPzhA00cIYu9H8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713276469; c=relaxed/simple; bh=5yq4csUG5rBzT+UQdA0n4IvddA9o380zAC421EEiAGI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=syN2CzFuDl4UjFVNVCO5Z2U54PQmxFj6NYslceRV4fPtUOET7Y8hX1ZC1n5aCxT4AHPKAOP3aycWPcA//ShzJEzp0B9ZP707hQ7sIpHh2PZpQgdBHmMR33KNIm/X6qv0xc2yPby3/oK+/1xEeibG7cON9QoiguudcFnNblCNUcc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RXd2NkHS; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3CEEC32786; Tue, 16 Apr 2024 14:07:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713276468; bh=5yq4csUG5rBzT+UQdA0n4IvddA9o380zAC421EEiAGI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RXd2NkHSyi6ASW+ZFU0qZIh2V3/ntZeOJG3e2ogSwftrnp8cPKYdTanuUoAaK8tjw W3TeSTJgmcQqACtP7B/ERTGkfCDZuZFfHldIUtb+gEfDAPx5gVsLjIuFXP4eF6uAJa ClMAmc5TBPV11RXDUe3hKUrLCM+6XExKO1P+nzlq5TDh7yFD7sCIS+BIBi0Q6tm7r5 InseEYL6db28k6kD4vwa4tVz2sV4dqxnegin7KhAynB31gQfysBQFYtmEVoC+7mScc bg5azoxGxLzEHDLG7nQ7c3SBGPrp9JgxbcTn/Eaaq0NB7Miqa0nG9cBZElv9Pp3ujK d5F1NWeWN2Pug== Date: Tue, 16 Apr 2024 16:07:43 +0200 From: Andi Shyti To: Chris Packham Cc: Abhinav Jain , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "skhan@linuxfoundation.org" , "javier.carrasco.cruz@gmail.com" , Julia Lawall , "linuxppc-dev@lists.ozlabs.org" Subject: Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup Message-ID: References: <20240415161220.8347-1-jain.abhinav177@gmail.com> <2ea08951-3613-4ed5-a2b2-dd4887105ac3@alliedtelesis.co.nz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2ea08951-3613-4ed5-a2b2-dd4887105ac3@alliedtelesis.co.nz> Hi Chris, On Tue, Apr 16, 2024 at 03:59:13AM +0000, Chris Packham wrote: > On 16/04/24 08:54, Andi Shyti wrote: > >> /* Enable I2C interrupts for mpc5121 */ > >> - node_ctrl = of_find_compatible_node(NULL, NULL, > >> - "fsl,mpc5121-i2c-ctrl"); > >> + struct device_node *node_ctrl __free(device_node) = > > How have you tested this? > > I'm not sure I know anyone that still has a mpc5121. Maybe someone on > linuxppc-dev? that's why I was asking, this would be the first driver in i2c using Rob's __free(device_node). > I did try to take the patch for a spin on my T2081RDB but I'm having > some userland issues on it for some reason (unrelated to this change). > The kernel boot does discover a few peripherals hanging of the I2C > interface but I'm not in a position to offer up a Tested-by and I've run > out of time to debug why my board is unhappy. Thanks for giving it a try. Andi