Received: by 2002:a05:7208:3228:b0:82:47:81bb with SMTP id cb40csp2625252rbb; Tue, 16 Apr 2024 07:09:13 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWo73Vj05bEi5jXVBz+mfyqwA2A1xXXYpTNa6QxcEVLrXnivOvIWW+TEo893SsQb2VHuuLXsalf1lVYKOvpbRgydUO5srh3aoY5hSdhGA== X-Google-Smtp-Source: AGHT+IH5ftRwet8ixUYUs8xrh4XIlijzg43M0fjsWA/o3SCXsUozRco+y8XjaOK1EwBal8EUBKj1 X-Received: by 2002:a17:906:c309:b0:a52:4246:94d1 with SMTP id s9-20020a170906c30900b00a52424694d1mr6082797ejz.7.1713276553771; Tue, 16 Apr 2024 07:09:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713276553; cv=pass; d=google.com; s=arc-20160816; b=pDmT0jn8nvAPfHt8TGJWmqIRe7NiNkEemmN6yzEaNM5bd3Gw8SS5epQum/k44Qq1+4 CtG9r+PRbcy/Ez3XA00KOONPUFGEhirkTXVLYgEl0gX6nZBYYVKzYaHJTQrGhf5X5Z30 d4QnYbANpcrPaSUGrgMYG0besGQgGvALGYKgGxENm+OU9dhvqUGQ3vsXk/R7fmmIag7F T/quWomwq9V6pPBKra3+5bCRRBHk9JwQ1OdZiZ223Qxr5W/o0uMVGRWWoCklpi9H6+qO d+xNEl9gC9l/BZrR96J3vKQu6yUrL7r1kU4/Z22ktmBndPpIgFhgAOJBGL/lXyJBYKtM SgdQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=dIRTTkT3cw6U74A/Bg1W4mZI/rGPRqJizSaZBDh3Gm0=; fh=QhvImkUQAq77xqRPHMvQJGtyXv+df3cJP1fNOzP9Z9k=; b=SDNrAufckgn5PS1qfRj4AxX4KEEU5d8Txvlc04eKMuXHOpWYslYZ/HdmO6OCpjfTio L3B9V1ouICaEDXiJVKiW2giJOI8y+CHv6EbVSFPsfjsKT5LRjXx6Uh3JjvH+JlIcsUAu RDDToVGG+G4qBHkQSzrfaM1sJ7uY3adnfx3zvcx9FnOvTI42RChqu8iUoWnHmC7Lagjk kVmTKVQICF+FxzLwFXIExCU56ibhQ2HzCQudArO9OviNeMfSEb3DlsIGFceI/8lv2EvE y+nJJha7qV6cUzlkMnuEIZQYqxAPcoIuD2fF9Rayir0a+3eGlCDvhGIYdGZFQnKeedpE Gi9Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vJ+6c1nm; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-146947-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-146947-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id x19-20020a170906b09300b00a51e4539384si5975176ejy.773.2024.04.16.07.09.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 07:09:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-146947-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vJ+6c1nm; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-146947-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-146947-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 864EF1F21BA0 for ; Tue, 16 Apr 2024 14:09:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4AD1612CDB0; Tue, 16 Apr 2024 14:09:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vJ+6c1nm" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B5E612C534; Tue, 16 Apr 2024 14:09:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713276545; cv=none; b=L8UdPSOVqi7WZTMMEpyHUuFdgblEvkm2bV96lvnmh3neXqGkf/huwVYEvdGkTXPfAZ4DSCtB6qlKglc3Qn+eQ90Id/b0omaZ8rYwy4wv2qyVNrQ4eaccWjE+ePApcDnbNwQPXnWEFTl8gdOXVRuWN0VXYwluSBdpCjBU946wNrg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713276545; c=relaxed/simple; bh=ztYAfRqyCAO4TihC8giRcF/Rn09DqX63ao2fuDHUQw0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kVKV4dMMYDl57NHNWDExkfkIVc8CTvuth4eELvIh1it3rNNKvXI1S1Lp9fHEs4G14GtQpwHjhvdgcabHH5BttdxTlFB8m1BUMSIsCA1ScrPwce9K2jofggE0fWnE8BKPmFo1Yyi+MVRECHSDAj21TsWW/NXpHFg/7Yu99QQatZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vJ+6c1nm; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FB11C113CE; Tue, 16 Apr 2024 14:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713276545; bh=ztYAfRqyCAO4TihC8giRcF/Rn09DqX63ao2fuDHUQw0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vJ+6c1nmWW33jynK9xJcmJix7xN9eJXDw9YZXIlotYkpCMvOe4Hz06JcAopp+ESCC TRcx5jYGQ5+GTwyxMZjuYQyLCcfn6Q6g90hYYEMaIwgZJ1EKJI18PSsT+CcdgCKBPP ckNB0R3kvGQVz1kWzQN5c6OFcd6ozWBU5KmMBQ4sSwm26ClhcOo+PtxMzFXFB2KLby EaOShXvLC4lv2fNdsGCtXQjuc/HIqF7g/iXvKneJgvstUzwtKIdwUfewhmBn/+dB5C xFedLa5tmj4cZwHMvZP0TC2XNSHxymDJts1tHD/RVaN3mku46MZp/ptcPw2lDvzuoP 3/bEFoWIdQY4A== Date: Tue, 16 Apr 2024 16:09:01 +0200 From: Andi Shyti To: Chris Packham Cc: Abhinav Jain , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "skhan@linuxfoundation.org" , "javier.carrasco.cruz@gmail.com" , Julia Lawall , "linuxppc-dev@lists.ozlabs.org" Subject: Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup Message-ID: References: <20240415161220.8347-1-jain.abhinav177@gmail.com> <2ea08951-3613-4ed5-a2b2-dd4887105ac3@alliedtelesis.co.nz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Apr 16, 2024 at 04:07:48PM +0200, Andi Shyti wrote: > On Tue, Apr 16, 2024 at 03:59:13AM +0000, Chris Packham wrote: > > On 16/04/24 08:54, Andi Shyti wrote: > > >> /* Enable I2C interrupts for mpc5121 */ > > >> - node_ctrl = of_find_compatible_node(NULL, NULL, > > >> - "fsl,mpc5121-i2c-ctrl"); > > >> + struct device_node *node_ctrl __free(device_node) = > > > How have you tested this? > > > > I'm not sure I know anyone that still has a mpc5121. Maybe someone on > > linuxppc-dev? > > that's why I was asking, this would be the first driver in i2c > using Rob's __free(device_node). Jonathan's, of course :-) Andi