Received-SPF: pass (google.com: domain of linux-kernel+bounces-146956-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 16 Apr 2024 16:10:07 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Kamil =?iso-8859-1?Q?Hor=E1k?= - 2N <kamilh@axis.com>
Cc: florian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
	hkallweit1@gmail.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: bcm54811: add support for BroadR-Reach mode
Message-ID: <3aaf1b82-247e-447d-a39c-c209105c2d7c@lunn.ch>
References: <20240416123811.1880177-1-kamilh@axis.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240416123811.1880177-1-kamilh@axis.com>

> @@ -258,6 +257,9 @@ static const struct phy_setting settings[] = {
>  	PHY_SETTING(    100, HALF,    100baseT_Half		),
>  	PHY_SETTING(    100, HALF,    100baseFX_Half		),
>  	PHY_SETTING(    100, FULL,    100baseFX_Full		),
> +	PHY_SETTING(    100, FULL,    4BR100			),
> +	PHY_SETTING(    100, FULL,    2BR100			),
> +	PHY_SETTING(    100, FULL,    1BR100			),

Please could you explain the name convention. IEEE puts the speed
first, then some letters to indicate the media type, and then a number
for the number of pairs. Why is this not followed here? 100BaseBR4?
100BaseBR2? 100BaseBR1? Are these names part of the BroadR-Reach
standard?

Also, is there any compatibility? Are 100BaseT1 and 1BR100 compatible?

      Andrew