Received-SPF: pass (google.com: domain of linux-kernel+bounces-147013-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Paller, Kim Seer" <KimSeer.Paller@analog.com>
To: Jonathan Cameron <jic23@kernel.org>, David Lechner <dlechner@baylibre.com>
CC: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Lars-Peter
 Clausen <lars@metafoo.de>, Rob Herring <robh@kernel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Liam
 Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        "Hennerich,
 Michael" <Michael.Hennerich@analog.com>
Subject: RE: [PATCH 3/4] iio: ABI: add ABI file for the LTC2672 DAC
Thread-Topic: [PATCH 3/4] iio: ABI: add ABI file for the LTC2672 DAC
Thread-Index: AQHajbcKs5B1Nn+D30OGOqPbvuOG+7Fq8qXA
Date: Tue, 16 Apr 2024 14:18:23 +0000
Message-ID: 
 <PH0PR03MB7141B4F4DBF3D77F7384B555F9082@PH0PR03MB7141.namprd03.prod.outlook.com>
References: <20240412032102.136071-1-kimseer.paller@analog.com>
	<20240412032102.136071-4-kimseer.paller@analog.com>
 <20240413162640.77c6fc56@jic23-huawei>
In-Reply-To: <20240413162640.77c6fc56@jic23-huawei>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?BGscGLpfcgoCIKtVXa14swgj/L5SjT4HSmwrJu2LTSqzUQMlmaAACdhYUlNZ?=
 =?us-ascii?Q?Wqbf1iDPGkc0Yn/5SHREErqhRTjvEJKg6nI7bR6gr9YH0l3QE1hYBCCYWiQJ?=
 =?us-ascii?Q?Ireqe2Zgs8QQO5inbIFN2oR1G24NnN020M8JtC8znjjQ0jG/sGayJDp0phGq?=
 =?us-ascii?Q?Ibpg1CqqI+vxpknmDvHn3a96nZeXlHv/BMN19xsxCoPfmTrXjVFOfsrzlSS6?=
 =?us-ascii?Q?RJV+J6zKvwfrl+MYu1Jzhf7WcXtkWoRJyC/3ciT7Sqmrjmov/Qk+z7hWiY7C?=
 =?us-ascii?Q?/bYO8JqJx1Zlo7FEpDE6/+XwRGlYCdHpxWWyL6uRSN5y3rwa4/u9UncHObyy?=
 =?us-ascii?Q?Nb3O0uSFdINgHpBYe/hXAjqIrgjla6UyKI0gKXJhwFSkCarD3LwUjInWKA8S?=
 =?us-ascii?Q?AG+USPBQBTCpeuKPZFxTUhKdRybGX3qmDHB+FuHdqck8QEc2xBStOwWkDzcj?=
 =?us-ascii?Q?qwD5qx7KOHbUl+L0ILyGFH/lOO0pubI3D2ldjXfSkF1sirUXXsecjyBnctpI?=
 =?us-ascii?Q?l+egB5HUm48ZLkaXOLU8yQ11vUkl1EEX5AfQd8/rTh6I50B3/TtGf/skLV4P?=
 =?us-ascii?Q?7208Usu/JwMAntdAU7hguElFL5NB7GAaDDN5YQ2u3mYJ52T/v1OsIhkjuQ00?=
 =?us-ascii?Q?e2sajPT6rDuRWPpLaPLGDk5f0aIvLfF2DYMYGxh4gomAbfRnG24jJMdAv6oU?=
 =?us-ascii?Q?PjRxokxt5FgqTnoFFWUtPFiDAxmmRyDiCXTKXMvRlGLkiCDm7CSUeO7TvyJZ?=
 =?us-ascii?Q?Fj9GU3pniZJ/WzXBfWrvI0qGJVrB3vujXLDeuB2TO0xZgVShUtClRUMiQOi1?=
 =?us-ascii?Q?dTe96t+4cK0HpszV/0+8YnlYayoR589RLoWz4UX8BGZ//reimSuXWioXMEm8?=
 =?us-ascii?Q?93/3T18fF8KTB45EhQBzDAdJJuCPXK8r0NET5ItqgrOLNAcFZD0rDswPCOLC?=
 =?us-ascii?Q?2ARTDUSJGVyrfm3MbF6A0QYURqBeTHO5U4ddJqbrhTnCtp4FVRJhgBt5RwAX?=
 =?us-ascii?Q?2yoU3mISeJw1B5invmJX5zblMxrIFJ1tWr2dB7FDosPkzTxMQvzU3HFt6bGU?=
 =?us-ascii?Q?5WenHeDuxzTQrVkfDh0Xb6AzvO/JYV91QNleyohtOx5aV4/81lSX0TW2+lJh?=
 =?us-ascii?Q?6dT1XKwoLyOsVlb0KfJHeiTCIP5JqZhiWKK7Oqnpe7a+LTdFcBOtZojE9fDC?=
 =?us-ascii?Q?Sx1SRW2K47hKM1smrXyNEdNce1hjhqG5vBInhYiX/aCGbdtLVRI0ZB3evtvT?=
 =?us-ascii?Q?pJn5Eoc6eKBw/kquQPTaB2HkpWKNPk7mugPZ9X8BvnChpIbXaceE9LF+mR1J?=
 =?us-ascii?Q?Ag5xCFYLXIUpVu0IKefuSZ3ALoEZKL5v5ZVBFv4nUwkd+0Mk/E41vAYudLrm?=
 =?us-ascii?Q?/ugxaVkTtszu1mPj7HkpYx2alYLTh7XXBQD2kdNDxs/kz2fwuoWWX308SOGs?=
 =?us-ascii?Q?RKw2NgM+GReTwt8KlPpJRq6V3DaU347Krj9wcqlSdgEWo9+hanwq2lf6Ah9F?=
 =?us-ascii?Q?jTTq2yp/eql7c0YjS/kDN+1jt5mmAj7Q88nIloVOQzRzxnhPJ9N1pij1Lh7D?=
 =?us-ascii?Q?uIdFlUpeyTSaOWGlqDA8m/1/icIMtAzVRW5fqZye?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB7141.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8bc1723a-3da1-4d09-2a9a-08dc5e201355
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2024 14:18:23.5811
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: flk5FfstUr1hDmJf+AtaquJFRLTh4pcGJVx3/K8HIX23OS3Mnd9hCpmNgFiaU5PxqrwiAatOsXRTumYh/Cv18td0Ny16lKZ8RvOZhwwexWc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5544
X-Proofpoint-ORIG-GUID: LX_zAEL1TVEI0nBe2WL2-TsrCT7r2gzH
X-Proofpoint-GUID: LX_zAEL1TVEI0nBe2WL2-TsrCT7r2gzH
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-16_10,2024-04-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015
 lowpriorityscore=0 bulkscore=0 adultscore=0 impostorscore=0
 mlxlogscore=999 phishscore=0 malwarescore=0 spamscore=0 priorityscore=1501
 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2404010003 definitions=main-2404160086

> -----Original Message-----
> From: Jonathan Cameron <jic23@kernel.org>
> Sent: Saturday, April 13, 2024 11:27 PM
> To: Paller, Kim Seer <KimSeer.Paller@analog.com>
> Cc: linux-iio@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; Lars-Peter Clausen <lars@metafoo.de>; Rob Herring
> <robh@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org=
>;
> Conor Dooley <conor+dt@kernel.org>; Liam Girdwood
> <lgirdwood@gmail.com>; Mark Brown <broonie@kernel.org>; David Lechner
> <dlechner@baylibre.com>; Hennerich, Michael
> <Michael.Hennerich@analog.com>
> Subject: Re: [PATCH 3/4] iio: ABI: add ABI file for the LTC2672 DAC
>=20
> [External]
>=20
> On Fri, 12 Apr 2024 11:21:01 +0800
> Kim Seer Paller <kimseer.paller@analog.com> wrote:
>=20
> > Define the sysfs interface for toggle capable channels.
> >
> > Toggle enabled channels will have:
> >
> >  * out_currentY_toggle_en
> >  * out_currentY_raw0
> >  * out_currentY_raw1
> >  * out_currentY_symbol
> >
> > The common interface present in all channels is:
> >
> >  * out_currentY_raw (not present in toggle enabled channels)
> >  * out_currentY_raw_available
> >  * out_currentY_powerdown
> >  * out_currentY_scale
> >  * out_currentY_offset
> >
> > Co-developed-by: Michael Hennerich <michael.hennerich@analog.com>
> > Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> > Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
> > ---
> >  .../ABI/testing/sysfs-bus-iio-dac-ltc2672     | 30 +++++++++++++++++++
>=20
> You can only have per device ABI defined if that is the only user
> of the ABI.  That may actually be true here but given I've asked you to
> generalize
> the voltage equivalent, I think we've shown this is general enough that t=
he
> current
> version should also be raised to sysfs-bus-iio-dac

I'm still getting familiar with ABI documentation. If I understand correctl=
y,
generalizing the documentation to cover both parts would also mean we remov=
e
the overlapping sections from the ltc2688 ABI. Is that the correct approach=
?