Received: by 2002:a05:6500:1b45:b0:1f5:f2ab:c469 with SMTP id cz5csp19753lqb; Tue, 16 Apr 2024 07:44:48 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVDdlApCUVZDxX8Ff6nRIY/N/Myq6qhc6GUqG6QCR/8+hqZPvIZyyv3pHOb1x3v2NV4zxJmCNEXvcBqUSrrNGufjx3CYZQ24IBR0bYjRQ== X-Google-Smtp-Source: AGHT+IELd7hvYFNYWpEFaRdHDUyFIjlYoPUuPqGB2ARZzLu1K/iHANTg8DyGN9agIrtz+XQE5mQX X-Received: by 2002:a17:90a:a891:b0:2a5:d301:8df8 with SMTP id h17-20020a17090aa89100b002a5d3018df8mr12033176pjq.34.1713278688254; Tue, 16 Apr 2024 07:44:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713278688; cv=pass; d=google.com; s=arc-20160816; b=GxfFRJEgFrbrmCT9vX/0GljGF6zxOURFqLOCEX6f/HHpfMLKMFMH4CqGW8xfoipZFr z/8JhTOARftEDetf4OU/k6RzL0yyghLlPyJOVIIkUUjtRdLLuBpWPVPmIj66VYTV0t7Y GQoZJFM0eb+HfCDi9eVgeJYCz4YCoH+QDtYU3aqeeonxC+ENkAtARaiNPZnXGxmaT0oP R4QXlVbAvJhQ6d+aB58ht5t8iAImWGfNcRkMkZO4/peSJ8GDVpJIcCnr75opMlSmkSGh tpdWWUYRtdfd2bYiCjj7a88xezRpoYZQgPpHO7x2SQ7UAIFllLlo0joqg8PCfMp0kG0S Npkw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=yWPju8bFKzHPmEvi9VdCj/VzG3eSDCsEdTAMlP9wmho=; fh=KsS/tyS895TpQnEJ/zSJLDUfvMb/m6LJX/ZMCYU1cZg=; b=Txx6rySYL7QiZwve1eeg9z+bIQ40aj+8j2UcmwpYNO2/iyyx+UPXJDA3GKd6PUdt2Y doQhbZpGE10nTu4KnjorfupJ8B1Q342N74RITf3RouWNLeyezFt1w3rLOdw41ZFbZjIu CCfFbDERl9AoRe7ePHPggbcromYa9g374GNpmPf3X4ihiPbyYWusAPjNKx55ARFDNRa7 toR3re3dOxTdL/lQg5TE8AZFcEk/7szO86jlU07ISIwgKm3I07oCF+RfJqL4va8Zc7pH u4A9v8JMHn7g85rLZddhvHhWEgsldrHRmp3Ft9qgPCMAjTioPTqR7j87z62HwgBzpG14 hsPA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@fiberby.net header.s=202008 header.b=Xgb85BgK; arc=pass (i=1 spf=pass spfdomain=fiberby.net dkim=pass dkdomain=fiberby.net dmarc=pass fromdomain=fiberby.net); spf=pass (google.com: domain of linux-kernel+bounces-147047-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147047-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fiberby.net Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id y14-20020a17090a474e00b002a53c6625b5si9752982pjg.21.2024.04.16.07.44.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 07:44:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-147047-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@fiberby.net header.s=202008 header.b=Xgb85BgK; arc=pass (i=1 spf=pass spfdomain=fiberby.net dkim=pass dkdomain=fiberby.net dmarc=pass fromdomain=fiberby.net); spf=pass (google.com: domain of linux-kernel+bounces-147047-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-147047-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fiberby.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BC3152843CF for ; Tue, 16 Apr 2024 14:44:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 80F3A130A4A; Tue, 16 Apr 2024 14:44:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b="Xgb85BgK" Received: from mail1.fiberby.net (mail1.fiberby.net [193.104.135.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66B1512E1E4; Tue, 16 Apr 2024 14:44:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.104.135.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713278654; cv=none; b=gPS0ErDN+lc6IyCzQTOXvGwkXE7bHddZIoNPoNQHjtGvO6FY7AKp/HGicGh8f13cdk3hu+u+DdNQa4zkLYLSgdYvTnFw/Qc7pjVytFdbC7jGDwgxskeCELDWHrjji324WQWc7/iOiPS8EEIXdIKRRbnLDfYfY2VC/hVgSBFhlJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713278654; c=relaxed/simple; bh=5BwHBYqxMFeIngfy155cTEhlu7ALrPnplvMVvaMfee0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=c6MTUoQXmlcc9WD6Mxx6XMEMzOFrxpa4R98ihslnbDlTqLOqBe9NndWlbPAJoz+tBTluoTjIh9obJlsPJt1qaINNKrjZoTX86fnwsWxv7u1fkav4eOQWRw70YlczUQHmiVXWYE+rKHHfKbcWH/LbtpZh1pcLkvOnc3FlsPtaNXo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net; spf=pass smtp.mailfrom=fiberby.net; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b=Xgb85BgK; arc=none smtp.client-ip=193.104.135.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fiberby.net Received: from x201s (193-104-135-243.ip4.fiberby.net [193.104.135.243]) by mail1.fiberby.net (Postfix) with ESMTPSA id C7327600AF; Tue, 16 Apr 2024 14:43:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiberby.net; s=202008; t=1713278649; bh=5BwHBYqxMFeIngfy155cTEhlu7ALrPnplvMVvaMfee0=; h=From:To:Cc:Subject:Date:From; b=Xgb85BgKLWsdRhM36K3eRzcf4c9sMeZX5xgUX0gQUPqGHoy2FUs/6nFwcqiQwx/0e izTYlD7ipM+2kp9dWZfiJfbhUlIc1N8Ec26EjadQUwcNQVp3uAG+Hg97/Qm/Wg1+xb BLURF7GjjF7V2qn7U/8HD93L3sVmancpYp1/AtXCWpPj4w/4GF+1RIIjYs//9yRtFS TlqqtjUwS5HcmYgKCzetYA5plB3rj4D7lMMRQeS1wi3JMtnsTkh1KORyiR2DIAHnY0 oJ8evaBerEj6DPiis11bO/+rIYju6KBSWG9XEX4i9Di83kGkUEpEM9o9y6RXkT/5ri 7JsOZ3Nnt/hUA== Received: by x201s (Postfix, from userid 1000) id 3185F203455; Tue, 16 Apr 2024 14:43:27 +0000 (UTC) From: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= To: intel-wired-lan@lists.osuosl.org Cc: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jesse Brandeburg , Tony Nguyen Subject: [PATCH iwl-next] iavf: flower: validate control flags Date: Tue, 16 Apr 2024 14:43:25 +0000 Message-ID: <20240416144325.15319-1-ast@fiberby.net> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This driver currently doesn't support any control flags. Use flow_rule_has_control_flags() to check for control flags, such as can be set through `tc flower ... ip_flags frag`. In case any control flags are masked, flow_rule_has_control_flags() sets a NL extended error message, and we return -EOPNOTSUPP. Only compile-tested. Signed-off-by: Asbjørn Sloth Tønnesen --- drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c index 13361a780ece..f14355d52f47 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_main.c +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c @@ -3757,6 +3757,10 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter, flow_rule_match_control(rule, &match); addr_type = match.key->addr_type; + + if (flow_rule_has_control_flags(match.mask->flags, + f->common.extack)) + return -EOPNOTSUPP; } if (addr_type == FLOW_DISSECTOR_KEY_IPV4_ADDRS) { -- 2.43.0