Received-SPF: pass (google.com: domain of linux-kernel+bounces-147093-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Subject: Re: [PATCH] bpf: btf: include linux/types.h for u32
To: Jiri Olsa <olsajiri@gmail.com>,
 Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, haoluo@google.com,
 sdf@google.com, kpsingh@kernel.org, john.fastabend@gmail.com,
 yonghong.song@linux.dev, song@kernel.org, eddyz87@gmail.com,
 andrii@kernel.org, ast@kernel.org, martin.lau@linux.dev,
 khazhy@chromium.org, vmalik@redhat.com, ndesaulniers@google.com,
 ncopa@alpinelinux.org, dxu@dxuuu.xyz
References: <20240414045124.3098560-1-dmitrii.bundin.a@gmail.com>
 <Zh0ZhEU1xhndl2k8@krava>
 <CANXV_Xwmf-VH5EfNdv=wcv8J=2W5L5RtOs8n-Uh5jm5a1yiMKw@mail.gmail.com>
 <Zh4ojsD-aV2vHROI@krava>
From: Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <ddc0ac5b-9bd4-f31a-a7ec-83f7a10e6ab1@iogearbox.net>
Date: Tue, 16 Apr 2024 16:47:38 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <Zh4ojsD-aV2vHROI@krava>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit

On 4/16/24 9:28 AM, Jiri Olsa wrote:
> On Tue, Apr 16, 2024 at 08:27:21AM +0300, Dmitrii Bundin wrote:
>> On Mon, Apr 15, 2024 at 3:11 PM Jiri Olsa <olsajiri@gmail.com> wrote:
>>> lgtm, did it actualy cause problem anywhere?
>>>
>>> there's also tools/include/linux/btf_ids.h
>>
>> It caused the problems exactly in the file
>> tools/include/linux/btf_ids.h and was reported in
>> https://bugzilla.kernel.org/show_bug.cgi?id=218647
>> The patch including linux/types.h in tools/include/linux/btf_ids.h is
>> already there https://lore.kernel.org/all/20240328110103.28734-1-ncopa@alpinelinux.org/
>> I also faced the same compile-error of the form
>>
>>      error: unknown type name 'u32'
>>                                u32 cnt;
>>                                ^~~
>> when compiling the bpf tool with glibc 2.28.
>>
>> I think it might be reasonable to add the inclusion in
>> include/linux/btf_ids.h as well to prevent build problems like this.
> 
> ok, it's in the bpf/master already
Please add the error description as motivation aka "why" into the commit
description, otherwise it's not really obvious looking at it at a later
point in time why the include was needed.

Thanks,
Daniel