Received-SPF: pass (google.com: domain of linux-kernel+bounces-147102-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <8a1b16c0-9897-bd10-b6f7-b428292c8c9f@amd.com>
Date: Tue, 16 Apr 2024 10:17:33 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Content-Language: en-US
To: Dan Williams <dan.j.williams@intel.com>, linux-kernel@vger.kernel.org,
 x86@kernel.org, linux-coco@lists.linux.dev, svsm-devel@coconut-svsm.dev
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>,
 Peter Zijlstra <peterz@infradead.org>, Michael Roth <michael.roth@amd.com>,
 Ashish Kalra <ashish.kalra@amd.com>
References: <cover.1711405593.git.thomas.lendacky@amd.com>
 <9615e6055e5b262a22bf312608647223517595b5.1711405593.git.thomas.lendacky@amd.com>
 <661e04966c622_4d5612946d@dwillia2-mobl3.amr.corp.intel.com.notmuch>
From: Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH v3 09/14] virt: sev-guest: Choose the VMPCK key based on
 executing VMPL
In-Reply-To: <661e04966c622_4d5612946d@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TmpzaWs2M3ZjdTMzTDIxZXFEVGY2cEM0UnptR1BqaVdBZ3JhTElLT2NDdkRV?=
 =?utf-8?B?dE1lUWJ2eHEyT05MY0lBQVBuMUJ0L0QrUGpuSFRSSXFYRXN5WVRRNVEyYzl3?=
 =?utf-8?B?aEh5dXp6Y0ZsUkJEWlVRVi9VbXhoMG9VZnVNTFhlV2o2NmMvTjJZVGlyNUx3?=
 =?utf-8?B?Q2xDS0JDV3lUWnZnZTJGaWJZWndjSDUzZjROeWllM1R6SjZ1UDNiUENQRW8z?=
 =?utf-8?B?ZlBCVEcyalB6Z3AyUldrd0JZRDBVNFFXWktNTTRvNkQ3RWtya1BoTE1oa0l2?=
 =?utf-8?B?cDVtaUM4Nkhra2RJVzMzdGtVendPck9vZUl3V05OUWxweitiT0g5U1BhTFNX?=
 =?utf-8?B?ZWdXSWJkSkhtRWNZZ2FFZWtjSDRtQ1gwVEtjNjBwdUd0dEFOekxoVWhaUjlh?=
 =?utf-8?B?ckNlLzY0RXM3a2FYc0tDaHNRR0tubXhLR295K0dIbnNFYlNLbXBTdW1zTkov?=
 =?utf-8?B?OHJWRHZ3WldkUU82SmRKczZ5R096MExGL2JJSGdwOEVrcW8zb2ZBQlp5QlBO?=
 =?utf-8?B?Smp3L0M2T0wrYXZuZnQvcUF3ZFNZY0UyQ0RDTkNBbjlkRTN3V21TOEg0TzhF?=
 =?utf-8?B?aDRpK0g1YzJYZnlZS0ErckNtQ0ZUT1V5SmszOHRLRld3OVpWWktUWDFkMlVD?=
 =?utf-8?B?K3dRNnppL1NLWjNNZjhpcERIQWFBbmlWdDlOSm1sdVBHQTJ4d1ArSnlycTlC?=
 =?utf-8?B?alhpdGdNMTc3UUlDQ2lCNXRBcU9kbjhpSFc2ZWVTOE1JWjhCTE8xRFhPS05B?=
 =?utf-8?B?ZnhZUG1QZThSRkEyc012S05hdjVmMVpMbmlZcnoxQmx4NVBzZ1ZFSjl6V3F2?=
 =?utf-8?B?Uk9DZ3U2QmlOMUk4clFKNTJSRyt4N0JJY05kbDltenNjSFI3aU9hWkJ3R250?=
 =?utf-8?B?VXpaVDQxUlpvc1g0RGhxRjZkVi9QL2l4cGozWFVmR2dHMXMvOE1ZVm5JRzhr?=
 =?utf-8?B?RTV3Q1VkSHhlTjBWTmIxbHlBdVZ4cDY0bnkxRmNXTnZwUXhkVGlUR2NkQVV5?=
 =?utf-8?B?bnBzT1pPQTNSb3JLWjZweTBWSldaZXFNcTdCWFlPak1pdllsanl4K21QVVFJ?=
 =?utf-8?B?c3dVaDhWdXhnRVowOXdCWFROdVltd0k0R1dtN0dGRUhKK0Fsa1huZnpUSENz?=
 =?utf-8?B?TEhlWVQ3dmJLQzR6STdHUCtjeFkzaElsODA1RWk2cDNabmNmdU1acllFa2Jw?=
 =?utf-8?B?S250SkJZcWVLb3lxR3J0WDl6eEo4Qkh0VzdTL2o5K0ozQWFDcjNSNW9qK3d6?=
 =?utf-8?B?MGRUd0duczVEcUxWNm80aEt2TGpPNFJtZWpGWEk3MFk3aFB4ODhZa2ordEoz?=
 =?utf-8?B?MmE0ak0zWmgxSFVQV3ZFeDAyb21GYy90V1dzYS8vN1YyZ1RmQWp5L1VTeFZu?=
 =?utf-8?B?R2ZwSS9ucXcvUDh6VjdvdG5WWk5HWmhOSnMyNXZDTG5kZGdjbFJYL1gxT1Y4?=
 =?utf-8?B?bTlpTStRVTlIUlBXSUR5L04wRUZkdENLTGU1Vy9lWUxFNDBnODdnRitmcndR?=
 =?utf-8?B?QW1wbFFkWk5jY09LeWFGcFEwRUlMOTJGbUcva0piUjBUMzhqOWZEalBJR2Zz?=
 =?utf-8?B?RDJnVWMydlJEWmQ4YlhPTjY0OGI2VjBMU2xoaW55dU1BazVzUWFaZ3VheGVK?=
 =?utf-8?B?bnREc1VySkZMQUQ3OGRNZ3dNUUQwdEViTE1SaFZFejloVjFaTzM0Y1dRaFFr?=
 =?utf-8?B?L2RSTGI2eG14eUNwelUvbzh0SjIxTVEzV05RZFNTdnMzL040eUZOU0s0dDNQ?=
 =?utf-8?B?OURYQjU2V0dQdlJoYiszVHlMb3E4aXZpTTcvZnc0VWZhc05BZ3doRFdCWjlX?=
 =?utf-8?B?dVlPWGVieVlkNlA1TDdrMnlmV0xHZzNlZkxBRU9wMmY1M29NbGlIQjFSTGJm?=
 =?utf-8?B?eFZvdHZWbWRES3h6QzU3dm0yTTdHeXEwR2M0NzJIOGpEWUlJS3A0a3ZnWFg5?=
 =?utf-8?B?eGFRYVJCdkxCMzR3WGlZczZzOTBzQTl4d1lxRWVJekVNemNkZHJSUnhZY2Fr?=
 =?utf-8?B?YjdVM1pleUpWUk50UEc2VTNVZ0RJVUVZRzRqbG81UWxrSGpmOWtXN29vam5Y?=
 =?utf-8?B?UDFPK09jWXVWMlZYWjZySEl2TmYxOUcvUXIrRWFiNlJsaTYwYjNCUzdnbVhK?=
 =?utf-8?Q?LoJR8UpmXJpowzqsCXFjHbSbP?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 55978e6c-b9b3-4429-9d48-08dc5e28587c
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 15:17:35.7574
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q+4Yddljm87qll6ME14pEBDWF5HPz9FDCPbbfi+mnNEAOAFf3RyyIIOiRocIZZ0Yt7LWMOA4NLmd4hOBqiubmQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4394

On 4/15/24 23:54, Dan Williams wrote:
> Hey, Tom, came looking to review the tsm_report changes and noticed
> this...
> 
> Tom Lendacky wrote:
>> Currently, the sev-guest driver uses the vmpck-0 key by default. When an
>> SVSM is present the kernel is running at a VMPL other than 0 and the
>> vmpck-0 key is no longer available. So choose the vmpck key based on the
>> active VMPL level.
> 
> The module parameter is not mentioned in the changelog. Is it not
> sufficient to always use snp_get_vmpl(), and if not should there be some
> documentation about when to specify vmpck_id?

It is possible to encounter an issue that causes the vmpck key to be 
cleared. In that situation, the guest is allowed to use a vmpck key 
associated with a lower VMPL. For that reason, the module parameter was 
added to the driver when it was initially created.

I can update the changelog to mention this.

Note that as long as the vmpck key exists, a guest running at VMPL2 
could request a VMPL0 report using the vmpck0 key, that is why it is 
important that the SVSM clear to zero any vmpck key that represents a 
higher privilege. For example, if the SVSM (running at VMPL0) launches 
the guest at VMPL2, it should zero out the vmpck0 and vmpck1 keys in the 
SNP Secrets Page supplied to the guest.

> 
> Do users know that "vmpl" and "vmpck_id" are interchangeable?

Yes, they should be aware of the relation of VMPL to VMPCK from the SNP 
specification.

Thanks,
Tom