Received-SPF: pass (google.com: domain of linux-kernel+bounces-147096-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 16 Apr 2024 11:13:05 -0400
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: jeffxu@chromium.org
Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com,
        sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org,
        torvalds@linux-foundation.org, usama.anjum@collabora.com,
        corbet@lwn.net, surenb@google.com, merimus@google.com,
        rdunlap@infradead.org, jeffxu@google.com, jorgelo@chromium.org,
        groeck@chromium.org, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
        pedro.falcato@gmail.com, dave.hansen@intel.com,
        linux-hardening@vger.kernel.org, deraadt@openbsd.org
Subject: Re: [PATCH v10 0/5] Introduce mseal
Message-ID: <znrbeb744774vre5dkeg7kjnnt7uuifs6xw63udcyupwj3veqh@rpcqs7dmoxi6>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@oracle.com>, 
	jeffxu@chromium.org, akpm@linux-foundation.org, keescook@chromium.org, 
	jannh@google.com, sroettger@google.com, willy@infradead.org, 
	gregkh@linuxfoundation.org, torvalds@linux-foundation.org, usama.anjum@collabora.com, 
	corbet@lwn.net, surenb@google.com, merimus@google.com, rdunlap@infradead.org, 
	jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, 
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, 
	pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org, 
	deraadt@openbsd.org
References: <20240415163527.626541-1-jeffxu@chromium.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240415163527.626541-1-jeffxu@chromium.org>
User-Agent: NeoMutt/20231103
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?NnhESTd5K2dIMEUxV3N0WlA4NlhER1JCM3NsMVVWd1ROaWpwcEo1TnV4VmpT?=
 =?utf-8?B?VjZ3RmpBcGFQYjB1QnZycFJkMGxrWkNyYmtQSVFrWWNjeC9qWXFqWVBuclZV?=
 =?utf-8?B?YXk5R29HbGdtcC9sQnlkazVTSTZpWEc5R09kTWkzRFBGcllRc0l6L1lGOUxn?=
 =?utf-8?B?RE1ZUFdjVFFzN2N2WmZTWXlQM3R4OHhqaXllQ24yLzF0WWdjdHhTeGxQeWFP?=
 =?utf-8?B?bGN5OW9ZRXROQzZlMWNBWlNGWlhkYzNQcUV0QlNhdm4rejU2UHdCMXRFTGxO?=
 =?utf-8?B?KzVSdXJhUUttRUpLVUFPcTBMUG90Tmt6ZFZiYlBoZzcveXlSYWF0cUt5enVG?=
 =?utf-8?B?dExjQkpCVi9ZOS84SmRvaThyU0JJS3VmTFNFMGhXVVVhYUxObS9sMW1SQ1FM?=
 =?utf-8?B?NnN5TGo0dUFtNmtTd2tHZUhkRVJRQlB1eitkVnNQRWwzUTdYVy8xbE5yQUU4?=
 =?utf-8?B?Yk5FdG1pZ3Uya2hSRW1xMnllekdFWlk4T3RqZU9hWDFDVE5ZQ0pqa0JnSWRV?=
 =?utf-8?B?Sk5RSWNsMXpWWW5RSFl0aEpuYjBpam4vVWdOQi9LTnl4QmlIcER4a1FMaEdh?=
 =?utf-8?B?UXFpbXFtcHU5OUphd0hjVnY0QUh4SlNzWEhHL2N5cG9DUXIxOG0wNDBZZzdH?=
 =?utf-8?B?SHFJWCtzYmU3blV3WERESlQ4V3UxUVl0NUk5UFV6bFhtSS9KRjdLWWh3azYv?=
 =?utf-8?B?aEsrbEJhRHlNdDBucHQvT3llNTBNT0lTeEp1am54eFZmT2hsQVc0S24vS1FQ?=
 =?utf-8?B?OWF4QkVzRGFYRktRQWJ0aVhsbHViTTZVUGxrMDNTMmRKUkUvM1VNNDlxRm9u?=
 =?utf-8?B?VkVhbVV3MGtPbnZ0c2ZDTlF6aUtOTVEyazB2dzFnRUszZkg0UjRWa0F1NWpt?=
 =?utf-8?B?djFKL0dJK0piQjg4KzQvc3IzSDlJNmJtWW9sYmEzMkoremJxeEF6MFRGNTRv?=
 =?utf-8?B?TVFyL0J5YkFsWno1NzNIVjBEV2dpRmUwalQzeWl5YUJldzNTR3hrZHhuV1dD?=
 =?utf-8?B?NldCTEQ0ZlBjZjFXeGFpazgwOVlSQVlIRjJkak5DUUJSSjMxWXR5M29EUHhH?=
 =?utf-8?B?RlhISnRuZEdQekZWaG0rNlJrUy9qQlA0L0hlK29qRGx2RjhXRGhVUFQvdHpC?=
 =?utf-8?B?TTNkSlArZEV5MkJaUDMveTlKclRZOW5jSXMxcUJIUTF4NUwzVDRkMUdyNlJu?=
 =?utf-8?B?dW5oWkxwUzlCV21ncWZZMVJnL215bU5ENnVjL1NiWjJsQWk2TTNLaFpTNC9q?=
 =?utf-8?B?OUU2NXc2U0k0RkFBUGFnS1BtZVlyK0pKaktob3BCdkpIVUZqQnZ3YVhuS3Bv?=
 =?utf-8?B?dGVyc1UrenVpRlFyUjJTTnI0M2ZHNHBhclNTNVFLSkFjSGdPZERRcnpBeEdD?=
 =?utf-8?B?Wm0raG0yRjYxTHlPeW5mbGtNQXVWZ1B5b2dHd2xXVktJZWp2VVNDMEhuQUVp?=
 =?utf-8?B?QnFOcVh6cXJwakY4alcrbmlRQzF2TzBFUnZuZ0ZNWWgwOEtoYnlwNjdvVDdV?=
 =?utf-8?B?ZEl3dEl3ZEZKcTFtSkVaem9yNGhmNnR0QkhwakhMWVZPRDhWNkxPNGtTdnhL?=
 =?utf-8?B?VWVmMitkYWlEOUVnTzY5MjdmNWJTM0lTUWVVMnVDS2Q3bW1QdEZ5TXhJeTJI?=
 =?utf-8?B?a2ZIUUFZTUxsVDRJS1Nlc1RVcUlKQXFNQzloMk5EU0VVUmt6RkZyZXJSSDEz?=
 =?utf-8?B?QzMwY2NOOVFvODNGSWo3MUxpeDhjOUIvL2Mxb3hjc3JnRi9aTURNVUNWU2pI?=
 =?utf-8?B?VktKTVBJMXdpZ0FONnVweXZjTktocEFGY2JIclJ4WHl6cnRiUThyeXJKNnFO?=
 =?utf-8?B?c2pBSHR2RjNBbm9wMjJ2endCWVdCcWYwRENoaDJIVk8rVTJuT1hhNkdVYnZB?=
 =?utf-8?B?d3lSRVhhQmpycjNyZzB3dE9mUzdtRlZENnVoM1NCSGg2MzFLczBSRkFmd0xS?=
 =?utf-8?B?cjZndTNPb0JJODVMZUcwSnZvYUNPL0syeVNPMForeGdsVitvYm5QSUJxcFZ6?=
 =?utf-8?B?SlRkdFNaRE5jN0pNNnVpWENENVh0Y1BhRVhmV1dZMWwwMEV0clhtbGQ2N2l4?=
 =?utf-8?B?cDN3MDVqSXFRMyttaTJieEF6MnY4VmVTZGxVRFNrSWpOS2I5ZEExUTJpVmJa?=
 =?utf-8?Q?yX4GRod2Qq+PM6fAGagtKEf/d?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	TnZD/TJk/R8Y5JarYIx9DqttAPJgWhqjWzdcSRlxWR7SVg2dzlCd2vFUW9EZokuEN9kRSgnNV9iFCrWQ44oKiUalYquyIQkW1GjT/CClRpP/pooxAHDhYWNS4Vox1Br3nwF+Ebt8Fb731hLez2i3s5VzpJDR1MVdlEBU9zDCuvWX3fyjpuArEpN/aB1YgEOJJanCXRIprF11D9aEPNT2TQnwqXPABkw39w88Xoc/FP1xaEztixBFqECUg5N5MhVYkf3E/2WTWt3Kuwhfy4lD/RiZa8Virli6/0WRebGps4a49JrbuUnqUGmcICeY7Y9U6G5B80zGWPYhX9NN34jhVcv6HNhf14roTVPZ7iXGs+VvldiOgpobm72IXDaj6BdcZ7gK9BthTqOLT8NyBuek7WE/QzzwPFOrUTabrWP6XJdX4+wi1/D48remiVFAh+oPST8GGx2C+QGjo82uGlOKpmGxmpgTySIHbBK00PNsnLoyj/xKTiQ82Qd9zfXUQypLLfRKDm+a4CVDkxFUg0kCObCy1jjuA/8e00BK8zgCJcnnTYTkPWF48sqV9Ed4LvkDqwJ7//bmi2kQm1VEGrptwWJjE6cKkRV1LR40CK+/2hM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c5deb87-54a9-4704-88f5-08dc5e27b8ea
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 15:13:08.0290
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2Y7VYuY+HEjzEYx1ODzVWMBl4P/bYN5tmnEGpCaB54poQ4eKuyq0OtDSc8jF1l0qNmjT6BuXZRbR7372AhyeSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5823
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-16_10,2024-04-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxlogscore=999
 mlxscore=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000
 definitions=main-2404160093
X-Proofpoint-GUID: OkIYY4cD1lR1GJs3U7WXLzM-DKM_1j9t
X-Proofpoint-ORIG-GUID: OkIYY4cD1lR1GJs3U7WXLzM-DKM_1j9t

* jeffxu@chromium.org <jeffxu@chromium.org> [240415 12:35]:
> From: Jeff Xu <jeffxu@chromium.org>
>=20
> This is V10 version, it rebases v9 patch to 6.9.rc3.
> We also applied and tested mseal() in chrome and chromebook.
>=20
> ------------------------------------------------------------------
..

> MM perf benchmarks
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> This patch adds a loop in the mprotect/munmap/madvise(DONTNEED) to
> check the VMAs=E2=80=99 sealing flag, so that no partial update can be ma=
de,
> when any segment within the given memory range is sealed.
>=20
> To measure the performance impact of this loop, two tests are developed.
> [8]
>=20
> The first is measuring the time taken for a particular system call,
> by using clock_gettime(CLOCK_MONOTONIC). The second is using
> PERF_COUNT_HW_REF_CPU_CYCLES (exclude user space). Both tests have
> similar results.
>=20
> The tests have roughly below sequence:
> for (i =3D 0; i < 1000, i++)
>     create 1000 mappings (1 page per VMA)
>     start the sampling
>     for (j =3D 0; j < 1000, j++)
>         mprotect one mapping
>     stop and save the sample
>     delete 1000 mappings
> calculates all samples.


Thank you for doing this performance testing.

>=20
> Below tests are performed on Intel(R) Pentium(R) Gold 7505 @ 2.00GHz,
> 4G memory, Chromebook.
>=20
> Based on the latest upstream code:
> The first test (measuring time)
> syscall__	vmas	t	t_mseal	delta_ns	per_vma	%
> munmap__  	1	909	944	35	35	104%
> munmap__  	2	1398	1502	104	52	107%
> munmap__  	4	2444	2594	149	37	106%
> munmap__  	8	4029	4323	293	37	107%
> munmap__  	16	6647	6935	288	18	104%
> munmap__  	32	11811	12398	587	18	105%
> mprotect	1	439	465	26	26	106%
> mprotect	2	1659	1745	86	43	105%
> mprotect	4	3747	3889	142	36	104%
> mprotect	8	6755	6969	215	27	103%
> mprotect	16	13748	14144	396	25	103%
> mprotect	32	27827	28969	1142	36	104%
> madvise_	1	240	262	22	22	109%
> madvise_	2	366	442	76	38	121%
> madvise_	4	623	751	128	32	121%
> madvise_	8	1110	1324	215	27	119%
> madvise_	16	2127	2451	324	20	115%
> madvise_	32	4109	4642	534	17	113%
>=20
> The second test (measuring cpu cycle)
> syscall__	vmas	cpu	cmseal	delta_cpu	per_vma	%
> munmap__	1	1790	1890	100	100	106%
> munmap__	2	2819	3033	214	107	108%
> munmap__	4	4959	5271	312	78	106%
> munmap__	8	8262	8745	483	60	106%
> munmap__	16	13099	14116	1017	64	108%
> munmap__	32	23221	24785	1565	49	107%
> mprotect	1	906	967	62	62	107%
> mprotect	2	3019	3203	184	92	106%
> mprotect	4	6149	6569	420	105	107%
> mprotect	8	9978	10524	545	68	105%
> mprotect	16	20448	21427	979	61	105%
> mprotect	32	40972	42935	1963	61	105%
> madvise_	1	434	497	63	63	115%
> madvise_	2	752	899	147	74	120%
> madvise_	4	1313	1513	200	50	115%
> madvise_	8	2271	2627	356	44	116%
> madvise_	16	4312	4883	571	36	113%
> madvise_	32	8376	9319	943	29	111%
>=20

If I am reading this right, madvise() is affected more than the other
calls?  Is that expected or do we need to have a closer look?

..

> When I discuss the mm performance with Brian Makin, an engineer worked
> on performance, it was brought to my attention that such a performance
> benchmarks, which measuring millions of mm syscall in a tight loop, may
> not accurately reflect real-world scenarios, such as that of a database
> service. Also this is tested using a single HW and ChromeOS, the data
> from another HW or distribution might be different. It might be best
> to take this data with a grain of salt.
>=20

Absolutely, these types of benchmarks are pointless to simulate what
will really happen with any sane program.

However, they are valuable in that they can highlight areas where
something may have been made more inefficient.  These inefficiencies
would otherwise be lost in the noise of regular system use.  They can be
used as a relatively high level sanity on what you believe is going on.

I appreciate you doing the work on testing the performance here.

..