Received-SPF: pass (google.com: domain of linux-kernel+bounces-147149-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 16 Apr 2024 08:47:54 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Tom Lendacky <thomas.lendacky@amd.com>, Dan Williams
	<dan.j.williams@intel.com>, <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
	<linux-coco@lists.linux.dev>, <svsm-devel@coconut-svsm.dev>
CC: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>, "Peter
 Zijlstra" <peterz@infradead.org>, Michael Roth <michael.roth@amd.com>, Ashish
 Kalra <ashish.kalra@amd.com>
Subject: Re: [PATCH v3 09/14] virt: sev-guest: Choose the VMPCK key based on
 executing VMPL
Message-ID: <661e9daa4b37c_4d56129418@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <cover.1711405593.git.thomas.lendacky@amd.com>
 <9615e6055e5b262a22bf312608647223517595b5.1711405593.git.thomas.lendacky@amd.com>
 <661e04966c622_4d5612946d@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <8a1b16c0-9897-bd10-b6f7-b428292c8c9f@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <8a1b16c0-9897-bd10-b6f7-b428292c8c9f@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vqrUM4ICoIf+41HsUc3T5ckcZW7AzhcOYXP4ONWvbcVGCh0FSRA2DnRo5twj?=
 =?us-ascii?Q?nrztwuJFLOvDs/x/FgyLJzYgTnAKyatrC6x9rcWzH8U59OeXVlSgRvCAnwNU?=
 =?us-ascii?Q?jHW6Anai+D2bXetXJEFDzg6sq2LUDw2kGoMClAKp5SKbxGNEiUON0MhBdoN5?=
 =?us-ascii?Q?ptoSqL+Mynnp8lHl5OPoP0oAkhSwhns7PeqkcLX47bOvQvXw0FkZrde3QK9S?=
 =?us-ascii?Q?S/PLjm8xihThEjTAHSUVcF/GsN9KjQgnbShcKQceMsgpt/NgivICcnfkOme1?=
 =?us-ascii?Q?brtUcRxqCIpwl/fa0QZsJJBCBUmtqj/Vx+Y6YE0MOPxXy/2QTrf/MB3/DnOi?=
 =?us-ascii?Q?A20fue/KGuKk/dl56WTti1ltgZEERPKbhJPzwp8AlP1qlNwhKIx0JGhFpd42?=
 =?us-ascii?Q?YBIpvZu5mk8jPtc47M7thyF956gdjvXNJLvzymI3KOh+wmJAxma7eeBvur77?=
 =?us-ascii?Q?5990bWLJfXeD56olt6ORCcb0HsRrJTFQ0AnO+7n9Xg3rjQTeudClDCTYdV+d?=
 =?us-ascii?Q?/XdxBwRQzSy4ebgpB0RcwLKyFVvsIaiA0sNHgaZOUsuxJbeY1UsKAzIWjFj7?=
 =?us-ascii?Q?u/OmfzxHubgqUQS/SjcxFRp1PkJd4kln5CI0caTVbN4/r8irw+pwwqsG1SJA?=
 =?us-ascii?Q?JR03twJgq5zwvZ+M0sUsrF5/UJBINq3cuRQ0vtXvNsoL0/ggKBtgbxl9xfIV?=
 =?us-ascii?Q?vdzb8tu7nSRt8+JKmkuJtOHHBFFb6i+b8u4PQpUwrBclBuw8P4Ak8nUBkOqT?=
 =?us-ascii?Q?GaIYgrhc1BfPom+0ngoSm5KhFzsW+dEz7zq1bN7W7YzCZiNo3VUTpr9zghc+?=
 =?us-ascii?Q?BzCkCSUc7ga0U7rLmihFoOXs5w7vovXsXVcFVZdnJVtx5WQk5v/Sja6tHiYg?=
 =?us-ascii?Q?QxGrx8l1ylkjW85Ot9U6LKVlTurHc0LtfwRXYrl0d5+Z+We3v7Yp5xm6xyJl?=
 =?us-ascii?Q?BZVR1YLxvX2794GMHqaWnDk0p0XDICPwRmUlH9wSDy1CwH+8TQ2q1Sojr0dH?=
 =?us-ascii?Q?FGHsphA7so25knZEHQmQxFsPQ9eJSaaECOcwCO3RRoXgJjPRw0CQvUff6RVI?=
 =?us-ascii?Q?TbJJoNqss0JGW3a/hiUeb8M18V8OiDtEpC+RzIpJEZe46GFPrBWERH9idb/j?=
 =?us-ascii?Q?JzxEYFwQ8/sIadAyNn1Rs7dt33fIDkuKadZkV8J5wcYHnZ7uNBexRCe4EANo?=
 =?us-ascii?Q?4uNn1Kl6qYjgNoeVCIK2crX/tjWmqn+HoH8/9iqBfiYtcG0/Oc2WlhNUjmnu?=
 =?us-ascii?Q?XiTGs/eHxBcsK1WZ2azZkfKC882MDppC1lBh0/bZDx5gFAIGmD+czlhn4g3t?=
 =?us-ascii?Q?o/RIrJ2e/gnHSRp5p2CBmlSGGt/Lk51k/3S+a2Bi6SdldJgn9gPH263tL93T?=
 =?us-ascii?Q?9tzeq5+Tp7HV3g4a7b+1DKXwReF4p8P56vDmYrT6s9Xag3sxMR2yd/e/01cy?=
 =?us-ascii?Q?NU6ZSXdzhFyqaPdjFLGtnDo8Q135pB4YOu2CAxUYN2J4AVOoj/omG6YRRxQi?=
 =?us-ascii?Q?fjD6cxlTS/snH56fIgygevN/00JZFkqv5+bI4Y266SW578BaVNwqEYhYt0OG?=
 =?us-ascii?Q?valubwQnM8QS5ki3/VrZjx/hbUxD1zHyEifuNFlmYFjfLAB1tVX+NJtrTlAb?=
 =?us-ascii?Q?gg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a1835a9-c519-4e65-8219-08dc5e2c961d
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 15:47:57.1079
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qVElfNBBhr7W9mfroVOBhcINM6M8oDdrA3Bd/wXJFa4cE163XIjyAHUsjqKIcA9uubt6owamv+TSxprYeXQ+mYL6TJGQrJivTHGyc+oF5m0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6798
X-OriginatorOrg: intel.com

Tom Lendacky wrote:
> On 4/15/24 23:54, Dan Williams wrote:
> > Hey, Tom, came looking to review the tsm_report changes and noticed
> > this...
> > 
> > Tom Lendacky wrote:
> >> Currently, the sev-guest driver uses the vmpck-0 key by default. When an
> >> SVSM is present the kernel is running at a VMPL other than 0 and the
> >> vmpck-0 key is no longer available. So choose the vmpck key based on the
> >> active VMPL level.
> > 
> > The module parameter is not mentioned in the changelog. Is it not
> > sufficient to always use snp_get_vmpl(), and if not should there be some
> > documentation about when to specify vmpck_id?
> 
> It is possible to encounter an issue that causes the vmpck key to be 
> cleared. In that situation, the guest is allowed to use a vmpck key 
> associated with a lower VMPL. For that reason, the module parameter was 
> added to the driver when it was initially created.

Oh, sorry, misread that the module parameter was not new.

> I can update the changelog to mention this.

I guess it is too late now, but a proper sysfs attribute rather than a
module parameter would let you do sanity checking on the writes and
allow a natural place to document behavior in
Documentation/ABI/testing/sysfs-devices-sev-guest.