Received-SPF: pass (google.com: domain of linux-kernel+bounces-147250-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 16 Apr 2024 17:34:42 +0100
From: Mohamed Ghanmi <mohamed.ghanmi@supcom.tn>
To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: "Luke D. Jones" <luke@ljones.dev>, Hans de Goede <hdegoede@redhat.com>,
	corentin.chary@gmail.com, platform-driver-x86@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: asus-wmi: add support for vivobook fan
 profiles
Message-ID: <Zh6oooU-DL2IXLg9@laptop>
References: <20240413202112.37729-1-luke@ljones.dev>
 <dccc5701-f533-e80e-09f8-199f232f447f@linux.intel.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <dccc5701-f533-e80e-09f8-199f232f447f@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?iso-8859-1?Q?HL958PgSwG/AGvWG4b1AxMT3+COJgcP//zQutjE4JVIpVoUe3+JHOxk+tO?=
 =?iso-8859-1?Q?2arB+Bp0YMJyBaVFXttUPhCswvo1gGpUsNe47rFVU91CFr5EF9p7vo5P47?=
 =?iso-8859-1?Q?dlUT0tT3c3qQ+4aPSi9K7yo1LRvQ5TTHKxXcpU5Ks6yX+qd7ZmkIZg/o1C?=
 =?iso-8859-1?Q?fcEE8XhN5CeGrNVqVOIJdca2ctPeeba2J7ILSYGzjM7Nas0xkhH1YtzZYD?=
 =?iso-8859-1?Q?WR6q2re/dtQO+TAwjFgoVuJzojdDr8XYv76Tqy7fCIilsIKpeq5dB3xsYW?=
 =?iso-8859-1?Q?3oFKUmkUfsLk2pHrw2sF931aftx0TFDTLHLRulIejI5rQxPauZMsWa06sj?=
 =?iso-8859-1?Q?EGJoPiJEelVNksY/Xui1dwQA2+YAVeRoVUXNPqmI59sX9B3Ikd9aFQ/gAJ?=
 =?iso-8859-1?Q?RzqMTEUGvsAJYfsL6zzaJ/6UxgtqjFZ5i66XbP1YYD4JAJZjkcJZKG0XVF?=
 =?iso-8859-1?Q?CvQa272URVYIk1Kedk+yDUIA4y+RryEfHvvdaUMtfR8vzFM+45Uy6oO7a8?=
 =?iso-8859-1?Q?3p9IiSF5Re3D2rA/cRGNM8TKebDONJk+TbAaXOmWe8Tjvh9Uumg6cCgkZZ?=
 =?iso-8859-1?Q?hK53UagDRdNQhI945HuphpfdaRS3q1B/p1M6LxzpUJYUz2mL6ncym8NKk6?=
 =?iso-8859-1?Q?JXP8YFw2mccm/mK9ESPVExaiQmw68UYibmMvSf9WapxQm4kfJmVg7q4DHu?=
 =?iso-8859-1?Q?nEZLw+7FfV1/4agmWxPff1qsjazoe6vBii4D7Aogdb3WgQdgLSaU1ccCqS?=
 =?iso-8859-1?Q?/DlpQPYmIGV4PSaJBQ79ntk0ywTntoe6CsgmDtVphYNkv6XfJIMgaCHv1L?=
 =?iso-8859-1?Q?5rRx/syDSuJWuX7sLr47WC3WNsXYNTP8LL/Rvr+CCdlwxai3TzmrysAQX3?=
 =?iso-8859-1?Q?sjdZf4KvEa9KyZ6JxrBqfsIN46OSsVKOevvxiqKPn958K8AHm9zuMcOSsP?=
 =?iso-8859-1?Q?KGWP/Tw3AuVMEUyCNIqV5wwYEBoXxsSao29W3J1H+yv7kecy+O3adSLZfA?=
 =?iso-8859-1?Q?CGUanFFdLMWiemH+TawJmIyps2/k72IQWdfjOTIcXZu4xOF7daUYyHQIhK?=
 =?iso-8859-1?Q?9q86tc0dSrY+0H70Z0XZNlnw15/vFVH2bmtvZyirY7SF4dQcqrMyK9sXBj?=
 =?iso-8859-1?Q?b5zKfw+kkLtOChTBwQ7edX4MiQlZNgkKKXaNQOi3xmKEPLmgedSnQLH4Fj?=
 =?iso-8859-1?Q?c0xzsLa86Q5fPoRXwMYtSFM0GA4osDGV0EnwTAJezQy2b34VJU+MLtoJnM?=
 =?iso-8859-1?Q?U79DIKCF4ylkkNbdiut+HUESV/hssyfHfS2OZNevwH5qX0x9xllMZmwX43?=
 =?iso-8859-1?Q?HtXr/F+1I77UfeMXueUx4YUmM0dhyAu5tD6fmhFFayZov2RPoo2AyY/Qu+?=
 =?iso-8859-1?Q?iWGXu/kxgbV6hTEQ9C+eAVEUJ6jMTTTPtc28/djjgkvjfbLhhv3ZdtdCzF?=
 =?iso-8859-1?Q?lwX+G82/yGzcoQX7wGWoqadRFZGxEMdPZp0t18ZBoe9HE28P/6Td4Xr+Vl?=
 =?iso-8859-1?Q?CTtm1lGDuBlblTciyUjHHQjHCFhgM05eenGJ+MLEZGUbM77tIXWZwyQxeS?=
 =?iso-8859-1?Q?gZ/pVasj4MKdgZXg416cWNm0GLyBHbsOrdrpPvBjIhm+2bEcVQxixDD6MO?=
 =?iso-8859-1?Q?Xbki8+QQJ499Clx6oJ33YnbVxuuxLITw4Tf8KPkIUUOESMv+7AIQgMeVJd?=
 =?iso-8859-1?Q?hwIMt7xJYDjQikI3yQz+IVYiOefm3EgwAgB8tQBXIv568jNg724/Oe9vAD?=
 =?iso-8859-1?Q?ndWw=3D=3D?=
X-OriginatorOrg: supcom.tn
X-MS-Exchange-CrossTenant-Network-Message-Id: f406e4e0-7347-42d9-b9c9-08dc5e331f0a
X-MS-Exchange-CrossTenant-AuthSource: AM0PR0402MB3905.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 16:34:43.8323
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8f85f528-6195-4e97-8e41-f5a9ad3bed4a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zjoJ4+CuVQM3N2soNGdZaasZTcNzUj/X+24XHJlBQBP11b+tZkROIsAisrKymvQjFbtS0pLQIiwvEKMHrOBg/yM5P9ruJ1NCH6oR5TI4kp4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9506

On Tue, Apr 16, 2024 at 03:51:03PM +0300, Ilpo J?rvinen wrote:
> On Sun, 14 Apr 2024, Luke D. Jones wrote:
> 
> > From: Mohamed Ghanmi <mohamed.ghanmi@supcom.tn>
> > 
> > Add support for vivobook fan profiles wmi call on the ASUS VIVOBOOK
> > to adjust power limits.
> > 
> > These fan profiles have a different device id than the ROG series.
> > and different order.
> 
> Fix grammar.
> 

my grammar is not the greatest so i'm finding it hard to know what is
the error you're referring to but I think that 'add'
should become 'adds' ?

> > This reorders the existing modes and adds a new
> > full speed mode available on these laptops.
> > 
> > As part of keeping the patch clean the throttle_thermal_policy_available
> > boolean stored in the driver struct is removed and
> > throttle_thermal_policy_dev is used in place (as on init it is zeroed).
> > 
> > Signed-off-by: Mohamed Ghanmi <mohamed.ghanmi@supcom.tn>
> > Co-developed-by: Luke D. Jones <luke@ljones.dev>
> > Signed-off-by: Luke D. Jones <luke@ljones.dev>
> > ---
> >  drivers/platform/x86/asus-wmi.c            | 100 +++++++++++----------
> >  include/linux/platform_data/x86/asus-wmi.h |   1 +
> >  2 files changed, 55 insertions(+), 46 deletions(-)
> > 
> > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> > index 2d2b4eca7fd8..439d330fb80b 100644
> > --- a/drivers/platform/x86/asus-wmi.c
> > +++ b/drivers/platform/x86/asus-wmi.c
> > @@ -97,6 +97,11 @@ module_param(fnlock_default, bool, 0444);
> >  #define ASUS_THROTTLE_THERMAL_POLICY_OVERBOOST	1
> >  #define ASUS_THROTTLE_THERMAL_POLICY_SILENT	2
> >  
> > +#define ASUS_THROTTLE_THERMAL_POLICY_DEFAULT_VIVO	0
> > +#define ASUS_THROTTLE_THERMAL_POLICY_OVERBOOST_VIVO	2
> > +#define ASUS_THROTTLE_THERMAL_POLICY_SILENT_VIVO		1
> 
> Any good reason why these are not in numerical order?
>

these are not in their numerical order but in their logical order

from the point of view of userspace both asus ROG devices and asus
VIVOBOOK should behave the same: 0 -> default, 1 -> overboost, 2 ->
silent.

I'll add a comment to better explain the reasons behind the order
of the macros.

> > +#define ASUS_THROTTLE_THERMAL_POLICY_FULLSPEED		3
> > +
> >  #define USB_INTEL_XUSB2PR		0xD0
> >  #define PCI_DEVICE_ID_INTEL_LYNXPOINT_LP_XHCI	0x9c31
> >  
> > @@ -285,8 +290,8 @@ struct asus_wmi {
> >  	u32 kbd_rgb_dev;
> >  	bool kbd_rgb_state_available;
> >  
> > -	bool throttle_thermal_policy_available;
> >  	u8 throttle_thermal_policy_mode;
> > +	u32 throttle_thermal_policy_dev;
> >  
> >  	bool cpu_fan_curve_available;
> >  	bool gpu_fan_curve_available;
> > @@ -3153,7 +3158,7 @@ static int fan_curve_get_factory_default(struct asus_wmi *asus, u32 fan_dev)
> >  	int err, fan_idx;
> >  	u8 mode = 0;
> >  
> > -	if (asus->throttle_thermal_policy_available)
> > +	if (asus->throttle_thermal_policy_dev)
> >  		mode = asus->throttle_thermal_policy_mode;
> >  	/* DEVID_<C/G>PU_FAN_CURVE is switched for OVERBOOST vs SILENT */
> >  	if (mode == 2)
> > @@ -3360,7 +3365,7 @@ static ssize_t fan_curve_enable_store(struct device *dev,
> >  		 * For machines with throttle this is the only way to reset fans
> >  		 * to default mode of operation (does not erase curve data).
> >  		 */
> > -		if (asus->throttle_thermal_policy_available) {
> > +		if (asus->throttle_thermal_policy_dev) {
> >  			err = throttle_thermal_policy_write(asus);
> >  			if (err)
> >  				return err;
> > @@ -3577,8 +3582,8 @@ static const struct attribute_group asus_fan_curve_attr_group = {
> >  __ATTRIBUTE_GROUPS(asus_fan_curve_attr);
> >  
> >  /*
> > - * Must be initialised after throttle_thermal_policy_check_present() as
> > - * we check the status of throttle_thermal_policy_available during init.
> > + * Must be initialised after throttle_thermal_policy_dev is set as
> > + * we check the status of throttle_thermal_policy_dev during init.
> >   */
> >  static int asus_wmi_custom_fan_curve_init(struct asus_wmi *asus)
> >  {
> > @@ -3619,38 +3624,31 @@ static int asus_wmi_custom_fan_curve_init(struct asus_wmi *asus)
> >  }
> >  
> >  /* Throttle thermal policy ****************************************************/
> > -
> > -static int throttle_thermal_policy_check_present(struct asus_wmi *asus)
> > -{
> > -	u32 result;
> > -	int err;
> > -
> > -	asus->throttle_thermal_policy_available = false;
> > -
> > -	err = asus_wmi_get_devstate(asus,
> > -				    ASUS_WMI_DEVID_THROTTLE_THERMAL_POLICY,
> > -				    &result);
> > -	if (err) {
> > -		if (err == -ENODEV)
> > -			return 0;
> > -		return err;
> > -	}
> > -
> > -	if (result & ASUS_WMI_DSTS_PRESENCE_BIT)
> > -		asus->throttle_thermal_policy_available = true;
> > -
> > -	return 0;
> > -}
> > -
> >  static int throttle_thermal_policy_write(struct asus_wmi *asus)
> >  {
> > -	int err;
> > -	u8 value;
> > +	u8 value = asus->throttle_thermal_policy_mode;
> >  	u32 retval;
> > +	bool vivo;
> > +	int err;
> >  
> > -	value = asus->throttle_thermal_policy_mode;
> > +	vivo = asus->throttle_thermal_policy_dev == ASUS_WMI_DEVID_THROTTLE_THERMAL_POLICY_VIVO;
> > +	if (vivo) {
> > +		switch (value) {
> > +		case ASUS_THROTTLE_THERMAL_POLICY_DEFAULT:
> > +			value = ASUS_THROTTLE_THERMAL_POLICY_DEFAULT_VIVO;
> > +			break;
> > +		case ASUS_THROTTLE_THERMAL_POLICY_OVERBOOST:
> > +			value = ASUS_THROTTLE_THERMAL_POLICY_OVERBOOST_VIVO;
> > +			break;
> > +		case ASUS_THROTTLE_THERMAL_POLICY_SILENT:
> > +			value = ASUS_THROTTLE_THERMAL_POLICY_SILENT_VIVO;
> > +			break;
> > +		default:
> > +			break;
> > +		}
> > +	}
> >  
> > -	err = asus_wmi_set_devstate(ASUS_WMI_DEVID_THROTTLE_THERMAL_POLICY,
> > +	err = asus_wmi_set_devstate(asus->throttle_thermal_policy_dev,
> >  				    value, &retval);
> >  
> >  	sysfs_notify(&asus->platform_device->dev.kobj, NULL,
> > @@ -3680,7 +3678,7 @@ static int throttle_thermal_policy_write(struct asus_wmi *asus)
> >  
> >  static int throttle_thermal_policy_set_default(struct asus_wmi *asus)
> >  {
> > -	if (!asus->throttle_thermal_policy_available)
> > +	if (!asus->throttle_thermal_policy_dev)
> >  		return 0;
> >  
> >  	asus->throttle_thermal_policy_mode = ASUS_THROTTLE_THERMAL_POLICY_DEFAULT;
> > @@ -3690,9 +3688,14 @@ static int throttle_thermal_policy_set_default(struct asus_wmi *asus)
> >  static int throttle_thermal_policy_switch_next(struct asus_wmi *asus)
> >  {
> >  	u8 new_mode = asus->throttle_thermal_policy_mode + 1;
> > +	bool vivo;
> >  	int err;
> >  
> > -	if (new_mode > ASUS_THROTTLE_THERMAL_POLICY_SILENT)
> > +	vivo = asus->throttle_thermal_policy_dev == ASUS_WMI_DEVID_THROTTLE_THERMAL_POLICY_VIVO;
> > +	if (!vivo && new_mode > ASUS_THROTTLE_THERMAL_POLICY_SILENT)
> > +		new_mode = ASUS_THROTTLE_THERMAL_POLICY_DEFAULT;
> > +
> > +	if (vivo && new_mode > ASUS_THROTTLE_THERMAL_POLICY_FULLSPEED)
> >  		new_mode = ASUS_THROTTLE_THERMAL_POLICY_DEFAULT;
> 
> Hmm, add a throttle_thermal_policy_max_mode() helper instead so you can do 
> just this:
> 
> 	if (new_mode > throttle_thermal_policy_max_mode(...))
> 		new_mode = ASUS_THROTTLE_THERMAL_POLICY_DEFAULT;
> 
> 

this is definitely better! i'll make the necessary changes in v1.

> >  	asus->throttle_thermal_policy_mode = new_mode;
> > @@ -3725,13 +3728,17 @@ static ssize_t throttle_thermal_policy_store(struct device *dev,
> >  	struct asus_wmi *asus = dev_get_drvdata(dev);
> >  	u8 new_mode;
> >  	int result;
> > +	bool vivo;
> >  	int err;
> >  
> >  	result = kstrtou8(buf, 10, &new_mode);
> >  	if (result < 0)
> >  		return result;
> >  
> > -	if (new_mode > ASUS_THROTTLE_THERMAL_POLICY_SILENT)
> > +	vivo = asus->throttle_thermal_policy_dev == ASUS_WMI_DEVID_THROTTLE_THERMAL_POLICY_VIVO;
> > +	if (vivo && new_mode > ASUS_THROTTLE_THERMAL_POLICY_FULLSPEED)
> > +		return -EINVAL;
> > +	else if (!vivo && new_mode > ASUS_THROTTLE_THERMAL_POLICY_SILENT)
> 
> Use the throttle_thermal_policy_max_mode() helper here too.
> 

i'll do the appropriate changes here too.

> >  		return -EINVAL;
> >  
> >  	asus->throttle_thermal_policy_mode = new_mode;
> 
> -- 
>  i.
> 

thank you for your time.