Received-SPF: pass (google.com: domain of linux-kernel+bounces-147254-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240416163256.2121923-1-Frank.Li@nxp.com>
In-Reply-To: <20240416163256.2121923-1-Frank.Li@nxp.com>
From: Fabio Estevam <festevam@gmail.com>
Date: Tue, 16 Apr 2024 13:41:17 -0300
Message-ID: <CAOMZO5DZ-8Cphm_U+ric4yE0uCXc9cTbVs2BPBzWYQd02xTN5Q@mail.gmail.com>
Subject: Re: [PATCH v2 1/1] arm64: dts: imx8qxp-mek: add cm40_i2c, wm8960 and sai[0,1,4,5]
To: Frank Li <Frank.Li@nxp.com>
Cc: Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, 
	Pengutronix Kernel Team <kernel@pengutronix.de>, 
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, 
	"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <imx@lists.linux.dev>, 
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, 
	open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 16, 2024 at 1:33=E2=80=AFPM Frank Li <Frank.Li@nxp.com> wrote:

> +&cm40_i2c {
> +       #address-cells =3D <1>;
> +       #size-cells =3D <0>;
> +       clock-frequency =3D <100000>;
> +       pinctrl-names =3D "default", "gpio";
> +       pinctrl-0 =3D <&pinctrl_cm40_i2c>;
> +       pinctrl-1 =3D <&pinctrl_cm40_i2c_gpio>;
> +       scl-gpios =3D <&lsio_gpio1 10 GPIO_ACTIVE_HIGH>;
> +       sda-gpios =3D <&lsio_gpio1 9 GPIO_ACTIVE_HIGH>;
> +       status =3D "okay";
> +
> +       wm8960: wm8960@1a {

Node names should be generic, so:

 wm8960: audio-codec@1a {