Received-SPF: pass (google.com: domain of linux-kernel+bounces-147311-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 16 Apr 2024 18:28:58 +0100
From: Conor Dooley <conor@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: djakov@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, matthias.bgg@gmail.com, lgirdwood@gmail.com,
	broonie@kernel.org, keescook@chromium.org, gustavoars@kernel.org,
	henryc.chen@mediatek.com, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, kernel@collabora.com,
	wenst@chromium.org, amergnat@baylibre.com
Subject: Re: [PATCH v1 1/6] dt-bindings: soc: mediatek: Add DVFSRC bindings
 for MT8183 and MT8195
Message-ID: <20240416-grope-blissful-a914854b3732@spud>
References: <20240416153805.431118-1-angelogioacchino.delregno@collabora.com>
 <20240416153805.431118-2-angelogioacchino.delregno@collabora.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="29wYAvcTm3T+HZi+"
Content-Disposition: inline
In-Reply-To: <20240416153805.431118-2-angelogioacchino.delregno@collabora.com>


--29wYAvcTm3T+HZi+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 16, 2024 at 05:38:00PM +0200, AngeloGioacchino Del Regno wrote:
> Add bindings for the MediaTek Dynamic Voltage and Frequency Scaling
> Resource Collector (DVFSRC), a hardware module used to collect all the
> requests from both software and the various remote processors embedded
> into the SoC and decide about a minimum operating voltage and a minimum
> DRAM frequency to fulfill those requests in an effort to provide the
> best achievable performance per watt.
>=20
> This hardware IP is capable of transparently performing direct register
> R/W on all of the DVFSRC-controlled regulators and SoC bandwidth knobs.
>=20
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@coll=
abora.com>
> ---
>  .../soc/mediatek/mediatek,mt8183-dvfsrc.yaml  | 57 +++++++++++++++++++
>  1 file changed, 57 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediat=
ek,mt8183-dvfsrc.yaml
>=20
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mt81=
83-dvfsrc.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mt=
8183-dvfsrc.yaml
> new file mode 100644
> index 000000000000..12bcc3fdfd07
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mt8183-dvfs=
rc.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/mediatek/mediatek,mt8183-dvfsrc.y=
aml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek Dynamic Voltage and Frequency Scaling Resource Collector=
 (DVFSRC)
> +
> +description:
> +  The Dynamic Voltage and Frequency Scaling Resource Collector (DVFSRC) =
is a
> +  Hardware module used to collect all the requests from both software an=
d the
> +  various remote processors embedded into the SoC and decide about a min=
imum
> +  operating voltage and a minimum DRAM frequency to fulfill those reques=
ts in
> +  an effort to provide the best achievable performance per watt.
> +  This hardware IP is capable of transparently performing direct registe=
r R/W
> +  on all of the DVFSRC-controlled regulators and SoC bandwidth knobs.
> +
> +maintainers:
> +  - AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> +  - Henry Chen <henryc.chen@mediatek.com>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:

This items should not be needed with the enum, right?

> +          - enum:
> +              - mediatek,mt8183-dvfsrc
> +              - mediatek,mt8195-dvfsrc
> +      - items:
> +          - const: mediatek,mt8192-dvfsrc
> +          - const: mediatek,mt8195-dvfsrc
> +
> +  reg:
> +    maxItems: 1
> +    description: DVFSRC common register address and length.
> +
> +patternProperties:
> +  "@[0-9a-f]+$":
> +    type: object

Why is there no enforcement of what a child could be here?

> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    soc {
> +        #address-cells =3D <2>;
> +        #size-cells =3D <2>;
> +
> +        dvfsrc@10012000 {

"dvfsrc" looks like something my (imaginary given allergies) cat would
produce from sitting on my keyboard. Could you use full words for the
node name and make it something that attempts to be generic please?

> +            compatible =3D "mediatek,mt8195-dvfsrc";
> +            reg =3D <0 0x10012000 0 0x1000>;
> +        };
> +    };
> --=20
> 2.44.0
>=20

--29wYAvcTm3T+HZi+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZh61WgAKCRB4tDGHoIJi
0nNWAQCySaXXigINWOe/Zbh6nvFd8lAElm6OUs1rfgKt63696wD/R+RgIT2mRIEQ
WUVPpbyXy3TS22RWrWgU0ZHHesGKRgg=
=DGfI
-----END PGP SIGNATURE-----

--29wYAvcTm3T+HZi+--